All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Use detected start offset in intel-bb instead 0x0
@ 2022-05-24 11:18 Zbigniew Kempczyński
  2022-05-24 13:26 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Zbigniew Kempczyński @ 2022-05-24 11:18 UTC (permalink / raw)
  To: igt-dev

On some platforms (like on ATS) 0x0 may not be available so allocator
should be instantiated with safe start offset to avoid getting -ENOSPC.
Change require also relaxation of automatic range selection in the
allocator.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
---
 lib/intel_allocator.c   | 2 +-
 lib/intel_batchbuffer.c | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/intel_allocator.c b/lib/intel_allocator.c
index 340b888286..7882e484b5 100644
--- a/lib/intel_allocator.c
+++ b/lib/intel_allocator.c
@@ -909,7 +909,7 @@ static uint64_t __intel_allocator_open_full(int fd, uint32_t ctx,
 	struct alloc_resp resp;
 	uint64_t gtt_size;
 
-	if (!start && !end) {
+	if (!end) {
 		igt_assert_f(can_report_gtt_size(fd), "Invalid fd\n");
 		gtt_size = gem_aperture_size(fd);
 		if (!gem_uses_full_ppgtt(fd))
diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index 8680c9ba93..555618e463 100644
--- a/lib/intel_batchbuffer.c
+++ b/lib/intel_batchbuffer.c
@@ -1359,6 +1359,9 @@ __intel_bb_create(int i915, uint32_t ctx, uint32_t size, bool do_relocs,
 	if (!ibb->uses_full_ppgtt)
 		do_relocs = true;
 
+	/* Use safe start offset instead assuming 0x0 is safe */
+	start = max_t(uint64_t, start, gem_detect_safe_start_offset(i915));
+
 	/* if relocs are set we won't use an allocator */
 	if (do_relocs)
 		allocator_type = INTEL_ALLOCATOR_NONE;
-- 
2.32.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-05-26  2:37 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-24 11:18 [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Use detected start offset in intel-bb instead 0x0 Zbigniew Kempczyński
2022-05-24 13:26 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-05-24 15:41 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-05-25  5:16   ` Zbigniew Kempczyński
2022-05-26  2:37     ` Vudum, Lakshminarayana
2022-05-25  6:41 ` [igt-dev] [PATCH i-g-t] " Dixit, Ashutosh
2022-05-25  7:07   ` Zbigniew Kempczyński
2022-05-25 20:24 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2022-05-26  2:37 ` Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.