* [PATCH] policycoreutils/setfiles: Improve description of -d switch
@ 2022-04-01 11:27 Petr Lautrbach
2022-04-04 14:53 ` James Carter
0 siblings, 1 reply; 8+ messages in thread
From: Petr Lautrbach @ 2022-04-01 11:27 UTC (permalink / raw)
To: selinux; +Cc: Vit Mojzis
From: Vit Mojzis <vmojzis@redhat.com>
The "-q" switch is becoming obsolete (completely unused in fedora) and
debug output ("-d" switch) makes sense in any scenario. Therefore both
options can be specified at once.
Resolves: rhbz#1271327
Signed-off-by: Vit Mojzis <vmojzis@redhat.com>
---
policycoreutils/setfiles/setfiles.8 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/policycoreutils/setfiles/setfiles.8 b/policycoreutils/setfiles/setfiles.8
index 15f939d1bee0..0aab2aa24681 100644
--- a/policycoreutils/setfiles/setfiles.8
+++ b/policycoreutils/setfiles/setfiles.8
@@ -59,7 +59,7 @@ option will force a replacement of the entire context.
check the validity of the contexts against the specified binary policy.
.TP
.B \-d
-show what specification matched each file.
+show what specification matched each file. Not affected by "\-q".
.TP
.BI \-e \ directory
directory to exclude (repeat option for more than one directory).
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] policycoreutils/setfiles: Improve description of -d switch
2022-04-01 11:27 [PATCH] policycoreutils/setfiles: Improve description of -d switch Petr Lautrbach
@ 2022-04-04 14:53 ` James Carter
2022-04-05 7:17 ` [PATCH v2] setfiles.8: -q is deprecated and has no effect Petr Lautrbach
0 siblings, 1 reply; 8+ messages in thread
From: James Carter @ 2022-04-04 14:53 UTC (permalink / raw)
To: Petr Lautrbach; +Cc: SElinux list, Vit Mojzis
On Fri, Apr 1, 2022 at 9:45 AM Petr Lautrbach <plautrba@redhat.com> wrote:
>
> From: Vit Mojzis <vmojzis@redhat.com>
>
> The "-q" switch is becoming obsolete (completely unused in fedora) and
> debug output ("-d" switch) makes sense in any scenario. Therefore both
> options can be specified at once.
>
> Resolves: rhbz#1271327
>
> Signed-off-by: Vit Mojzis <vmojzis@redhat.com>
> ---
> policycoreutils/setfiles/setfiles.8 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/policycoreutils/setfiles/setfiles.8 b/policycoreutils/setfiles/setfiles.8
> index 15f939d1bee0..0aab2aa24681 100644
> --- a/policycoreutils/setfiles/setfiles.8
> +++ b/policycoreutils/setfiles/setfiles.8
> @@ -59,7 +59,7 @@ option will force a replacement of the entire context.
> check the validity of the contexts against the specified binary policy.
> .TP
> .B \-d
> -show what specification matched each file.
> +show what specification matched each file. Not affected by "\-q".
> .TP
> .BI \-e \ directory
> directory to exclude (repeat option for more than one directory).
> --
> 2.35.1
>
Looking at setfiles.c, specifying "-q" doesn't do anything at all, so
it makes more sense to me to change what it says for "-q".
Maybe:
Deprecated and replaced by "-v". Has no effect on other options or on
program behavior.
Jim
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2] setfiles.8: -q is deprecated and has no effect
2022-04-04 14:53 ` James Carter
@ 2022-04-05 7:17 ` Petr Lautrbach
2022-04-06 20:06 ` James Carter
2022-04-08 8:59 ` [PATCH v3] " Petr Lautrbach
0 siblings, 2 replies; 8+ messages in thread
From: Petr Lautrbach @ 2022-04-05 7:17 UTC (permalink / raw)
To: selinux; +Cc: Petr Lautrbach
Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
---
policycoreutils/setfiles/setfiles.8 | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/policycoreutils/setfiles/setfiles.8 b/policycoreutils/setfiles/setfiles.8
index 15f939d1bee0..5267064de3b5 100644
--- a/policycoreutils/setfiles/setfiles.8
+++ b/policycoreutils/setfiles/setfiles.8
@@ -124,7 +124,9 @@ and
options are mutually exclusive.
.TP
.B \-q
-Deprecated, was only used to stop printing inode association parameters.
+Deprecated and replaced by
+.B \-v
+. Has no effect on other options or on program behavior.
.TP
.BI \-r \ rootpath
use an alternate root path. Used in meta-selinux for OpenEmbedded/Yocto builds
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] setfiles.8: -q is deprecated and has no effect
2022-04-05 7:17 ` [PATCH v2] setfiles.8: -q is deprecated and has no effect Petr Lautrbach
@ 2022-04-06 20:06 ` James Carter
2022-04-07 6:45 ` Petr Lautrbach
2022-04-08 8:59 ` [PATCH v3] " Petr Lautrbach
1 sibling, 1 reply; 8+ messages in thread
From: James Carter @ 2022-04-06 20:06 UTC (permalink / raw)
To: Petr Lautrbach; +Cc: SElinux list
On Tue, Apr 5, 2022 at 3:38 AM Petr Lautrbach <plautrba@redhat.com> wrote:
>
> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
> ---
> policycoreutils/setfiles/setfiles.8 | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/policycoreutils/setfiles/setfiles.8 b/policycoreutils/setfiles/setfiles.8
> index 15f939d1bee0..5267064de3b5 100644
> --- a/policycoreutils/setfiles/setfiles.8
> +++ b/policycoreutils/setfiles/setfiles.8
> @@ -124,7 +124,9 @@ and
> options are mutually exclusive.
> .TP
> .B \-q
> -Deprecated, was only used to stop printing inode association parameters.
> +Deprecated and replaced by
> +.B \-v
> +. Has no effect on other options or on program behavior.
The "." at the beginning causes that line to not appear.
I am no man page expert, but this seems to work.
.B \-q
Deprecated and replaced by \fB\-v\fR. Has no effect on other options
or on program
behavior.
Thanks,
Jim
> .TP
> .BI \-r \ rootpath
> use an alternate root path. Used in meta-selinux for OpenEmbedded/Yocto builds
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] setfiles.8: -q is deprecated and has no effect
2022-04-06 20:06 ` James Carter
@ 2022-04-07 6:45 ` Petr Lautrbach
0 siblings, 0 replies; 8+ messages in thread
From: Petr Lautrbach @ 2022-04-07 6:45 UTC (permalink / raw)
To: SElinux list, James Carter
James Carter <jwcart2@gmail.com> writes:
> On Tue, Apr 5, 2022 at 3:38 AM Petr Lautrbach <plautrba@redhat.com> wrote:
>>
>> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
>> ---
>> policycoreutils/setfiles/setfiles.8 | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/policycoreutils/setfiles/setfiles.8 b/policycoreutils/setfiles/setfiles.8
>> index 15f939d1bee0..5267064de3b5 100644
>> --- a/policycoreutils/setfiles/setfiles.8
>> +++ b/policycoreutils/setfiles/setfiles.8
>> @@ -124,7 +124,9 @@ and
>> options are mutually exclusive.
>> .TP
>> .B \-q
>> -Deprecated, was only used to stop printing inode association parameters.
>> +Deprecated and replaced by
>> +.B \-v
>> +. Has no effect on other options or on program behavior.
>
> The "." at the beginning causes that line to not appear.
>
> I am no man page expert, but this seems to work.
>
> .B \-q
> Deprecated and replaced by \fB\-v\fR. Has no effect on other options
> or on program
> behavior.
>
I'm sorry for that. I really thought I opened the page and checked it
works. Apparently I didn't :(
> Thanks,
> Jim
>
>> .TP
>> .BI \-r \ rootpath
>> use an alternate root path. Used in meta-selinux for OpenEmbedded/Yocto builds
>> --
>> 2.35.1
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3] setfiles.8: -q is deprecated and has no effect
2022-04-05 7:17 ` [PATCH v2] setfiles.8: -q is deprecated and has no effect Petr Lautrbach
2022-04-06 20:06 ` James Carter
@ 2022-04-08 8:59 ` Petr Lautrbach
2022-04-11 12:39 ` James Carter
1 sibling, 1 reply; 8+ messages in thread
From: Petr Lautrbach @ 2022-04-08 8:59 UTC (permalink / raw)
To: selinux; +Cc: James Carter, Petr Lautrbach
From: James Carter <jwcart2@gmail.com>
Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
---
policycoreutils/setfiles/setfiles.8 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/policycoreutils/setfiles/setfiles.8 b/policycoreutils/setfiles/setfiles.8
index 15f939d1bee0..19b59a2cc90d 100644
--- a/policycoreutils/setfiles/setfiles.8
+++ b/policycoreutils/setfiles/setfiles.8
@@ -124,7 +124,7 @@ and
options are mutually exclusive.
.TP
.B \-q
-Deprecated, was only used to stop printing inode association parameters.
+Deprecated and replaced by \fB\-v\fR. Has no effect on other options or on program behavior.
.TP
.BI \-r \ rootpath
use an alternate root path. Used in meta-selinux for OpenEmbedded/Yocto builds
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v3] setfiles.8: -q is deprecated and has no effect
2022-04-08 8:59 ` [PATCH v3] " Petr Lautrbach
@ 2022-04-11 12:39 ` James Carter
2022-04-12 18:04 ` James Carter
0 siblings, 1 reply; 8+ messages in thread
From: James Carter @ 2022-04-11 12:39 UTC (permalink / raw)
To: Petr Lautrbach; +Cc: SElinux list
On Fri, Apr 8, 2022 at 4:59 AM Petr Lautrbach <plautrba@redhat.com> wrote:
>
> From: James Carter <jwcart2@gmail.com>
>
> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
Acked-by: James Carter <jwcart2@gmail.com>
> ---
> policycoreutils/setfiles/setfiles.8 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/policycoreutils/setfiles/setfiles.8 b/policycoreutils/setfiles/setfiles.8
> index 15f939d1bee0..19b59a2cc90d 100644
> --- a/policycoreutils/setfiles/setfiles.8
> +++ b/policycoreutils/setfiles/setfiles.8
> @@ -124,7 +124,7 @@ and
> options are mutually exclusive.
> .TP
> .B \-q
> -Deprecated, was only used to stop printing inode association parameters.
> +Deprecated and replaced by \fB\-v\fR. Has no effect on other options or on program behavior.
> .TP
> .BI \-r \ rootpath
> use an alternate root path. Used in meta-selinux for OpenEmbedded/Yocto builds
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] setfiles.8: -q is deprecated and has no effect
2022-04-11 12:39 ` James Carter
@ 2022-04-12 18:04 ` James Carter
0 siblings, 0 replies; 8+ messages in thread
From: James Carter @ 2022-04-12 18:04 UTC (permalink / raw)
To: Petr Lautrbach; +Cc: SElinux list
On Mon, Apr 11, 2022 at 8:39 AM James Carter <jwcart2@gmail.com> wrote:
>
> On Fri, Apr 8, 2022 at 4:59 AM Petr Lautrbach <plautrba@redhat.com> wrote:
> >
> > From: James Carter <jwcart2@gmail.com>
> >
> > Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
>
> Acked-by: James Carter <jwcart2@gmail.com>
>
Merged.
Thanks,
Jim
> > ---
> > policycoreutils/setfiles/setfiles.8 | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/policycoreutils/setfiles/setfiles.8 b/policycoreutils/setfiles/setfiles.8
> > index 15f939d1bee0..19b59a2cc90d 100644
> > --- a/policycoreutils/setfiles/setfiles.8
> > +++ b/policycoreutils/setfiles/setfiles.8
> > @@ -124,7 +124,7 @@ and
> > options are mutually exclusive.
> > .TP
> > .B \-q
> > -Deprecated, was only used to stop printing inode association parameters.
> > +Deprecated and replaced by \fB\-v\fR. Has no effect on other options or on program behavior.
> > .TP
> > .BI \-r \ rootpath
> > use an alternate root path. Used in meta-selinux for OpenEmbedded/Yocto builds
> > --
> > 2.35.1
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-04-12 18:05 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-01 11:27 [PATCH] policycoreutils/setfiles: Improve description of -d switch Petr Lautrbach
2022-04-04 14:53 ` James Carter
2022-04-05 7:17 ` [PATCH v2] setfiles.8: -q is deprecated and has no effect Petr Lautrbach
2022-04-06 20:06 ` James Carter
2022-04-07 6:45 ` Petr Lautrbach
2022-04-08 8:59 ` [PATCH v3] " Petr Lautrbach
2022-04-11 12:39 ` James Carter
2022-04-12 18:04 ` James Carter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.