All of lore.kernel.org
 help / color / mirror / Atom feed
From: Valentin Schneider <valentin.schneider@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>
Subject: Re: [RFC PATCH v2 08/10] irqchip/gic-v3-its: Use irq_chip_ack_parent()
Date: Tue, 01 Jun 2021 11:25:33 +0100	[thread overview]
Message-ID: <87r1hlg9uq.mognet@arm.com> (raw)
In-Reply-To: <87y2c0s748.wl-maz@kernel.org>

On 27/05/21 13:17, Marc Zyngier wrote:
> On Tue, 25 May 2021 18:32:53 +0100,
> Valentin Schneider <valentin.schneider@arm.com> wrote:
>> o make irq_chip_ack_parent() the default chip->irq_ack() via
>>   MSI_FLAG_USE_DEF_CHIP_OPS.
>
> Seem like a reasonable approach: how about a custom irq_ack() callback
> that iterates over the hierarchy until it finds an a non-NULL entry?
> Flows that don't use ack won't be impacted, users that need ack will
> provide one if they want, and the default will do something slightly
> slower, but at least unsurprising.
>

Sounds about right!

>> XXX: what about pMSI and fMSI ?
>
> Same thing. They are just bus-specific domains on top of the ITS
> domain, and must follow the same convention.
>
> However, this patch is perfectly acceptable to me (as long as you take
> care of platform and fsl -MSI).
>

Noted.

> Thanks,
>
>       M.
>
> --
> Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Valentin Schneider <valentin.schneider@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>
Subject: Re: [RFC PATCH v2 08/10] irqchip/gic-v3-its: Use irq_chip_ack_parent()
Date: Tue, 01 Jun 2021 11:25:33 +0100	[thread overview]
Message-ID: <87r1hlg9uq.mognet@arm.com> (raw)
In-Reply-To: <87y2c0s748.wl-maz@kernel.org>

On 27/05/21 13:17, Marc Zyngier wrote:
> On Tue, 25 May 2021 18:32:53 +0100,
> Valentin Schneider <valentin.schneider@arm.com> wrote:
>> o make irq_chip_ack_parent() the default chip->irq_ack() via
>>   MSI_FLAG_USE_DEF_CHIP_OPS.
>
> Seem like a reasonable approach: how about a custom irq_ack() callback
> that iterates over the hierarchy until it finds an a non-NULL entry?
> Flows that don't use ack won't be impacted, users that need ack will
> provide one if they want, and the default will do something slightly
> slower, but at least unsurprising.
>

Sounds about right!

>> XXX: what about pMSI and fMSI ?
>
> Same thing. They are just bus-specific domains on top of the ITS
> domain, and must follow the same convention.
>
> However, this patch is perfectly acceptable to me (as long as you take
> care of platform and fsl -MSI).
>

Noted.

> Thanks,
>
>       M.
>
> --
> Without deviation from the norm, progress is not possible.

  reply	other threads:[~2021-06-01 10:28 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25 17:32 [RFC PATCH v2 00/10] irqchip/irq-gic: Optimize masking by leveraging EOImode=1 Valentin Schneider
2021-05-25 17:32 ` Valentin Schneider
2021-05-25 17:32 ` [RFC PATCH v2 01/10] genirq: Add chip flag to denote automatic IRQ (un)masking Valentin Schneider
2021-05-25 17:32   ` Valentin Schneider
2021-05-25 17:32 ` [RFC PATCH v2 02/10] genirq: Define irq_ack() and irq_eoi() helpers Valentin Schneider
2021-05-25 17:32   ` Valentin Schneider
2021-05-25 20:54   ` kernel test robot
2021-05-27 10:55   ` Marc Zyngier
2021-05-27 10:55     ` Marc Zyngier
2021-05-27 10:58     ` Marc Zyngier
2021-05-27 10:58       ` Marc Zyngier
2021-06-01 10:25       ` Valentin Schneider
2021-06-01 10:25         ` Valentin Schneider
2021-05-25 17:32 ` [RFC PATCH v2 03/10] genirq: Employ ack_irq() and eoi_irq() where relevant Valentin Schneider
2021-05-25 17:32   ` Valentin Schneider
2021-05-25 17:32 ` [RFC PATCH v2 04/10] genirq: Add handle_strict_flow_irq() flow handler Valentin Schneider
2021-05-25 17:32   ` Valentin Schneider
2021-05-25 17:32 ` [RFC PATCH v2 05/10] genirq: Let purely flow-masked ONESHOT irqs through unmask_threaded_irq() Valentin Schneider
2021-05-25 17:32   ` Valentin Schneider
2021-05-25 17:32 ` [RFC PATCH v2 06/10] genirq: Don't mask IRQ within flow handler if IRQ is flow-masked Valentin Schneider
2021-05-25 17:32   ` Valentin Schneider
2021-05-25 17:32 ` [RFC PATCH v2 07/10] genirq, irq-gic-v3: Make NMI flow handlers use ->irq_ack() if available Valentin Schneider
2021-05-25 17:32   ` Valentin Schneider
2021-05-25 17:32 ` [RFC PATCH v2 08/10] irqchip/gic-v3-its: Use irq_chip_ack_parent() Valentin Schneider
2021-05-25 17:32   ` Valentin Schneider
2021-05-27 12:17   ` Marc Zyngier
2021-05-27 12:17     ` Marc Zyngier
2021-06-01 10:25     ` Valentin Schneider [this message]
2021-06-01 10:25       ` Valentin Schneider
2021-05-25 17:32 ` [RFC PATCH v2 09/10] irqchip/gic: Convert to handle_strict_flow_irq() Valentin Schneider
2021-05-25 17:32   ` Valentin Schneider
2021-05-27 12:21   ` Marc Zyngier
2021-05-27 12:21     ` Marc Zyngier
2021-06-01 10:25     ` Valentin Schneider
2021-06-01 10:25       ` Valentin Schneider
2021-06-15 15:20       ` Valentin Schneider
2021-06-15 15:20         ` Valentin Schneider
2021-05-25 17:32 ` [RFC PATCH v2 10/10] irqchip/gic-v3: " Valentin Schneider
2021-05-25 17:32   ` Valentin Schneider
2021-05-25 17:34 ` [RFC PATCH v2 00/10] irqchip/irq-gic: Optimize masking by leveraging EOImode=1 Valentin Schneider
2021-05-25 17:34   ` Valentin Schneider
2021-05-27 11:17 ` Marc Zyngier
2021-05-27 11:17   ` Marc Zyngier
2021-06-01 10:25   ` Valentin Schneider
2021-06-01 10:25     ` Valentin Schneider
2021-06-03 15:32     ` Valentin Schneider
2021-06-03 15:32       ` Valentin Schneider
2021-06-08 15:29     ` Marc Zyngier
2021-06-08 15:29       ` Marc Zyngier
2021-06-08 17:58       ` Lorenzo Pieralisi
2021-06-08 17:58         ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1hlg9uq.mognet@arm.com \
    --to=valentin.schneider@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vincenzo.frascino@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.