From: Baruch Siach <baruch@tkos.co.il>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-mediatek <linux-mediatek@lists.infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] drm/mediatek: Remove redundant error printing in mtk_cec_probe()
Date: Tue, 11 May 2021 16:13:18 +0300 [thread overview]
Message-ID: <87r1idwh01.fsf@tarshish> (raw)
In-Reply-To: <20210511113200.5439-1-thunder.leizhen@huawei.com>
Hi Zhen Lei,
On Tue, May 11 2021, Zhen Lei wrote:
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/gpu/drm/mediatek/mtk_cec.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_cec.c b/drivers/gpu/drm/mediatek/mtk_cec.c
> index e9cef5c0c8f7eff..fd593ff99bfd447 100644
> --- a/drivers/gpu/drm/mediatek/mtk_cec.c
> +++ b/drivers/gpu/drm/mediatek/mtk_cec.c
> @@ -197,7 +197,6 @@ static int mtk_cec_probe(struct platform_device *pdev)
> cec->regs = devm_ioremap_resource(dev, res);
> if (IS_ERR(cec->regs)) {
> ret = PTR_ERR(cec->regs);
> - dev_err(dev, "Failed to ioremap cec: %d\n", ret);
> return ret;
You can just return PTR_ERR() directly. No need to set 'ret'.
baruch
> }
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-mediatek <linux-mediatek@lists.infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] drm/mediatek: Remove redundant error printing in mtk_cec_probe()
Date: Tue, 11 May 2021 16:13:18 +0300 [thread overview]
Message-ID: <87r1idwh01.fsf@tarshish> (raw)
In-Reply-To: <20210511113200.5439-1-thunder.leizhen@huawei.com>
Hi Zhen Lei,
On Tue, May 11 2021, Zhen Lei wrote:
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/gpu/drm/mediatek/mtk_cec.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_cec.c b/drivers/gpu/drm/mediatek/mtk_cec.c
> index e9cef5c0c8f7eff..fd593ff99bfd447 100644
> --- a/drivers/gpu/drm/mediatek/mtk_cec.c
> +++ b/drivers/gpu/drm/mediatek/mtk_cec.c
> @@ -197,7 +197,6 @@ static int mtk_cec_probe(struct platform_device *pdev)
> cec->regs = devm_ioremap_resource(dev, res);
> if (IS_ERR(cec->regs)) {
> ret = PTR_ERR(cec->regs);
> - dev_err(dev, "Failed to ioremap cec: %d\n", ret);
> return ret;
You can just return PTR_ERR() directly. No need to set 'ret'.
baruch
> }
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
David Airlie <airlied@linux.ie>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-mediatek <linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] drm/mediatek: Remove redundant error printing in mtk_cec_probe()
Date: Tue, 11 May 2021 16:13:18 +0300 [thread overview]
Message-ID: <87r1idwh01.fsf@tarshish> (raw)
In-Reply-To: <20210511113200.5439-1-thunder.leizhen@huawei.com>
Hi Zhen Lei,
On Tue, May 11 2021, Zhen Lei wrote:
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/gpu/drm/mediatek/mtk_cec.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_cec.c b/drivers/gpu/drm/mediatek/mtk_cec.c
> index e9cef5c0c8f7eff..fd593ff99bfd447 100644
> --- a/drivers/gpu/drm/mediatek/mtk_cec.c
> +++ b/drivers/gpu/drm/mediatek/mtk_cec.c
> @@ -197,7 +197,6 @@ static int mtk_cec_probe(struct platform_device *pdev)
> cec->regs = devm_ioremap_resource(dev, res);
> if (IS_ERR(cec->regs)) {
> ret = PTR_ERR(cec->regs);
> - dev_err(dev, "Failed to ioremap cec: %d\n", ret);
> return ret;
You can just return PTR_ERR() directly. No need to set 'ret'.
baruch
> }
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2021-05-11 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 11:32 [PATCH 1/1] drm/mediatek: Remove redundant error printing in mtk_cec_probe() Zhen Lei
2021-05-11 11:32 ` Zhen Lei
2021-05-11 11:32 ` Zhen Lei
2021-05-11 13:13 ` Baruch Siach [this message]
2021-05-11 13:13 ` Baruch Siach
2021-05-11 13:13 ` Baruch Siach
2021-05-11 13:18 ` Leizhen (ThunderTown)
2021-05-11 13:18 ` Leizhen (ThunderTown)
2021-05-11 13:18 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1idwh01.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.