All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: vsementsov@virtuozzo.com, jsnow@redhat.com,
	qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [PATCH] qapi: Delete unwanted indentation of top-level expressions
Date: Thu, 30 Jul 2020 16:50:33 +0200	[thread overview]
Message-ID: <87r1stvyyu.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <28f91ce9-2f7d-d4b9-a300-c778c6c20992@redhat.com> (Max Reitz's message of "Thu, 30 Jul 2020 15:11:13 +0200")

Max Reitz <mreitz@redhat.com> writes:

> On 30.07.20 11:16, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  qapi/block-core.json | 24 ++++++++++++------------
>>  qapi/ui.json         |  4 ++--
>>  2 files changed, 14 insertions(+), 14 deletions(-)
>> 
>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>> index ab7bf3c612..bdcc8e5f9f 100644
>> --- a/qapi/block-core.json
>> +++ b/qapi/block-core.json
>> @@ -1847,8 +1847,8 @@
>>  #
>>  # Since: 4.0
>>  ##
>> -  { 'enum': 'BlockPermission',
>> -    'data': [ 'consistent-read', 'write', 'write-unchanged', 'resize',
>> +{ 'enum': 'BlockPermission',
>> +  'data': [ 'consistent-read', 'write', 'write-unchanged', 'resize',
>>                'graph-mod' ] }
>
> Do we want to keep the alignment at the opening parenthesis here?

Yes, we do.  Thanks!



  reply	other threads:[~2020-07-30 14:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30  9:16 [PATCH] qapi: Delete unwanted indentation of top-level expressions Markus Armbruster
2020-07-30 13:11 ` Max Reitz
2020-07-30 14:50   ` Markus Armbruster [this message]
2020-07-30 14:56 ` Eric Blake
2020-08-03  6:24 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1stvyyu.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.