From: Felipe Balbi <balbi@kernel.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>, Jun Li <jun.li@nxp.com>,
Jun Li <lijun.kernel@gmail.com>
Cc: John Stultz <john.stultz@linaro.org>,
lkml <linux-kernel@vger.kernel.org>,
Yu Chen <chenyu56@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
ShuFan Lee <shufan_lee@richtek.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Hans de Goede <hdegoede@redhat.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Valentin Schneider <valentin.schneider@arm.com>,
Jack Pham <jackp@codeaurora.org>,
Linux USB List <linux-usb@vger.kernel.org>,
"open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Peter Chen <peter.chen@nxp.com>
Subject: Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller
Date: Thu, 21 May 2020 09:22:51 +0300 [thread overview]
Message-ID: <87r1vdx0w4.fsf@kernel.org> (raw)
In-Reply-To: <87v9kpx0zh.fsf@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]
Hi Jun,
Felipe Balbi <balbi@kernel.org> writes:
>> In any case, increasing the timeout should be fine with me. It maybe
>> difficult to determine the max timeout base on the slowest clock rate
>> and number of cycles. Different controller and controller versions
>> behave differently and may have different number of clock cycles to
>> complete a command.
>>
>> The RTL engineer recommended timeout to be at least 1ms (which maybe
>> more than the polling rate of this patch). I'm fine with either the rate
>> provided by this tested patch or higher.
>
> A whole ms waiting for a command to complete? Wow, that's a lot of time
> blocking the CPU. It looks like, perhaps, we should move to command
> completion interrupts. The difficulty here is that we issue commands
> from within the interrupt handler and, as such, can't
> wait_for_completion().
>
> Meanwhile, we will take the timeout increase I guess, otherwise NXP
> won't have a working setup.
patch 1 in this series doesn't apply to testing/next. Care to rebase and
resend?
Thank you
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-05-21 6:23 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 21:59 [PATCH v4 0/9] Prereqs for HiKey960 USB support John Stultz
2019-10-28 21:59 ` [PATCH v4 1/9] dt-bindings: usb: rt1711h: Add connector bindings John Stultz
2019-10-28 21:59 ` [PATCH v4 2/9] usb: dwc3: Execute GCTL Core Soft Reset while switch modes John Stultz
2019-10-29 9:09 ` Felipe Balbi
2019-10-29 21:21 ` John Stultz
2019-10-28 21:59 ` [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller John Stultz
2019-10-29 9:11 ` Felipe Balbi
2019-10-29 21:17 ` John Stultz
2020-05-06 9:00 ` Jun Li
2020-05-06 22:27 ` John Stultz
2020-05-07 3:08 ` Jun Li
2020-05-08 12:22 ` Jun Li
2020-05-08 12:35 ` Felipe Balbi
2020-05-09 8:28 ` Jun Li
2020-05-08 12:33 ` Felipe Balbi
2020-05-09 8:10 ` Jun Li
2020-05-15 9:31 ` Felipe Balbi
2020-05-15 10:07 ` Jun Li
2020-05-15 10:41 ` Felipe Balbi
2020-05-16 0:25 ` Thinh Nguyen
2020-05-16 7:12 ` Felipe Balbi
2020-05-16 9:20 ` Jun Li
2020-05-16 11:57 ` Felipe Balbi
2020-05-19 2:24 ` Jun Li
2020-05-19 6:28 ` Thinh Nguyen
2020-05-19 6:46 ` Thinh Nguyen
2020-05-19 7:39 ` Jun Li
2020-05-21 1:07 ` Thinh Nguyen
2020-05-21 1:55 ` Thinh Nguyen
2020-05-21 6:20 ` Felipe Balbi
2020-05-21 6:22 ` Felipe Balbi [this message]
2020-05-21 7:47 ` Jun Li
2020-05-21 7:33 ` Jun Li
2019-10-28 21:59 ` [PATCH v4 4/9] dt-bindings: usb: dwc3: Allow clock list & resets to be more flexible John Stultz
2019-10-28 21:59 ` [PATCH v4 5/9] usb: dwc3: Rework clock initialization " John Stultz
2019-10-29 9:13 ` Felipe Balbi
2019-10-29 16:08 ` John Stultz
2019-10-30 9:02 ` Felipe Balbi
2019-11-07 21:53 ` Rob Herring
2019-10-28 21:59 ` [PATCH v4 6/9] usb: dwc3: Rework resets " John Stultz
2019-10-29 9:17 ` Felipe Balbi
2019-10-29 18:05 ` John Stultz
2019-10-30 9:01 ` Felipe Balbi
2019-11-07 21:45 ` Rob Herring
2019-10-28 21:59 ` [PATCH v4 7/9] usb: dwc3: Registering a role switch in the DRD code John Stultz
2019-10-29 9:21 ` Felipe Balbi
2019-11-07 23:20 ` John Stultz
2019-10-28 21:59 ` [PATCH v4 8/9] dt-bindings: usb: generic: Add role-switch-default-host binding John Stultz
2019-10-29 9:23 ` Felipe Balbi
2019-10-29 18:26 ` John Stultz
2019-10-28 21:59 ` [PATCH v4 9/9] usb: dwc3: Add host-mode as default support John Stultz
2019-10-29 9:25 ` Felipe Balbi
2019-11-07 22:23 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1vdx0w4.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andy.shevchenko@gmail.com \
--cc=chenyu56@huawei.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jackp@codeaurora.org \
--cc=john.stultz@linaro.org \
--cc=jun.li@nxp.com \
--cc=lijun.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shufan_lee@richtek.com \
--cc=suzuki.poulose@arm.com \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.