All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Rajat Jain" <rajatja@google.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Sean Paul" <sean@poorly.run>, "David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Imre Deak" <imre.deak@intel.com>,
	"José Roberto de Souza" <jose.souza@intel.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, gregkh@linuxfoundation.org,
	mathewk@google.com,
	"Daniel Thompson" <daniel.thompson@linaro.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Pavel Machek" <pavel@denx.de>,
	seanpaul@google.com, "Duncan Laurie" <dlaurie@google.com>,
	jsbarnes@google.com, "Thierry Reding" <thierry.reding@gmail.com>,
	mpearson@lenovo.com, "Nitin Joshi1" <njoshi1@lenovo.com>,
	"Sugumaran Lacshiminarayanan" <slacshiminar@lenovo.com>,
	"Tomoki Maruichi" <maruichit@lenovo.com>
Cc: Rajat Jain <rajatja@google.com>, rajatxjain@gmail.com
Subject: Re: [PATCH v6 1/3] intel_acpi: Rename drm_dev local variable to dev
Date: Thu, 05 Mar 2020 11:14:55 +0200	[thread overview]
Message-ID: <87r1y7noxc.fsf@intel.com> (raw)
In-Reply-To: <20200305012338.219746-2-rajatja@google.com>

On Wed, 04 Mar 2020, Rajat Jain <rajatja@google.com> wrote:
> Change the struct drm_device * local variable from drm_dev to dev
> per the feedback received here:
> https://lkml.org/lkml/2020/1/24/1143
>
> Signed-off-by: Rajat Jain <rajatja@google.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> v6: Initial patch (v6 to match other patches in the set) 
>
>  drivers/gpu/drm/i915/display/intel_acpi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
> index e21fb14d5e07b..3e6831cca4ac1 100644
> --- a/drivers/gpu/drm/i915/display/intel_acpi.c
> +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
> @@ -224,13 +224,13 @@ static u32 acpi_display_type(struct intel_connector *connector)
>  
>  void intel_acpi_device_id_update(struct drm_i915_private *dev_priv)
>  {
> -	struct drm_device *drm_dev = &dev_priv->drm;
> +	struct drm_device *dev = &dev_priv->drm;
>  	struct intel_connector *connector;
>  	struct drm_connector_list_iter conn_iter;
>  	u8 display_index[16] = {};
>  
>  	/* Populate the ACPI IDs for all connectors for a given drm_device */
> -	drm_connector_list_iter_begin(drm_dev, &conn_iter);
> +	drm_connector_list_iter_begin(dev, &conn_iter);
>  	for_each_intel_connector_iter(connector, &conn_iter) {
>  		u32 device_id, type;

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Rajat Jain" <rajatja@google.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Sean Paul" <sean@poorly.run>, "David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Imre Deak" <imre.deak@intel.com>,
	"José Roberto de Souza" <jose.souza@intel.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, gregkh@linuxfoundation.org,
	mathewk@google.com,
	"Daniel Thompson" <daniel.thompson@linaro.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Pavel Machek" <pavel@denx.de>,
	seanpaul@google.com, "Duncan Laurie" <dlaurie@google.com>,
	jsbarnes@google.com, "Thierry Reding" <thierry.reding@gmail.com>,
	mpearson@lenovo.com, "Nitin Joshi1" <njoshi1@lenovo.com>,
	"Sugumaran Lacshiminarayanan" <slacshiminar@lenovo.com>,
	"Tomoki Maruichi" <maruichit@lenovo.com>
Cc: rajatxjain@gmail.com
Subject: Re: [Intel-gfx] [PATCH v6 1/3] intel_acpi: Rename drm_dev local variable to dev
Date: Thu, 05 Mar 2020 11:14:55 +0200	[thread overview]
Message-ID: <87r1y7noxc.fsf@intel.com> (raw)
In-Reply-To: <20200305012338.219746-2-rajatja@google.com>

On Wed, 04 Mar 2020, Rajat Jain <rajatja@google.com> wrote:
> Change the struct drm_device * local variable from drm_dev to dev
> per the feedback received here:
> https://lkml.org/lkml/2020/1/24/1143
>
> Signed-off-by: Rajat Jain <rajatja@google.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> v6: Initial patch (v6 to match other patches in the set) 
>
>  drivers/gpu/drm/i915/display/intel_acpi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
> index e21fb14d5e07b..3e6831cca4ac1 100644
> --- a/drivers/gpu/drm/i915/display/intel_acpi.c
> +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
> @@ -224,13 +224,13 @@ static u32 acpi_display_type(struct intel_connector *connector)
>  
>  void intel_acpi_device_id_update(struct drm_i915_private *dev_priv)
>  {
> -	struct drm_device *drm_dev = &dev_priv->drm;
> +	struct drm_device *dev = &dev_priv->drm;
>  	struct intel_connector *connector;
>  	struct drm_connector_list_iter conn_iter;
>  	u8 display_index[16] = {};
>  
>  	/* Populate the ACPI IDs for all connectors for a given drm_device */
> -	drm_connector_list_iter_begin(drm_dev, &conn_iter);
> +	drm_connector_list_iter_begin(dev, &conn_iter);
>  	for_each_intel_connector_iter(connector, &conn_iter) {
>  		u32 device_id, type;

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Rajat Jain" <rajatja@google.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Sean Paul" <sean@poorly.run>, "David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Imre Deak" <imre.deak@intel.com>,
	"José Roberto de Souza" <jose.souza@intel.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, gregkh@linuxfoundation.org,
	mathewk@google.com,
	"Daniel Thompson" <daniel.thompson@linaro.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Pavel Machek" <pavel@denx.de>,
	seanpaul@google.com, "Duncan Laurie" <dlaurie@google.com>,
	jsbarnes@google.com, "Thierry Reding" <thierry.reding@gmail.com>,
	mpearson@lenovo.com, "Nitin Joshi1" <njoshi1@lenovo.com>,
	"Sugumaran Lacshiminarayanan" <slacshiminar@lenovo.com>,
	"Tomoki Maruichi" <maruichit@lenovo.com>
Cc: Rajat Jain <rajatja@google.com>, rajatxjain@gmail.com
Subject: Re: [PATCH v6 1/3] intel_acpi: Rename drm_dev local variable to dev
Date: Thu, 05 Mar 2020 11:14:55 +0200	[thread overview]
Message-ID: <87r1y7noxc.fsf@intel.com> (raw)
In-Reply-To: <20200305012338.219746-2-rajatja@google.com>

On Wed, 04 Mar 2020, Rajat Jain <rajatja@google.com> wrote:
> Change the struct drm_device * local variable from drm_dev to dev
> per the feedback received here:
> https://lkml.org/lkml/2020/1/24/1143
>
> Signed-off-by: Rajat Jain <rajatja@google.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> v6: Initial patch (v6 to match other patches in the set) 
>
>  drivers/gpu/drm/i915/display/intel_acpi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
> index e21fb14d5e07b..3e6831cca4ac1 100644
> --- a/drivers/gpu/drm/i915/display/intel_acpi.c
> +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
> @@ -224,13 +224,13 @@ static u32 acpi_display_type(struct intel_connector *connector)
>  
>  void intel_acpi_device_id_update(struct drm_i915_private *dev_priv)
>  {
> -	struct drm_device *drm_dev = &dev_priv->drm;
> +	struct drm_device *dev = &dev_priv->drm;
>  	struct intel_connector *connector;
>  	struct drm_connector_list_iter conn_iter;
>  	u8 display_index[16] = {};
>  
>  	/* Populate the ACPI IDs for all connectors for a given drm_device */
> -	drm_connector_list_iter_begin(drm_dev, &conn_iter);
> +	drm_connector_list_iter_begin(dev, &conn_iter);
>  	for_each_intel_connector_iter(connector, &conn_iter) {
>  		u32 device_id, type;

-- 
Jani Nikula, Intel Open Source Graphics Center

  reply	other threads:[~2020-03-05  9:15 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200305012338.219746-1-rajatja@google.com>
2020-03-05  1:23 ` [PATCH v6 1/3] intel_acpi: Rename drm_dev local variable to dev Rajat Jain
2020-03-05  1:23   ` Rajat Jain
2020-03-05  1:23   ` [Intel-gfx] " Rajat Jain
2020-03-05  9:14   ` Jani Nikula [this message]
2020-03-05  9:14     ` Jani Nikula
2020-03-05  9:14     ` [Intel-gfx] " Jani Nikula
2020-03-05  1:23 ` [PATCH v6 2/3] drm/i915: Lookup and attach ACPI device node for connectors Rajat Jain
2020-03-05  1:23   ` Rajat Jain
2020-03-05  1:23   ` [Intel-gfx] " Rajat Jain
2020-03-05  9:40   ` Jani Nikula
2020-03-05  9:40     ` Jani Nikula
2020-03-05  9:40     ` [Intel-gfx] " Jani Nikula
2020-03-06  3:27     ` Rajat Jain
2020-03-06  3:27       ` Rajat Jain
2020-03-06  3:27       ` [Intel-gfx] " Rajat Jain
2020-03-06  9:42       ` Jani Nikula
2020-03-06  9:42         ` Jani Nikula
2020-03-06  9:42         ` [Intel-gfx] " Jani Nikula
2020-03-07  1:38         ` Rajat Jain
2020-03-07  1:38           ` Rajat Jain
2020-03-07  1:38           ` [Intel-gfx] " Rajat Jain
2020-03-10  0:09           ` Rajat Jain
2020-03-10  0:09             ` Rajat Jain
2020-03-10  0:09             ` [Intel-gfx] " Rajat Jain
2020-03-05  1:23 ` [PATCH v6 3/3] drm/i915: Add support for integrated privacy screens Rajat Jain
2020-03-05  1:23   ` Rajat Jain
2020-03-05  1:23   ` [Intel-gfx] " Rajat Jain
2020-03-05 10:01   ` Jani Nikula
2020-03-05 10:01     ` Jani Nikula
2020-03-05 10:01     ` [Intel-gfx] " Jani Nikula
2020-03-06  3:35     ` Rajat Jain
2020-03-06  3:35       ` Rajat Jain
2020-03-06  3:35       ` [Intel-gfx] " Rajat Jain
2020-03-06 10:15       ` Jani Nikula
2020-03-06 10:15         ` Jani Nikula
2020-03-06 10:15         ` [Intel-gfx] " Jani Nikula
2020-03-07  1:27         ` Rajat Jain
2020-03-07  1:27           ` Rajat Jain
2020-03-07  1:27           ` [Intel-gfx] " Rajat Jain
2020-03-05 19:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v6,1/3] intel_acpi: Rename drm_dev local variable to dev Patchwork
2020-03-05 19:17 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2020-03-05 19:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-03-06 10:14 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-03-05  1:19 [PATCH v6 1/3] " Rajat Jain
2020-03-05  1:19 ` Rajat Jain
2020-03-05 10:06 ` Jani Nikula
2020-03-05 10:06   ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1y7noxc.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=chris@chris-wilson.co.uk \
    --cc=corbet@lwn.net \
    --cc=daniel.thompson@linaro.org \
    --cc=daniel@ffwll.ch \
    --cc=dlaurie@google.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=jose.souza@intel.com \
    --cc=jsbarnes@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maruichit@lenovo.com \
    --cc=mathewk@google.com \
    --cc=mpearson@lenovo.com \
    --cc=mripard@kernel.org \
    --cc=njoshi1@lenovo.com \
    --cc=pavel@denx.de \
    --cc=rajatja@google.com \
    --cc=rajatxjain@gmail.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=sean@poorly.run \
    --cc=seanpaul@google.com \
    --cc=slacshiminar@lenovo.com \
    --cc=thierry.reding@gmail.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.