From: Kalle Valo <kvalo@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 2/2] ath10k: pci: remove unnecessary casts
Date: Fri, 28 Jun 2019 08:08:04 +0300 [thread overview]
Message-ID: <87r27eqouj.fsf@codeaurora.org> (raw)
In-Reply-To: <a6c87741bc3e992bf61d2706834e069917018745.camel@sipsolutions.net> (Johannes Berg's message of "Thu, 27 Jun 2019 21:15:48 +0200")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Thu, 2019-06-27 at 21:12 +0200, Johannes Berg wrote:
>> On Thu, 2019-06-27 at 21:47 +0300, Kalle Valo wrote:
>> > Fixes checkpatch warnings:
>> >
>> > drivers/net/wireless/ath/ath10k/pci.c:926: unnecessary cast may
>> > hide bugs, see http://c-faq.com/malloc/ma
>> > drivers/net/wireless/ath/ath10k/pci.c:1072: unnecessary cast may
>> > hide bugs, see http://c-faq.com/malloc/m
>>
>> I think you cut off the link there, did you mean
>> http://c-faq.com/malloc/mallocnocast.html perhaps?
Yes, thanks. Fixed now in the pending branch.
> Which I should've read before replying ... WHAT? We consider calling
> undeclared functions an *error* in the kernel, this is quite pointless.
Yeah, the link checkpatch provides is pointless. TBH I didn't even read
it until you commented on it :) But the patch is still good to have as
there's no point of use casting on void pointers, it's just extra cruft.
Right?
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] ath10k: pci: remove unnecessary casts
Date: Fri, 28 Jun 2019 08:08:04 +0300 [thread overview]
Message-ID: <87r27eqouj.fsf@codeaurora.org> (raw)
In-Reply-To: <a6c87741bc3e992bf61d2706834e069917018745.camel@sipsolutions.net> (Johannes Berg's message of "Thu, 27 Jun 2019 21:15:48 +0200")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Thu, 2019-06-27 at 21:12 +0200, Johannes Berg wrote:
>> On Thu, 2019-06-27 at 21:47 +0300, Kalle Valo wrote:
>> > Fixes checkpatch warnings:
>> >
>> > drivers/net/wireless/ath/ath10k/pci.c:926: unnecessary cast may
>> > hide bugs, see http://c-faq.com/malloc/ma
>> > drivers/net/wireless/ath/ath10k/pci.c:1072: unnecessary cast may
>> > hide bugs, see http://c-faq.com/malloc/m
>>
>> I think you cut off the link there, did you mean
>> http://c-faq.com/malloc/mallocnocast.html perhaps?
Yes, thanks. Fixed now in the pending branch.
> Which I should've read before replying ... WHAT? We consider calling
> undeclared functions an *error* in the kernel, this is quite pointless.
Yeah, the link checkpatch provides is pointless. TBH I didn't even read
it until you commented on it :) But the patch is still good to have as
there's no point of use casting on void pointers, it's just extra cruft.
Right?
--
Kalle Valo
next prev parent reply other threads:[~2019-06-28 5:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 18:47 [PATCH 1/2] ath10k: remove unnecessary 'out of memory' message Kalle Valo
2019-06-27 18:47 ` Kalle Valo
2019-06-27 18:47 ` [PATCH 2/2] ath10k: pci: remove unnecessary casts Kalle Valo
2019-06-27 18:47 ` Kalle Valo
2019-06-27 19:12 ` Johannes Berg
2019-06-27 19:12 ` Johannes Berg
2019-06-27 19:15 ` Johannes Berg
2019-06-27 19:15 ` Johannes Berg
2019-06-28 5:08 ` Kalle Valo [this message]
2019-06-28 5:08 ` Kalle Valo
2019-06-28 19:14 ` [PATCH 1/2] ath10k: remove unnecessary 'out of memory' message Kalle Valo
2019-06-28 19:14 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r27eqouj.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.