From: Felipe Balbi <balbi@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
robh+dt@kernel.org, mark.rutland@arm.com
Cc: gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com,
hdegoede@redhat.com, andy.shevchenko@gmail.com,
linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH v6] usb: gadget: udc: renesas_usb3: Add register of usb role switch
Date: Thu, 26 Jul 2018 13:58:22 +0300 [thread overview]
Message-ID: <87r2jq1cxd.fsf@linux.intel.com> (raw)
In-Reply-To: <1527747093-1674-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 1492 bytes --]
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes:
> This patch adds role switch support for R-Car SoCs into the USB 3.0
> peripheral driver. Some R-Car SoCs (e.g. R-Car H3) have USB 3.0
> dual-role device controller which has the USB 3.0 xHCI host and
> Renesas USB 3.0 peripheral.
>
> Unfortunately, the mode change register (DRD_CON) contains
> the USB 3.0 peripheral controller side only. So, this renesas_usb3
> driver manages the DRD_CON now. However, in peripheral mode, the host
> should stop. Also the host hardware needs to reinitialize its own
> registers when the mode changes from peripheral to host mode.
> Otherwise, the host cannot work correctly (e.g. detect a device
> as high-speed).
>
> To achieve this reinitialization by a driver, this driver also
> registers a role switch driver to manage the DRD_CON and get
> a device pointer of usb 3.0 host from "companion" property of OF.
> Then, when the usb role is changed, renesas_usb3_role_switch_set()
> will attach/release the xhci-plat driver to reinitialize the host
> hardware.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
unfortunately doesn't apply:
checking file drivers/usb/gadget/udc/Kconfig
Hunk #1 FAILED at 193.
1 out of 1 hunk FAILED
checking file drivers/usb/gadget/udc/renesas_usb3.c
Hunk #7 succeeded at 2465 (offset -12 lines).
Hunk #8 succeeded at 2624 (offset -11 lines).
Hunk #9 succeeded at 2715 (offset -11 lines).
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
robh+dt@kernel.org, mark.rutland@arm.com
Cc: gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com,
hdegoede@redhat.com, andy.shevchenko@gmail.com,
linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org
Subject: [v6] usb: gadget: udc: renesas_usb3: Add register of usb role switch
Date: Thu, 26 Jul 2018 13:58:22 +0300 [thread overview]
Message-ID: <87r2jq1cxd.fsf@linux.intel.com> (raw)
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes:
> This patch adds role switch support for R-Car SoCs into the USB 3.0
> peripheral driver. Some R-Car SoCs (e.g. R-Car H3) have USB 3.0
> dual-role device controller which has the USB 3.0 xHCI host and
> Renesas USB 3.0 peripheral.
>
> Unfortunately, the mode change register (DRD_CON) contains
> the USB 3.0 peripheral controller side only. So, this renesas_usb3
> driver manages the DRD_CON now. However, in peripheral mode, the host
> should stop. Also the host hardware needs to reinitialize its own
> registers when the mode changes from peripheral to host mode.
> Otherwise, the host cannot work correctly (e.g. detect a device
> as high-speed).
>
> To achieve this reinitialization by a driver, this driver also
> registers a role switch driver to manage the DRD_CON and get
> a device pointer of usb 3.0 host from "companion" property of OF.
> Then, when the usb role is changed, renesas_usb3_role_switch_set()
> will attach/release the xhci-plat driver to reinitialize the host
> hardware.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
unfortunately doesn't apply:
checking file drivers/usb/gadget/udc/Kconfig
Hunk #1 FAILED at 193.
1 out of 1 hunk FAILED
checking file drivers/usb/gadget/udc/renesas_usb3.c
Hunk #7 succeeded at 2465 (offset -12 lines).
Hunk #8 succeeded at 2624 (offset -11 lines).
Hunk #9 succeeded at 2715 (offset -11 lines).
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
robh+dt@kernel.org, mark.rutland@arm.com
Cc: gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com,
hdegoede@redhat.com, andy.shevchenko@gmail.com,
linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v6] usb: gadget: udc: renesas_usb3: Add register of usb role switch
Date: Thu, 26 Jul 2018 13:58:22 +0300 [thread overview]
Message-ID: <87r2jq1cxd.fsf@linux.intel.com> (raw)
In-Reply-To: <1527747093-1674-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 1492 bytes --]
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes:
> This patch adds role switch support for R-Car SoCs into the USB 3.0
> peripheral driver. Some R-Car SoCs (e.g. R-Car H3) have USB 3.0
> dual-role device controller which has the USB 3.0 xHCI host and
> Renesas USB 3.0 peripheral.
>
> Unfortunately, the mode change register (DRD_CON) contains
> the USB 3.0 peripheral controller side only. So, this renesas_usb3
> driver manages the DRD_CON now. However, in peripheral mode, the host
> should stop. Also the host hardware needs to reinitialize its own
> registers when the mode changes from peripheral to host mode.
> Otherwise, the host cannot work correctly (e.g. detect a device
> as high-speed).
>
> To achieve this reinitialization by a driver, this driver also
> registers a role switch driver to manage the DRD_CON and get
> a device pointer of usb 3.0 host from "companion" property of OF.
> Then, when the usb role is changed, renesas_usb3_role_switch_set()
> will attach/release the xhci-plat driver to reinitialize the host
> hardware.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
unfortunately doesn't apply:
checking file drivers/usb/gadget/udc/Kconfig
Hunk #1 FAILED at 193.
1 out of 1 hunk FAILED
checking file drivers/usb/gadget/udc/renesas_usb3.c
Hunk #7 succeeded at 2465 (offset -12 lines).
Hunk #8 succeeded at 2624 (offset -11 lines).
Hunk #9 succeeded at 2715 (offset -11 lines).
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-07-26 10:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 6:11 [PATCH v6] usb: gadget: udc: renesas_usb3: Add register of usb role switch Yoshihiro Shimoda
2018-05-31 6:11 ` [v6] " Yoshihiro Shimoda
2018-06-11 14:09 ` [PATCH v6] " Heikki Krogerus
2018-06-11 14:09 ` [v6] " Heikki Krogerus
2018-07-09 3:13 ` [PATCH v6] " Yoshihiro Shimoda
2018-07-09 3:13 ` [v6] " Yoshihiro Shimoda
2018-07-26 10:58 ` Felipe Balbi [this message]
2018-07-26 10:58 ` [PATCH v6] " Felipe Balbi
2018-07-26 10:58 ` [v6] " Felipe Balbi
2018-07-27 1:49 ` [PATCH v6] " Yoshihiro Shimoda
2018-07-27 1:49 ` [v6] " Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2jq1cxd.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.