* [PATCH] usb: dwc3: rename __dwc3_cleanup_done_trbs to __dwc3_cleanup_one_trb
@ 2016-03-30 10:13 changbin.du
2016-03-30 10:57 ` Felipe Balbi
0 siblings, 1 reply; 3+ messages in thread
From: changbin.du @ 2016-03-30 10:13 UTC (permalink / raw)
To: balbi; +Cc: gregkh, linux-usb, linux-kernel, Du, Changbin
From: "Du, Changbin" <changbin.du@intel.com>
Actually, the function only clean one trb. So rename the function.
Signed-off-by: Du, Changbin <changbin.du@intel.com>
---
drivers/usb/dwc3/gadget.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 3ac170f..f84be3d 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -1873,7 +1873,7 @@ static void dwc3_gadget_free_endpoints(struct dwc3 *dwc)
/* -------------------------------------------------------------------------- */
-static int __dwc3_cleanup_done_trbs(struct dwc3 *dwc, struct dwc3_ep *dep,
+static int __dwc3_cleanup_one_trb(struct dwc3 *dwc, struct dwc3_ep *dep,
struct dwc3_request *req, struct dwc3_trb *trb,
const struct dwc3_event_depevt *event, int status)
{
@@ -1975,7 +1975,7 @@ static int dwc3_cleanup_done_reqs(struct dwc3 *dwc, struct dwc3_ep *dep,
slot %= DWC3_TRB_NUM;
trb = &dep->trb_pool[slot];
- ret = __dwc3_cleanup_done_trbs(dwc, dep, req, trb,
+ ret = __dwc3_cleanup_one_trb(dwc, dep, req, trb,
event, status);
if (ret)
break;
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] usb: dwc3: rename __dwc3_cleanup_done_trbs to __dwc3_cleanup_one_trb
2016-03-30 10:13 [PATCH] usb: dwc3: rename __dwc3_cleanup_done_trbs to __dwc3_cleanup_one_trb changbin.du
@ 2016-03-30 10:57 ` Felipe Balbi
2016-03-30 11:04 ` Du, Changbin
0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2016-03-30 10:57 UTC (permalink / raw)
To: changbin.du; +Cc: gregkh, linux-usb, linux-kernel, Du, Changbin
[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]
Hi,
changbin.du@intel.com writes:
> [ text/plain ]
> From: "Du, Changbin" <changbin.du@intel.com>
>
> Actually, the function only clean one trb. So rename the function.
>
> Signed-off-by: Du, Changbin <changbin.du@intel.com>
okay :-)
> ---
> drivers/usb/dwc3/gadget.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 3ac170f..f84be3d 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -1873,7 +1873,7 @@ static void dwc3_gadget_free_endpoints(struct dwc3 *dwc)
>
> /* -------------------------------------------------------------------------- */
>
> -static int __dwc3_cleanup_done_trbs(struct dwc3 *dwc, struct dwc3_ep *dep,
> +static int __dwc3_cleanup_one_trb(struct dwc3 *dwc, struct dwc3_ep *dep,
I would rather just remove that 's' from the end so the function's name
stays as __dwc3_cleanup_done_trb() ;-)
Care to do that ?
thanks
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] usb: dwc3: rename __dwc3_cleanup_done_trbs to __dwc3_cleanup_one_trb
2016-03-30 10:57 ` Felipe Balbi
@ 2016-03-30 11:04 ` Du, Changbin
0 siblings, 0 replies; 3+ messages in thread
From: Du, Changbin @ 2016-03-30 11:04 UTC (permalink / raw)
To: Felipe Balbi
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
> > @@ -1873,7 +1873,7 @@ static void dwc3_gadget_free_endpoints(struct
> dwc3 *dwc)
> >
> > /* -------------------------------------------------------------------------- */
> >
> > -static int __dwc3_cleanup_done_trbs(struct dwc3 *dwc, struct dwc3_ep
> *dep,
> > +static int __dwc3_cleanup_one_trb(struct dwc3 *dwc, struct dwc3_ep
> *dep,
>
> I would rather just remove that 's' from the end so the function's name
> stays as __dwc3_cleanup_done_trb() ;-)
>
> Care to do that ?
>
> thanks
>
> --
> Balbi
IMO, "one_trb" is a little more clear. But both is okay for me. :)
Thanks,
Du, Changbin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-30 11:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-30 10:13 [PATCH] usb: dwc3: rename __dwc3_cleanup_done_trbs to __dwc3_cleanup_one_trb changbin.du
2016-03-30 10:57 ` Felipe Balbi
2016-03-30 11:04 ` Du, Changbin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.