From: arno@natisbad.org (Arnaud Ebalard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv1 6/6] rtc: rtc-isl12057: add alarm support to Intersil ISL12057 RTC driver
Date: Mon, 01 Dec 2014 09:07:41 +0100 [thread overview]
Message-ID: <87r3wjkd2q.fsf@natisbad.org> (raw)
In-Reply-To: <5476ED9F.2070600@kleine-koenig.org> ("Uwe \=\?utf-8\?Q\?Kleine-K\?\= \=\?utf-8\?Q\?\=C3\=B6nig\=22's\?\= message of "Thu, 27 Nov 2014 10:23:43 +0100")
Hi Uwe,
Uwe Kleine-K?nig <uwe@kleine-koenig.org> writes:
> Hello,
>
> finally I managed to test this series on my (unmodified) rn104.
>
> For patch 1: Maybe point out that the issue with the century bit isn't
> that critical, because this bit is not expected to be set before year 2100.
>
> For patch 3: This patch adds a few dev_err calls that get later amended
> in patch 5 to also include an error code. IMHO these should already be
> added in patch 3. Patch 5 should only add it to the already existing
> strings (if applicable).
>
> For patch 4: Maybe
> s/obsolete/for backwards compatibility, don't use in new code/.
>
> Some further comments inline ...
Thanks for the tests. I'll take a look at your comments this evening.
Cheers,
a+
WARNING: multiple messages have this Message-ID (diff)
From: arno@natisbad.org (Arnaud Ebalard)
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Peter Huewe <peter.huewe@infineon.com>,
Linus Walleij <linus.walleij@linaro.org>,
Thierry Reding <treding@nvidia.com>,
Mark Brown <broonie@kernel.org>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Grant Likely <grant.likely@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
Rob Landley <rob@landley.net>,
rtc-linux@googlegroups.com, Jason Cooper <jason@lakedaemon.net>,
Guenter Roeck <linux@roeck-us.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Kumar Gala <galak@codeaurora.org>,
linux-arm-kernel@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCHv1 6/6] rtc: rtc-isl12057: add alarm support to Intersil ISL12057 RTC driver
Date: Mon, 01 Dec 2014 09:07:41 +0100 [thread overview]
Message-ID: <87r3wjkd2q.fsf@natisbad.org> (raw)
In-Reply-To: <5476ED9F.2070600@kleine-koenig.org> ("Uwe \=\?utf-8\?Q\?Kleine-K\?\= \=\?utf-8\?Q\?\=C3\=B6nig\=22's\?\= message of "Thu, 27 Nov 2014 10:23:43 +0100")
Hi Uwe,
Uwe Kleine-König <uwe@kleine-koenig.org> writes:
> Hello,
>
> finally I managed to test this series on my (unmodified) rn104.
>
> For patch 1: Maybe point out that the issue with the century bit isn't
> that critical, because this bit is not expected to be set before year 2100.
>
> For patch 3: This patch adds a few dev_err calls that get later amended
> in patch 5 to also include an error code. IMHO these should already be
> added in patch 3. Patch 5 should only add it to the already existing
> strings (if applicable).
>
> For patch 4: Maybe
> s/obsolete/for backwards compatibility, don't use in new code/.
>
> Some further comments inline ...
Thanks for the tests. I'll take a look at your comments this evening.
Cheers,
a+
next prev parent reply other threads:[~2014-12-01 8:07 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 23:06 [PATCHv1 0/6] rtc: rtc-isl12057: fixes and alarm support Arnaud Ebalard
2014-11-14 23:06 ` Arnaud Ebalard
2014-11-14 23:06 ` [PATCHv1 1/6] rtc: rtc-isl12057: fix masking of register values Arnaud Ebalard
2014-11-14 23:06 ` Arnaud Ebalard
2014-11-14 23:06 ` [PATCHv1 2/6] rtc: rtc-isl12057: add support for century bit Arnaud Ebalard
2014-11-14 23:06 ` Arnaud Ebalard
2014-11-14 23:06 ` [PATCHv1 3/6] rtc: rtc-isl12057: add proper handling of oscillator failure bit Arnaud Ebalard
2014-11-14 23:06 ` Arnaud Ebalard
2014-11-14 23:07 ` [PATCHv1 4/6] rtc: rtc-isl12057: fix isil vs isl naming for intersil Arnaud Ebalard
2014-11-14 23:07 ` Arnaud Ebalard
2014-12-10 21:30 ` [rtc-linux] " Andrew Morton
2014-12-10 21:30 ` Andrew Morton
2014-12-11 19:59 ` Arnaud Ebalard
2014-12-11 19:59 ` Arnaud Ebalard
2014-11-14 23:07 ` [PATCHv1 5/6] rtc: rtc-isl12057: report error code upon failure in dev_err() calls Arnaud Ebalard
2014-11-14 23:07 ` Arnaud Ebalard
2014-11-14 23:07 ` [PATCHv1 6/6] rtc: rtc-isl12057: add alarm support to Intersil ISL12057 RTC driver Arnaud Ebalard
2014-11-14 23:07 ` Arnaud Ebalard
2014-11-27 9:23 ` Uwe Kleine-König
2014-11-27 9:23 ` Uwe Kleine-König
2014-12-01 8:07 ` Arnaud Ebalard [this message]
2014-12-01 8:07 ` Arnaud Ebalard
2014-12-01 20:11 ` Arnaud Ebalard
2014-12-01 20:11 ` Arnaud Ebalard
2014-12-02 8:26 ` Uwe Kleine-König
2014-12-02 8:26 ` Uwe Kleine-König
2014-11-26 18:35 ` [PATCHv1 0/6] rtc: rtc-isl12057: fixes and alarm support Arnaud Ebalard
2014-11-26 18:35 ` Arnaud Ebalard
2014-11-26 18:48 ` Uwe Kleine-König
2014-11-26 18:48 ` Uwe Kleine-König
2014-11-26 19:02 ` Mark Brown
2014-11-26 19:02 ` Mark Brown
2014-11-26 19:28 ` Arnaud Ebalard
2014-11-26 19:28 ` Arnaud Ebalard
2014-11-26 19:53 ` Andrew Morton
2014-11-26 19:53 ` Andrew Morton
2014-11-26 20:10 ` Arnaud Ebalard
2014-11-26 20:10 ` Arnaud Ebalard
2014-11-26 19:46 ` Andrew Morton
2014-11-26 19:46 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3wjkd2q.fsf@natisbad.org \
--to=arno@natisbad.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.