From: Thomas Rast <trast@inf.ethz.ch>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Michael Haggerty <mhagger@alum.mit.edu>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH/RFC] blame: accept multiple -L ranges
Date: Mon, 22 Jul 2013 12:39:40 +0200 [thread overview]
Message-ID: <87r4er2ct4.fsf@linux-k42r.v.cablecom.net> (raw)
In-Reply-To: <CAPig+cTh2t_Rc13U_F-prmm=sjs2OEHX5AX2DbC5DH+Tx_E5jg@mail.gmail.com> (Eric Sunshine's message of "Mon, 22 Jul 2013 04:12:50 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> The proposal currently is only for "-L /RE/,whatever" to behave in a
> relative fashion, beginning the search at the end of the last range
> specified via -L (or line 1 if there is no previous -L).
>
> Would it also make sense to support "-L +N,whatever" as relative to
> the end of the last range specified via -L (or 1 if none).
Sounds reasonable.
I'm still not sure I am super-happy with /RE/ always being relative,
though I see Junio's problem space as something worth solving. How does
it interact with -L:RE? Do you now have to know in what order the
functions appear in the source to correctly specify -L:foo -L:bar or
similarly, -L/foo/,/^}/ -L/bar/,/^}/? What if we supported +/RE/ as the
relative version?
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2013-07-22 10:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 8:45 [PATCH/RFC] blame: accept multiple -L ranges Eric Sunshine
2013-07-07 9:58 ` Junio C Hamano
2013-07-09 15:04 ` Eric Sunshine
2013-07-09 16:39 ` Junio C Hamano
2013-07-09 17:17 ` Eric Sunshine
2013-07-09 17:42 ` Thomas Rast
2013-07-09 18:23 ` Eric Sunshine
2013-07-09 18:55 ` Junio C Hamano
2013-07-09 19:07 ` Eric Sunshine
2013-07-09 19:12 ` Thomas Rast
2013-07-09 19:21 ` Jonathan Nieder
2013-07-09 19:31 ` Junio C Hamano
2013-07-09 19:57 ` Michael Haggerty
2013-07-09 20:25 ` Junio C Hamano
2013-07-22 8:12 ` Eric Sunshine
2013-07-22 10:39 ` Thomas Rast [this message]
2013-07-22 17:23 ` Junio C Hamano
2013-07-22 19:19 ` Thomas Rast
2013-07-22 21:34 ` Junio C Hamano
2013-07-10 9:18 ` Thomas Rast
2013-07-11 16:44 ` Junio C Hamano
2013-07-09 18:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4er2ct4.fsf@linux-k42r.v.cablecom.net \
--to=trast@inf.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.