All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Shubhrajyoti D <shubhrajyoti@ti.com>
Cc: linux-serial@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] serial: omap: fix the reciever line error case
Date: Fri, 21 Sep 2012 14:46:18 -0700	[thread overview]
Message-ID: <87r4pvdp79.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1348238239-18510-1-git-send-email-shubhrajyoti@ti.com> (Shubhrajyoti D.'s message of "Fri, 21 Sep 2012 20:07:19 +0530")

Shubhrajyoti D <shubhrajyoti@ti.com> writes:

> This patch does the following
> - In case of errors if there least one data character in the RX FIFO
> read it otherwise it may stall the receiver.
>
> This is recommended in the interrupt reset method in the table 23-246 of
> the omap4 TRM.
>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> ---
> - Tested on omap4sdp.
> - pm tested hitting off in idle and suspend.
> - v2 changes update the changelogs.
> - Also remove the dummy check as FE , PE , BI and OE are the only
> receiver errors.

Tested-by: Kevin Hilman <khilman@ti.com>

This one also makes the regression I was seeing on 3530/Overo disappear.

Thanks,

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] serial: omap: fix the reciever line error case
Date: Fri, 21 Sep 2012 14:46:18 -0700	[thread overview]
Message-ID: <87r4pvdp79.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1348238239-18510-1-git-send-email-shubhrajyoti@ti.com> (Shubhrajyoti D.'s message of "Fri, 21 Sep 2012 20:07:19 +0530")

Shubhrajyoti D <shubhrajyoti@ti.com> writes:

> This patch does the following
> - In case of errors if there least one data character in the RX FIFO
> read it otherwise it may stall the receiver.
>
> This is recommended in the interrupt reset method in the table 23-246 of
> the omap4 TRM.
>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> ---
> - Tested on omap4sdp.
> - pm tested hitting off in idle and suspend.
> - v2 changes update the changelogs.
> - Also remove the dummy check as FE , PE , BI and OE are the only
> receiver errors.

Tested-by: Kevin Hilman <khilman@ti.com>

This one also makes the regression I was seeing on 3530/Overo disappear.

Thanks,

Kevin

  parent reply	other threads:[~2012-09-21 21:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-21 14:37 [PATCH v2] serial: omap: fix the reciever line error case Shubhrajyoti D
2012-09-21 14:37 ` Shubhrajyoti D
2012-09-21 16:01 ` Felipe Balbi
2012-09-21 16:01   ` Felipe Balbi
2012-09-21 21:46 ` Kevin Hilman [this message]
2012-09-21 21:46   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r4pvdp79.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=shubhrajyoti@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.