All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Pekka Enberg <penberg@kernel.org>
Cc: mst@redhat.com, Christoph Hellwig <hch@infradead.org>,
	virtualization <virtualization@lists.linux-foundation.org>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4 of 5] virtio: avoid modulus operation
Date: Thu, 03 Nov 2011 20:48:17 +1030	[thread overview]
Message-ID: <87r51pse52.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAOJsxLEt6_y7jw0bRsaita4gfb2k+BAQMeRLs9PcHntGVSFvaQ@mail.gmail.com>

On Thu, 3 Nov 2011 09:51:15 +0200, Pekka Enberg <penberg@kernel.org> wrote:
> On Thu, Nov 3, 2011 at 9:42 AM, Rusty Russell <rusty@rustcorp.com.au> wrote:
> > Since we know vq->vring.num is a power of 2, modulus is lazy (it's asserted
> > in vring_new_virtqueue()).
> >
> > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> > ---
> >  drivers/virtio/virtio_ring.c |   10 ++++++----
> >  1 file changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c
> > --- a/arch/x86/lguest/boot.c
> > +++ b/arch/x86/lguest/boot.c
> > @@ -1420,7 +1420,7 @@ __init void lguest_init(void)
> >        add_preferred_console("hvc", 0, NULL);
> >
> >        /* Register our very early console. */
> > -       virtio_cons_early_init(early_put_chars);
> > +//     virtio_cons_early_init(early_put_chars);
> 
> What's this hunk here?

Ugly workaround for console until hvc_console breakage gets reverted.

Left in by mistake :)

Thanks,
Rusty.

  parent reply	other threads:[~2011-11-03 10:42 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <patchbomb.1320306168@localhost6.localdomain6>
2011-11-03  7:42 ` [PATCH 1 of 5] virtio: document functions better Rusty Russell
2011-11-03  7:42   ` Rusty Russell
2011-11-03  7:49   ` Christoph Hellwig
2011-11-03  7:49     ` Christoph Hellwig
2011-11-03  7:42 ` [PATCH 2 of 5] virtio: rename virtqueue_add_buf_gfp to virtqueue_add_buf Rusty Russell
2011-11-03  7:42   ` Rusty Russell
2011-11-03  7:50   ` Christoph Hellwig
2011-11-03  7:50     ` Christoph Hellwig
2011-11-03  7:42 ` [PATCH 3 of 5] virtio: support unlocked queue kick Rusty Russell
2011-11-03  7:42   ` Rusty Russell
2011-11-03  7:52   ` Christoph Hellwig
2011-11-03  7:52   ` Christoph Hellwig
2011-11-04 10:09     ` Stefan Hajnoczi
2011-11-04 10:09       ` Stefan Hajnoczi
2011-11-04 10:36     ` Rusty Russell
2011-11-04 10:36       ` Rusty Russell
2011-11-04 10:36       ` Rusty Russell
2011-11-03  7:42 ` [PATCH 4 of 5] virtio: avoid modulus operation Rusty Russell
2011-11-03  7:42   ` Rusty Russell
2011-11-03  7:51   ` Pekka Enberg
2011-11-03  7:51   ` Pekka Enberg
2011-11-03 10:18     ` Rusty Russell
2011-11-03 10:18     ` Rusty Russell [this message]
2011-11-03  7:42 ` [PATCH 5 of 5] virtio: expose added descriptors immediately Rusty Russell
2011-11-03  7:42   ` Rusty Russell
2011-11-13 21:03   ` Michael S. Tsirkin
2011-11-13 21:03     ` Michael S. Tsirkin
2011-11-14  0:43     ` Rusty Russell
2011-11-14  0:43       ` Rusty Russell
2011-11-14  0:43       ` Rusty Russell
2011-11-14  6:56     ` Michael S. Tsirkin
2011-11-16  0:21       ` Rusty Russell
2011-11-16  7:18         ` Michael S. Tsirkin
2011-11-21  1:48           ` Rusty Russell
2011-11-21 11:57             ` Michael S. Tsirkin
2011-11-22  0:33               ` Rusty Russell
2011-11-22  6:29                 ` Michael S. Tsirkin
2011-11-23  1:19                   ` Rusty Russell
2011-11-23  8:30                     ` Michael S. Tsirkin
2012-07-01  9:20   ` RFD: virtio balloon API use (was Re: [PATCH 5 of 5] virtio: expose added descriptors immediately) Michael S. Tsirkin
2012-07-01  9:20     ` Michael S. Tsirkin
2012-07-02  1:05     ` Rusty Russell
2012-07-02  1:05       ` Rusty Russell
2012-07-02  7:25       ` Michael S. Tsirkin
2012-07-02  7:25         ` Michael S. Tsirkin
2012-07-02 16:08         ` Rafael Aquini
2012-07-02 16:08           ` Rafael Aquini
2012-07-03  0:47           ` Rusty Russell
2012-07-03 16:26             ` Rafael Aquini
2012-07-03 16:26             ` Rafael Aquini
2012-07-04 10:55             ` Michael S. Tsirkin
2012-07-04 10:55               ` Michael S. Tsirkin
2012-07-08 23:39               ` Rusty Russell
2012-07-08 23:39                 ` Rusty Russell
2012-07-04 10:55           ` Michael S. Tsirkin
2012-07-04 10:55             ` Michael S. Tsirkin
2012-07-02  7:33       ` [PATCH RFC] virtio-balloon: fix add/get API use Michael S. Tsirkin
2012-07-02  7:33         ` Michael S. Tsirkin
2012-07-04  3:27         ` Rusty Russell
2012-07-04  3:27           ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r51pse52.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=hch@infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=penberg@kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.