From: Kevin Hilman <khilman@ti.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org, tony@atomide.com,
linux-arm-kernel@lists.infradead.org,
Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH v2 2/5] omap2plus: prm: Trvial build break fix for undefined reference to 'omap2_prm_read_mod_reg'
Date: Fri, 07 Jan 2011 13:14:07 -0800 [thread overview]
Message-ID: <87r5comn6o.fsf@ti.com> (raw)
In-Reply-To: <e194160102cb8b695465c81eea6582fc@mail.gmail.com> (Santosh Shilimkar's message of "Fri, 7 Jan 2011 16:44:05 +0530")
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
[...]
>> I think it would be best to use WARN() on these, rather than
>> WARN_ONCE(). That's because these could be called from different
>> parts of the code base, and the stack backtrace will help someone
>> figure out all the code that needs to be fixed.
>>
>> Once you do that, this patch is
>>
>> Acked-by: Paul Walmsley <paul@pwsan.com>
>>
> With WARN() instead of WARN_ONCE() and Paul's ack, here
> is an updated patch.
Thanks, will queue for .38-rc cycle.
I'll again plead for working on your git-send-email setup. It looks
like your using outlook. The inline patch is wrapped (as outlook almost
always does.) The attached version applied fine, but the strong
preference is for a single inline patch.
Thanks,
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] omap2plus: prm: Trvial build break fix for undefined reference to 'omap2_prm_read_mod_reg'
Date: Fri, 07 Jan 2011 13:14:07 -0800 [thread overview]
Message-ID: <87r5comn6o.fsf@ti.com> (raw)
In-Reply-To: <e194160102cb8b695465c81eea6582fc@mail.gmail.com> (Santosh Shilimkar's message of "Fri, 7 Jan 2011 16:44:05 +0530")
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
[...]
>> I think it would be best to use WARN() on these, rather than
>> WARN_ONCE(). That's because these could be called from different
>> parts of the code base, and the stack backtrace will help someone
>> figure out all the code that needs to be fixed.
>>
>> Once you do that, this patch is
>>
>> Acked-by: Paul Walmsley <paul@pwsan.com>
>>
> With WARN() instead of WARN_ONCE() and Paul's ack, here
> is an updated patch.
Thanks, will queue for .38-rc cycle.
I'll again plead for working on your git-send-email setup. It looks
like your using outlook. The inline patch is wrapped (as outlook almost
always does.) The attached version applied fine, but the strong
preference is for a single inline patch.
Thanks,
Kevin
next prev parent reply other threads:[~2011-01-07 21:14 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 10:57 [PATCH v2 1/5] omap2plus: clockdomain: Trivial fix for build break because of clktrctrl_mask Santosh Shilimkar
2011-01-05 10:57 ` Santosh Shilimkar
2011-01-05 10:57 ` [PATCH v2 2/5] omap2plus: prm: Trvial build break fix for undefined reference to 'omap2_prm_read_mod_reg' Santosh Shilimkar
2011-01-05 10:57 ` Santosh Shilimkar
2011-01-06 14:32 ` Premi, Sanjeev
2011-01-06 14:32 ` Premi, Sanjeev
2011-01-06 14:38 ` Santosh Shilimkar
2011-01-06 14:38 ` Santosh Shilimkar
2011-01-06 18:09 ` Kevin Hilman
2011-01-06 18:09 ` Kevin Hilman
2011-01-06 17:58 ` Paul Walmsley
2011-01-06 17:58 ` Paul Walmsley
2011-01-07 8:43 ` Santosh Shilimkar
2011-01-07 8:43 ` Santosh Shilimkar
2011-01-07 11:14 ` Santosh Shilimkar
2011-01-07 11:14 ` Santosh Shilimkar
2011-01-07 21:14 ` Kevin Hilman [this message]
2011-01-07 21:14 ` Kevin Hilman
2011-01-07 21:22 ` Santosh Shilimkar
2011-01-07 21:22 ` Santosh Shilimkar
2011-01-05 10:57 ` [PATCH v2 3/5] omap2plus: voltage: Trivial warning fix 'no return statement' Santosh Shilimkar
2011-01-05 10:57 ` Santosh Shilimkar
2011-01-05 10:57 ` [PATCH v2 4/5] omap2plus: voltage: Trivial linking fix 'undefined reference' Santosh Shilimkar
2011-01-05 10:57 ` Santosh Shilimkar
2011-01-05 10:57 ` [PATCH v2 5/5] omap2plus: voltage: Trivial linking fix for 'EINVAL' undeclared Santosh Shilimkar
2011-01-05 10:57 ` Santosh Shilimkar
2011-01-05 11:19 ` Russell King - ARM Linux
2011-01-05 11:19 ` Russell King - ARM Linux
2011-01-05 11:36 ` [PATCH v2 5/5] omap2plus: voltage: Trivial linking fix for'EINVAL' undeclared Santosh Shilimkar
2011-01-05 11:36 ` Santosh Shilimkar
2011-01-05 17:43 ` [PATCH v2 1/5] omap2plus: clockdomain: Trivial fix for build break because of clktrctrl_mask Kevin Hilman
2011-01-05 17:43 ` Kevin Hilman
2011-01-06 18:02 ` Paul Walmsley
2011-01-06 18:02 ` Paul Walmsley
2011-01-06 18:28 ` Kevin Hilman
2011-01-06 18:28 ` Kevin Hilman
2011-01-07 8:40 ` Rajendra Nayak
2011-01-07 8:40 ` Rajendra Nayak
2011-01-07 21:05 ` Kevin Hilman
2011-01-07 21:05 ` Kevin Hilman
2011-01-10 19:16 ` Paul Walmsley
2011-01-10 19:16 ` Paul Walmsley
2011-01-11 1:31 ` Kevin Hilman
2011-01-11 1:31 ` Kevin Hilman
2011-01-19 14:20 ` Rajendra Nayak
2011-01-19 14:20 ` Rajendra Nayak
2011-01-06 17:59 ` Paul Walmsley
2011-01-06 17:59 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5comn6o.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.