From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
Naveen Krishna <ch.naveen@samsung.com>,
ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/9] ARM: SAMSUNG: Implements cfg_gpio function for Samsung touchscreen
Date: Tue, 18 May 2010 10:13:31 +0200 [thread overview]
Message-ID: <87r5l96310.fsf@lechat.rtp-net.org> (raw)
In-Reply-To: <1273756032-3098-1-git-send-email-kgene.kim@samsung.com> (Kukjin Kim's message of "Thu\, 13 May 2010 22\:07\:12 +0900")
Kukjin Kim <kgene.kim@samsung.com> writes:
Hi,
[...]
> +
> +/**
> + * s3c24xx_ts_cfg_gpio - configure gpio for s3c2410 systems
> + *
> + * Configure the GPIO for the S3C2410 system, where we have external FETs
> + * connected to the device (later systems such as the S3C2440 integrate
> + * these into the device).
> + */
> +void s3c24xx_ts_cfg_gpio(struct platform_device *dev)
> +{
> + s3c2410_gpio_cfgpin(S3C2410_GPG(12), S3C2410_GPG12_XMON);
> + s3c2410_gpio_cfgpin(S3C2410_GPG(13), S3C2410_GPG13_nXPON);
> + s3c2410_gpio_cfgpin(S3C2410_GPG(14), S3C2410_GPG14_YMON);
> + s3c2410_gpio_cfgpin(S3C2410_GPG(15), S3C2410_GPG15_nYPON);
> +}
hmm... thinking more about this, why don't you put that in the
arch/arm/plat-s3c24xx/devs.c file and then set the cfg_gpio hook in
s3c24xx_ts_set_platdata() for 2410 platforms ?
This should be smaller change and will set it for all s3c2410 platforms
using the touchscreen once for all and "hide" it instead of having to
set it in all machine files using the touchscreen.
Arnaud
WARNING: multiple messages have this Message-ID (diff)
From: arnaud.patard@rtp-net.org (Arnaud Patard (Rtp))
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/9] ARM: SAMSUNG: Implements cfg_gpio function for Samsung touchscreen
Date: Tue, 18 May 2010 10:13:31 +0200 [thread overview]
Message-ID: <87r5l96310.fsf@lechat.rtp-net.org> (raw)
In-Reply-To: <1273756032-3098-1-git-send-email-kgene.kim@samsung.com> (Kukjin Kim's message of "Thu\, 13 May 2010 22\:07\:12 +0900")
Kukjin Kim <kgene.kim@samsung.com> writes:
Hi,
[...]
> +
> +/**
> + * s3c24xx_ts_cfg_gpio - configure gpio for s3c2410 systems
> + *
> + * Configure the GPIO for the S3C2410 system, where we have external FETs
> + * connected to the device (later systems such as the S3C2440 integrate
> + * these into the device).
> + */
> +void s3c24xx_ts_cfg_gpio(struct platform_device *dev)
> +{
> + s3c2410_gpio_cfgpin(S3C2410_GPG(12), S3C2410_GPG12_XMON);
> + s3c2410_gpio_cfgpin(S3C2410_GPG(13), S3C2410_GPG13_nXPON);
> + s3c2410_gpio_cfgpin(S3C2410_GPG(14), S3C2410_GPG14_YMON);
> + s3c2410_gpio_cfgpin(S3C2410_GPG(15), S3C2410_GPG15_nYPON);
> +}
hmm... thinking more about this, why don't you put that in the
arch/arm/plat-s3c24xx/devs.c file and then set the cfg_gpio hook in
s3c24xx_ts_set_platdata() for 2410 platforms ?
This should be smaller change and will set it for all s3c2410 platforms
using the touchscreen once for all and "hide" it instead of having to
set it in all machine files using the touchscreen.
Arnaud
next prev parent reply other threads:[~2010-05-18 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 13:07 [PATCH v2 3/9] ARM: SAMSUNG: Implements cfg_gpio function for Samsung touchscreen Kukjin Kim
2010-05-13 13:07 ` Kukjin Kim
2010-05-18 4:47 ` Ben Dooks
2010-05-18 4:47 ` Ben Dooks
2010-05-18 8:13 ` Arnaud Patard [this message]
2010-05-18 8:13 ` Arnaud Patard (Rtp)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5l96310.fsf@lechat.rtp-net.org \
--to=arnaud.patard@rtp-net.org \
--cc=ben-linux@fluff.org \
--cc=ch.naveen@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.