All of lore.kernel.org
 help / color / mirror / Atom feed
From: Otavio Salvador <otavio@debian.org>
To: openembedded-devel@lists.openembedded.org
Cc: openembedded-devel@openembedded.org
Subject: Re: [RFC] collapse commits in branches to easy review
Date: Wed, 17 Dec 2008 13:25:17 -0200	[thread overview]
Message-ID: <87r6467rj6.fsf@neumann.lab.ossystems.com.br> (raw)
In-Reply-To: <gib10j$i28$1@ger.gmane.org> (Koen Kooi's message of "Wed\, 17 Dec 2008 15\:06\:10 +0100")

Koen Kooi <k.kooi@student.utwente.nl> writes:

> Big branches CANNOT be merged without proper review, but I don't think
> anyone wants to review a few hundred commits :/
>
> So, what do you think about this?

Big branches are usually wrong. Instead of using diffsplit I'd suggest
that people provide the patches as patch series, as done in Linux
kernel, or in topic branches.

If the user/devel has a server where he/she can host the branches, a
set of small topic branches are easier to review and merge. Otherwise
git send-email does the work and could send the patch set to mailing
list.

My 2c.

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio@debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."



  reply	other threads:[~2008-12-17 15:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-17 14:06 [RFC] collapse commits in branches to easy review Koen Kooi
2008-12-17 15:25 ` Otavio Salvador [this message]
2008-12-17 16:11   ` Koen Kooi
2008-12-17 21:19 ` Philip Balister

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r6467rj6.fsf@neumann.lab.ossystems.com.br \
    --to=otavio@debian.org \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=openembedded-devel@openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.