All of lore.kernel.org
 help / color / mirror / Atom feed
From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@openembedded.org
Subject: [RFC] collapse commits in branches to easy review
Date: Wed, 17 Dec 2008 15:06:10 +0100	[thread overview]
Message-ID: <gib10j$i28$1@ger.gmane.org> (raw)

Hi,

I want to propose that when people want to have a branch reviewed for 
merging that has a lot of commits (e.g. more than 30) that the commits 
get 'collapsed' to one diff per recipe/directory or per functional 
change. Collapsing it would be something like:

git diff .dev .merges | diffsplit

and then writing a simple script that cats the remaing files together 
based on directory (e.g. awk -F- {if $1==$2 then cat file to $3.diff)}. 
The diffsplit script can be found at [1].

If you have a functional change (e.g. like PR -> FILEPR) that can of 
course stay in one diff.

If review branches get organized like this we can more easily review 
them and suggest changes.

We will loose some history this way, but branches can get merged faster 
and it would stop huge piles of crap going in, which IMO outweighs the 
downsides.

Big branches CANNOT be merged without proper review, but I don't think 
anyone wants to review a few hundred commits :/

So, what do you think about this?


regards,

Koen


[1] http://www.pathname.com/~quinlan/software/diffsplit/diffsplit




             reply	other threads:[~2008-12-17 14:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-17 14:06 Koen Kooi [this message]
2008-12-17 15:25 ` [RFC] collapse commits in branches to easy review Otavio Salvador
2008-12-17 16:11   ` Koen Kooi
2008-12-17 21:19 ` Philip Balister

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='gib10j$i28$1@ger.gmane.org' \
    --to=k.kooi@student.utwente.nl \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=openembedded-devel@openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.