* Make CONFIG_ARP=m under x86_64
@ 2008-04-18 21:21 Jan Engelhardt
2008-04-18 22:05 ` David Miller
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jan Engelhardt @ 2008-04-18 21:21 UTC (permalink / raw)
To: mingo; +Cc: airlied, Linux Kernel Mailing List
The way it is written, CONFIG_AGP is always y for x86_64 - not so nice
when you want to use nvagp instead which requries agpgart to be
unloadable.
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 6c70fed..1b2ce6c 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -429,12 +429,17 @@ config HPET_EMULATE_RTC
def_bool y
depends on HPET_TIMER && (RTC=y || RTC=m || RTC_DRV_CMOS=m || RTC_DRV_CMOS=y)
+config GART_IOMMU
+ bool
+
+# Hack to make AGP selectable as module
+config GART_IOMMU_SELECTOR
# Mark as embedded because too many people got it wrong.
# The code disables itself when not needed.
-config GART_IOMMU
- bool "GART IOMMU support" if EMBEDDED
- default y
+ tristate "GART IOMMU support" if EMBEDDED
+ default m
select SWIOTLB
+ select GART_IOMMU_BASE
select AGP
depends on X86_64 && PCI
help
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: Make CONFIG_ARP=m under x86_64
2008-04-18 21:21 Make CONFIG_ARP=m under x86_64 Jan Engelhardt
@ 2008-04-18 22:05 ` David Miller
2008-04-19 18:10 ` Arjan van de Ven
2008-04-20 12:30 ` Andi Kleen
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2008-04-18 22:05 UTC (permalink / raw)
To: jengelh; +Cc: mingo, airlied, linux-kernel
Subject typo.
Please fix so people don't think this is a networking patch :-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Make CONFIG_ARP=m under x86_64
2008-04-18 21:21 Make CONFIG_ARP=m under x86_64 Jan Engelhardt
2008-04-18 22:05 ` David Miller
@ 2008-04-19 18:10 ` Arjan van de Ven
2008-04-20 12:30 ` Andi Kleen
2 siblings, 0 replies; 4+ messages in thread
From: Arjan van de Ven @ 2008-04-19 18:10 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: mingo, airlied, Linux Kernel Mailing List
On Fri, 18 Apr 2008 23:21:44 +0200 (CEST)
Jan Engelhardt <jengelh@computergmbh.de> wrote:
>
> The way it is written, CONFIG_AGP is always y for x86_64 - not so
> nice when you want to use nvagp instead which requries agpgart to be
> unloadable.
where's the source code for nvagp? what does it do that normal agp does not do?
Also.. running without agp on x86-64 (heck on x86) tends to be rather unpleasant wrt resource allocations..
So I don't think this patch is a good idea at all..
--
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Make CONFIG_ARP=m under x86_64
2008-04-18 21:21 Make CONFIG_ARP=m under x86_64 Jan Engelhardt
2008-04-18 22:05 ` David Miller
2008-04-19 18:10 ` Arjan van de Ven
@ 2008-04-20 12:30 ` Andi Kleen
2 siblings, 0 replies; 4+ messages in thread
From: Andi Kleen @ 2008-04-20 12:30 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: mingo, airlied, Linux Kernel Mailing List
Jan Engelhardt <jengelh@computergmbh.de> writes:
> when you want to use nvagp instead which requries agpgart to be
> unloadable.
The patch is wrong. GART_IOMMU cannot be modular. It has to be
initialized early.
-Andi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-04-20 12:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-18 21:21 Make CONFIG_ARP=m under x86_64 Jan Engelhardt
2008-04-18 22:05 ` David Miller
2008-04-19 18:10 ` Arjan van de Ven
2008-04-20 12:30 ` Andi Kleen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.