From: Marco Gerards <metgerards@student.han.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [patch] printf long format
Date: Wed, 22 Jun 2005 18:24:51 +0200 [thread overview]
Message-ID: <87r7eucqb0.fsf@student.han.nl> (raw)
In-Reply-To: <200506221730.42997.okuji@enbug.org> (Yoshinori K. Okuji's message of "Wed, 22 Jun 2005 17:30:42 +0200")
"Yoshinori K. Okuji" <okuji@enbug.org> writes:
> On Wednesday 22 June 2005 16:33, Hollis Blanchard wrote:
>> You have made this comment a few times now. Please understand: I do
>> watch out for this stuff, apparently more carefully than other
>> committers. I am removing whitespace from an otherwise blank line.
>>
>> I am not saying I will never accidentally check in errant whitespace,
>> but you can see that this is a correction, not an accident.
>
> Why does Marco complain about this? Because of the readability of a patch? In
> this case, the option --ignore-space-change to diff would help you...
Readability. Hollis prefers no whitespace on a line. I do not care
about these spaces, but it is too much noise to either add or remove
it.
With --ignore-space-change you sometimes miss changes that were made
on purpose.
--
Marco
next prev parent reply other threads:[~2005-06-22 16:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-21 23:14 [patch] printf long format Hollis Blanchard
2005-06-22 11:05 ` Marco Gerards
2005-06-22 14:33 ` Hollis Blanchard
2005-06-22 15:30 ` Yoshinori K. Okuji
2005-06-22 16:24 ` Marco Gerards [this message]
2005-06-22 17:14 ` Yoshinori K. Okuji
2005-06-22 18:09 ` Marco Gerards
2005-06-22 19:07 ` Yoshinori K. Okuji
2005-06-22 20:14 ` Marco Gerards
2005-06-22 20:53 ` Yoshinori K. Okuji
-- strict thread matches above, loose matches on Subject: below --
2005-06-21 4:00 Hollis Blanchard
2005-06-21 16:27 ` Marco Gerards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r7eucqb0.fsf@student.han.nl \
--to=metgerards@student.han.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.