Re: [patch] configfile

[Marco Gerards <metgerards@student.han.nl>]

Hollis Blanchard <hollis@penguinppc.org> writes:

> 2005-02-13  Hollis Blanchard  <hollis@penguinppc.org>
>
> 	* conf/i386-pc.rmk (pkgdata_MODULES): Add configfile.mod.
> 	* conf/powerpc-ieee1275.rmk (pkgdata_MODULES): Likewise.
> 	* commands/configfile.mod: New file.

Could you please add it to grub-emu as well?

> While working on setting prefix correctly, I found it useful to have the
> `configfile' command like GRUB Legacy.

Great! :)

> --- /dev/null	2004-12-18 12:15:49.000000000 -0600
> +++ commands/configfile.c	2005-02-13 09:11:41.166390400 -0600

[...]

> +static grub_err_t
> +grub_cmd_configfile (struct grub_arg_list *state __attribute__ ((unused)),
> +	      int argc, char **args)
> +
> +{
> +  if (argc != 1)
> +    return grub_error (GRUB_ERR_BAD_ARGUMENT, "file name required");
> +
> +  grub_cls ();
> +  grub_normal_execute (args[0], 1);

When this is called from normal mode, by running a command this means
that another normal mode will be started again.  If you run this
command a few times, you would see a lot normal modes running when
examining the stack, right?

This is the main reason I have not implemented this command yet.  To
me it would seem better to update the data in the already running
normal mode.

Please correct me if I am wrong.

Thanks,
Marco