All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mihai Sain <mihai.sain@microchip.com>
Cc: <richard@nod.at>,  <vigneshr@ti.com>,
	 <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: mtdpart: convert printk to pr_* and define pr_fmt
Date: Tue, 17 Nov 2026 14:20:33 +0100	[thread overview]
Message-ID: <87se0zlhlq.fsf@bootlin.com> (raw)
In-Reply-To: <20261013082352.5051-2-mihai.sain@microchip.com> (Mihai Sain's message of "Tue, 13 Oct 2026 11:23:43 +0300")

Hi Mihai,

On 13/10/2026 at 11:23:43 +03, Mihai Sain <mihai.sain@microchip.com> wrote:

> Define pr_fmt to prefix all pr_* print statements in this file with
> "mtd: ". Convert legacy printk() invocations to their modern pr_err(),
> pr_warn(), and pr_notice() equivalents so that the prefix applies
> consistently across all logs.

Your change breaks alignments with parenthesis. Please run
checkpatch.pl, you'll see them.

Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mihai Sain <mihai.sain@microchip.com>
Cc: <richard@nod.at>,  <vigneshr@ti.com>,
	 <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: mtdpart: convert printk to pr_* and define pr_fmt
Date: Tue, 17 Nov 2026 14:20:33 +0100	[thread overview]
Message-ID: <87se0zlhlq.fsf@bootlin.com> (raw)
In-Reply-To: <20261013082352.5051-2-mihai.sain@microchip.com> (Mihai Sain's message of "Tue, 13 Oct 2026 11:23:43 +0300")

Hi Mihai,

On 13/10/2026 at 11:23:43 +03, Mihai Sain <mihai.sain@microchip.com> wrote:

> Define pr_fmt to prefix all pr_* print statements in this file with
> "mtd: ". Convert legacy printk() invocations to their modern pr_err(),
> pr_warn(), and pr_notice() equivalents so that the prefix applies
> consistently across all logs.

Your change breaks alignments with parenthesis. Please run
checkpatch.pl, you'll see them.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2026-11-17 13:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13  8:23 [PATCH] mtd: mtdpart: convert printk to pr_* and define pr_fmt Mihai Sain
2026-10-13  8:23 ` Mihai Sain
2026-11-17 13:20 ` Miquel Raynal [this message]
2026-11-17 13:20   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87se0zlhlq.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mihai.sain@microchip.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.