All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] qapi: fixes to trace event cleanups
@ 2026-11-12 16:48 Daniel P. Berrangé
  2026-11-12 16:48 ` [PATCH 1/2] docs: document 'unavailable' state is no longer output Daniel P. Berrangé
  2026-11-12 16:48 ` [PATCH 2/2] qapi: correctly mark 'ignore-unavailable' deprecated Daniel P. Berrangé
  0 siblings, 2 replies; 7+ messages in thread
From: Daniel P. Berrangé @ 2026-11-12 16:48 UTC (permalink / raw)
  To: qemu-devel
  Cc: devel, Pierrick Bouvier, Eric Blake, Markus Armbruster,
	Stefan Hajnoczi, Daniel P. Berrangé



Daniel P. Berrangé (2):
  docs: document 'unavailable' state is no longer output
  qapi: correctly mark 'ignore-unavailable' deprecated

 docs/about/deprecated.rst       |  8 ++++++++
 docs/about/removed-features.rst |  8 ++++++++
 qapi/trace.json                 | 10 ++++++++--
 3 files changed, 24 insertions(+), 2 deletions(-)

-- 
2.56.1



^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] docs: document 'unavailable' state is no longer output
  2026-11-12 16:48 [PATCH 0/2] qapi: fixes to trace event cleanups Daniel P. Berrangé
@ 2026-11-12 16:48 ` Daniel P. Berrangé
  2026-11-13  7:31   ` Markus Armbruster
  2026-11-12 16:48 ` [PATCH 2/2] qapi: correctly mark 'ignore-unavailable' deprecated Daniel P. Berrangé
  1 sibling, 1 reply; 7+ messages in thread
From: Daniel P. Berrangé @ 2026-11-12 16:48 UTC (permalink / raw)
  To: qemu-devel
  Cc: devel, Pierrick Bouvier, Eric Blake, Markus Armbruster,
	Stefan Hajnoczi, Daniel P. Berrangé, Marc-André Lureau

The concept of unavailable trace events no longer exists so
this enum entry was obsolete.

Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 docs/about/removed-features.rst | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst
index 225841bd9bb..3a05891db2b 100644
--- a/docs/about/removed-features.rst
+++ b/docs/about/removed-features.rst
@@ -802,6 +802,14 @@ The ability to instrument QEMU helper functions with vCPU-aware trace
 points was removed in 7.0.
 
 
+``unavailable`` state no longer reported for trace events (removed in 11.2)
+'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Trace events are now unconditionally built-in to all QEMU builds,
+so the concept of an 'unavailable' trace event no longer exists.
+The ``TraceEventState`` value ``unavailable`` can thus never
+be reported and has been removed from the schema.
+
 Human Monitor Protocol (HMP) commands
 -------------------------------------
 
-- 
2.56.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/2] qapi: correctly mark 'ignore-unavailable' deprecated
  2026-11-12 16:48 [PATCH 0/2] qapi: fixes to trace event cleanups Daniel P. Berrangé
  2026-11-12 16:48 ` [PATCH 1/2] docs: document 'unavailable' state is no longer output Daniel P. Berrangé
@ 2026-11-12 16:48 ` Daniel P. Berrangé
  2026-11-13  7:34   ` Markus Armbruster
  2026-11-13  7:36   ` Marc-André Lureau
  1 sibling, 2 replies; 7+ messages in thread
From: Daniel P. Berrangé @ 2026-11-12 16:48 UTC (permalink / raw)
  To: qemu-devel
  Cc: devel, Pierrick Bouvier, Eric Blake, Markus Armbruster,
	Stefan Hajnoczi, Daniel P. Berrangé, Marc-André Lureau

Follow the proper QAPI syntax for deprecations and mention it
in the documentation.

Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 docs/about/deprecated.rst |  8 ++++++++
 qapi/trace.json           | 10 ++++++++--
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 0891bbc44de..a39feb23f5b 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -182,6 +182,14 @@ execution.  This special treatment of ``"no"`` is deprecated.  Use an
 empty string instead.  In a future version, ``"no"`` will be treated as
 a plain file name.
 
+``ignore-unavailable`` in ``trace-event-set-state`` (since 11.2)
+''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Trace events are now unconditionally built-in to all QEMU builds,
+so the concept of an 'unavailable' trace event no longer exists.
+The ``ignore-unavailable`` parameter in ``trace-event-set-state``
+thus has no effect and should no longer be used.
+
 Human Machine Protocol (HMP) commands
 -------------------------------------
 
diff --git a/qapi/trace.json b/qapi/trace.json
index 8533e378977..5792a436115 100644
--- a/qapi/trace.json
+++ b/qapi/trace.json
@@ -67,10 +67,14 @@
 # @enable: Whether to enable tracing.
 #
 # @ignore-unavailable: Do not match unavailable events with @name.
-#      Deprecated: since 11.2
 #
 # Since: 2.2
 #
+# Features:
+#
+# @deprecated: @ignore-unavailable no longer has any effect
+#    (since 11.2)
+#
 # .. qmp-example::
 #
 #     -> { "execute": "trace-event-set-state",
@@ -78,4 +82,6 @@
 #     <- { "return": {} }
 ##
 { 'command': 'trace-event-set-state',
-  'data': {'name': 'str', 'enable': 'bool', '*ignore-unavailable': 'bool' } }
+  'data': {'name': 'str', 'enable': 'bool',
+           '*ignore-unavailable': { 'type': 'bool',
+                                    'features': ['deprecated'] } } }
-- 
2.56.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] docs: document 'unavailable' state is no longer output
  2026-11-12 16:48 ` [PATCH 1/2] docs: document 'unavailable' state is no longer output Daniel P. Berrangé
@ 2026-11-13  7:31   ` Markus Armbruster
  2026-11-13  7:35     ` Markus Armbruster
  0 siblings, 1 reply; 7+ messages in thread
From: Markus Armbruster @ 2026-11-13  7:31 UTC (permalink / raw)
  To: Daniel P. Berrangé
  Cc: qemu-devel, devel, Pierrick Bouvier, Eric Blake, Stefan Hajnoczi,
	Marc-André Lureau

Daniel P. Berrangé <berrange@redhat.com> writes:

> The concept of unavailable trace events no longer exists so
> this enum entry was obsolete.
>

Suggest

  Fixes: 38171f59ccbe ("qapi/qom: Make @qapi-type mandatory in output of qom-list etc.") 

> Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] qapi: correctly mark 'ignore-unavailable' deprecated
  2026-11-12 16:48 ` [PATCH 2/2] qapi: correctly mark 'ignore-unavailable' deprecated Daniel P. Berrangé
@ 2026-11-13  7:34   ` Markus Armbruster
  2026-11-13  7:36   ` Marc-André Lureau
  1 sibling, 0 replies; 7+ messages in thread
From: Markus Armbruster @ 2026-11-13  7:34 UTC (permalink / raw)
  To: Daniel P. Berrangé
  Cc: qemu-devel, devel, Pierrick Bouvier, Eric Blake,
	Markus Armbruster, Stefan Hajnoczi, Marc-André Lureau

Daniel P. Berrangé <berrange@redhat.com> writes:

> Follow the proper QAPI syntax for deprecations and mention it
> in the documentation.
>

  Fixes: f5c576734881 ("trace: stop tracking static disabled state")

> Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] docs: document 'unavailable' state is no longer output
  2026-11-13  7:31   ` Markus Armbruster
@ 2026-11-13  7:35     ` Markus Armbruster
  0 siblings, 0 replies; 7+ messages in thread
From: Markus Armbruster @ 2026-11-13  7:35 UTC (permalink / raw)
  To: Daniel P. Berrangé
  Cc: qemu-devel, devel, Pierrick Bouvier, Eric Blake, Stefan Hajnoczi,
	Marc-André Lureau

Markus Armbruster <armbru@redhat.com> writes:

> Daniel P. Berrangé <berrange@redhat.com> writes:
>
>> The concept of unavailable trace events no longer exists so
>> this enum entry was obsolete.
>>
>
> Suggest
>
>   Fixes: 38171f59ccbe ("qapi/qom: Make @qapi-type mandatory in output of qom-list etc.") 

Pasto!  Instead

    Fixes: f5c576734881 ("trace: stop tracking static disabled state")

>> Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> Reported-by: Markus Armbruster <armbru@redhat.com>
>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] qapi: correctly mark 'ignore-unavailable' deprecated
  2026-11-12 16:48 ` [PATCH 2/2] qapi: correctly mark 'ignore-unavailable' deprecated Daniel P. Berrangé
  2026-11-13  7:34   ` Markus Armbruster
@ 2026-11-13  7:36   ` Marc-André Lureau
  1 sibling, 0 replies; 7+ messages in thread
From: Marc-André Lureau @ 2026-11-13  7:36 UTC (permalink / raw)
  To: Daniel P. Berrangé
  Cc: qemu-devel, devel, Pierrick Bouvier, Eric Blake,
	Markus Armbruster, Stefan Hajnoczi

On Thu, Nov 12, 2026 at 8:49 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> Follow the proper QAPI syntax for deprecations and mention it
> in the documentation.
>
> Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  docs/about/deprecated.rst |  8 ++++++++
>  qapi/trace.json           | 10 ++++++++--
>  2 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 0891bbc44de..a39feb23f5b 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -182,6 +182,14 @@ execution.  This special treatment of ``"no"`` is deprecated.  Use an
>  empty string instead.  In a future version, ``"no"`` will be treated as
>  a plain file name.
>
> +``ignore-unavailable`` in ``trace-event-set-state`` (since 11.2)
> +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> +
> +Trace events are now unconditionally built-in to all QEMU builds,
> +so the concept of an 'unavailable' trace event no longer exists.
> +The ``ignore-unavailable`` parameter in ``trace-event-set-state``
> +thus has no effect and should no longer be used.
> +
>  Human Machine Protocol (HMP) commands
>  -------------------------------------
>
> diff --git a/qapi/trace.json b/qapi/trace.json
> index 8533e378977..5792a436115 100644
> --- a/qapi/trace.json
> +++ b/qapi/trace.json
> @@ -67,10 +67,14 @@
>  # @enable: Whether to enable tracing.
>  #
>  # @ignore-unavailable: Do not match unavailable events with @name.
> -#      Deprecated: since 11.2
>  #
>  # Since: 2.2
>  #
> +# Features:
> +#
> +# @deprecated: @ignore-unavailable no longer has any effect
> +#    (since 11.2)
> +#
>  # .. qmp-example::
>  #
>  #     -> { "execute": "trace-event-set-state",
> @@ -78,4 +82,6 @@
>  #     <- { "return": {} }
>  ##
>  { 'command': 'trace-event-set-state',
> -  'data': {'name': 'str', 'enable': 'bool', '*ignore-unavailable': 'bool' } }
> +  'data': {'name': 'str', 'enable': 'bool',
> +           '*ignore-unavailable': { 'type': 'bool',
> +                                    'features': ['deprecated'] } } }
> --
> 2.56.1
>



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-11-13  7:36 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-12 16:48 [PATCH 0/2] qapi: fixes to trace event cleanups Daniel P. Berrangé
2026-11-12 16:48 ` [PATCH 1/2] docs: document 'unavailable' state is no longer output Daniel P. Berrangé
2026-11-13  7:31   ` Markus Armbruster
2026-11-13  7:35     ` Markus Armbruster
2026-11-12 16:48 ` [PATCH 2/2] qapi: correctly mark 'ignore-unavailable' deprecated Daniel P. Berrangé
2026-11-13  7:34   ` Markus Armbruster
2026-11-13  7:36   ` Marc-André Lureau

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.