All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Jay Xu <jayxu1990@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	 avnerkhan@utexas.edu, rdlee.upstream@gmail.com,
	 kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] mtd: core: Add nand_id sysfs attribute for NAND devices
Date: Thu, 23 Oct 2025 08:54:39 +0200	[thread overview]
Message-ID: <87sefaqf9s.fsf@bootlin.com> (raw)
In-Reply-To: <CABcGJDxxGSDVc9TPcTMR_7abreBchHEKHsqtfZVQ5m+0nFhJ1A@mail.gmail.com> (Jay Xu's message of "Wed, 22 Oct 2025 11:53:41 -0500")

Hi Jay,

On 22/10/2025 at 11:53:41 -05, Jay Xu <jayxu1990@gmail.com> wrote:

> Hi Miquèl:
> Thank you for the feedback and suggestions!
>
> You're right that the current implementation is raw NAND specific. I can look into extending this to support other NAND
> types by moving the functionality to the NAND core 
> layer and ensure the ID is populated at probe time.
>
> Let me know if you have any other suggestions/questions,

Not at the moment, I'd like to gather feedback from other MTD folks
before we go forward. Sysfs is part of the stable API, we must be
careful.

>  > Reported-by: kernel test robot <lkp@intel.com>
>  > Closes:
>  > https://lore.kernel.org/oe-kbuild-all/202510120356.STGKDkA5-lkp@intel.com/

Just as an FYI, these do not make any sense in a contribution like
yours. Include these tags if you are fixing something that is already in
the tree. This is a new submission and it is not a fix so "reported-by"
shall not be used.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Jay Xu <jayxu1990@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	 avnerkhan@utexas.edu, rdlee.upstream@gmail.com,
	 kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] mtd: core: Add nand_id sysfs attribute for NAND devices
Date: Thu, 23 Oct 2025 08:54:39 +0200	[thread overview]
Message-ID: <87sefaqf9s.fsf@bootlin.com> (raw)
In-Reply-To: <CABcGJDxxGSDVc9TPcTMR_7abreBchHEKHsqtfZVQ5m+0nFhJ1A@mail.gmail.com> (Jay Xu's message of "Wed, 22 Oct 2025 11:53:41 -0500")

Hi Jay,

On 22/10/2025 at 11:53:41 -05, Jay Xu <jayxu1990@gmail.com> wrote:

> Hi Miquèl:
> Thank you for the feedback and suggestions!
>
> You're right that the current implementation is raw NAND specific. I can look into extending this to support other NAND
> types by moving the functionality to the NAND core 
> layer and ensure the ID is populated at probe time.
>
> Let me know if you have any other suggestions/questions,

Not at the moment, I'd like to gather feedback from other MTD folks
before we go forward. Sysfs is part of the stable API, we must be
careful.

>  > Reported-by: kernel test robot <lkp@intel.com>
>  > Closes:
>  > https://lore.kernel.org/oe-kbuild-all/202510120356.STGKDkA5-lkp@intel.com/

Just as an FYI, these do not make any sense in a contribution like
yours. Include these tags if you are fixing something that is already in
the tree. This is a new submission and it is not a fix so "reported-by"
shall not be used.

Thanks,
Miquèl

  parent reply	other threads:[~2025-10-23  6:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-07 22:40 [PATCH] mtd: core: Add nand_id sysfs attribute for NAND devices jayxu1990
2025-10-07 22:40 ` jayxu1990
2025-10-11 20:03 ` kernel test robot
2025-10-11 20:03   ` kernel test robot
2025-10-14 19:24 ` [PATCH v2] " jayxu1990
2025-10-14 19:24   ` jayxu1990
2025-10-22 14:19   ` Miquel Raynal
2025-10-22 14:19     ` Miquel Raynal
     [not found]     ` <CABcGJDxxGSDVc9TPcTMR_7abreBchHEKHsqtfZVQ5m+0nFhJ1A@mail.gmail.com>
2025-10-23  6:54       ` Miquel Raynal [this message]
2025-10-23  6:54         ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sefaqf9s.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=avnerkhan@utexas.edu \
    --cc=jayxu1990@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=rdlee.upstream@gmail.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.