* [PATCH 1/2] drm/i915/dp: add g4x_dp_compute_config()
@ 2024-12-11 12:54 Jani Nikula
2024-12-11 12:54 ` [PATCH 2/2] drm/i915/dp: move g4x_dp_set_clock() call to g4x_dp_compute_config() Jani Nikula
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jani Nikula @ 2024-12-11 12:54 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, Ville Syrjala
Add g4x_dp_compute_config() instead of using intel_dp_compute_config()
directly, in order to slightly reduce the clutter in the latter wrt
->has_pch_encoder.
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/g4x_dp.c | 14 +++++++++++++-
drivers/gpu/drm/i915/display/intel_dp.c | 3 ---
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/g4x_dp.c b/drivers/gpu/drm/i915/display/g4x_dp.c
index 4fbec065d53e..9ac894a7411f 100644
--- a/drivers/gpu/drm/i915/display/g4x_dp.c
+++ b/drivers/gpu/drm/i915/display/g4x_dp.c
@@ -1223,6 +1223,18 @@ static bool ilk_digital_port_connected(struct intel_encoder *encoder)
return intel_de_read(display, DEISR) & bit;
}
+static int g4x_dp_compute_config(struct intel_encoder *encoder,
+ struct intel_crtc_state *crtc_state,
+ struct drm_connector_state *conn_state)
+{
+ struct drm_i915_private *i915 = to_i915(encoder->base.dev);
+
+ if (HAS_PCH_SPLIT(i915) && encoder->port != PORT_A)
+ crtc_state->has_pch_encoder = true;
+
+ return intel_dp_compute_config(encoder, crtc_state, conn_state);
+}
+
static void g4x_dp_suspend_complete(struct intel_encoder *encoder)
{
/*
@@ -1307,7 +1319,7 @@ bool g4x_dp_init(struct drm_i915_private *dev_priv,
intel_encoder_link_check_init(intel_encoder, intel_dp_link_check);
intel_encoder->hotplug = intel_dp_hotplug;
- intel_encoder->compute_config = intel_dp_compute_config;
+ intel_encoder->compute_config = g4x_dp_compute_config;
intel_encoder->get_hw_state = intel_dp_get_hw_state;
intel_encoder->get_config = intel_dp_get_config;
intel_encoder->sync_state = intel_dp_sync_state;
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index fbe6b77d642e..adc51567ec17 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -3090,9 +3090,6 @@ intel_dp_compute_config(struct intel_encoder *encoder,
struct intel_connector *connector = intel_dp->attached_connector;
int ret = 0, link_bpp_x16;
- if (HAS_PCH_SPLIT(dev_priv) && !HAS_DDI(dev_priv) && encoder->port != PORT_A)
- pipe_config->has_pch_encoder = true;
-
fixed_mode = intel_panel_fixed_mode(connector, adjusted_mode);
if (intel_dp_is_edp(intel_dp) && fixed_mode) {
ret = intel_panel_compute_config(connector, adjusted_mode);
--
2.39.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] drm/i915/dp: move g4x_dp_set_clock() call to g4x_dp_compute_config()
2024-12-11 12:54 [PATCH 1/2] drm/i915/dp: add g4x_dp_compute_config() Jani Nikula
@ 2024-12-11 12:54 ` Jani Nikula
2024-12-11 13:42 ` Ville Syrjälä
2024-12-11 13:55 ` ✓ i915.CI.BAT: success for series starting with [1/2] drm/i915/dp: add g4x_dp_compute_config() Patchwork
2024-12-11 15:45 ` ✗ i915.CI.Full: failure " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2024-12-11 12:54 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, Ville Syrjala
It does not look like anything in intel_dp_compute_config() after the
g4x_dp_set_clock() call depends on the changes it makes, namely setting
dpll and clock_set in crtc_state. Move the call one level higher to
g4x_dp_compute_config() to reduce the clutter in
intel_dp_compute_config().
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/g4x_dp.c | 13 ++++++++++---
drivers/gpu/drm/i915/display/g4x_dp.h | 6 ------
drivers/gpu/drm/i915/display/intel_dp.c | 3 ---
3 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/g4x_dp.c b/drivers/gpu/drm/i915/display/g4x_dp.c
index 9ac894a7411f..e06405a3b82d 100644
--- a/drivers/gpu/drm/i915/display/g4x_dp.c
+++ b/drivers/gpu/drm/i915/display/g4x_dp.c
@@ -55,8 +55,8 @@ const struct dpll *vlv_get_dpll(struct drm_i915_private *i915)
return IS_CHERRYVIEW(i915) ? &chv_dpll[0] : &vlv_dpll[0];
}
-void g4x_dp_set_clock(struct intel_encoder *encoder,
- struct intel_crtc_state *pipe_config)
+static void g4x_dp_set_clock(struct intel_encoder *encoder,
+ struct intel_crtc_state *pipe_config)
{
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
const struct dpll *divisor = NULL;
@@ -1228,11 +1228,18 @@ static int g4x_dp_compute_config(struct intel_encoder *encoder,
struct drm_connector_state *conn_state)
{
struct drm_i915_private *i915 = to_i915(encoder->base.dev);
+ int ret;
if (HAS_PCH_SPLIT(i915) && encoder->port != PORT_A)
crtc_state->has_pch_encoder = true;
- return intel_dp_compute_config(encoder, crtc_state, conn_state);
+ ret = intel_dp_compute_config(encoder, crtc_state, conn_state);
+ if (ret)
+ return ret;
+
+ g4x_dp_set_clock(encoder, crtc_state);
+
+ return 0;
}
static void g4x_dp_suspend_complete(struct intel_encoder *encoder)
diff --git a/drivers/gpu/drm/i915/display/g4x_dp.h b/drivers/gpu/drm/i915/display/g4x_dp.h
index c75e64ae79b7..839a251dc069 100644
--- a/drivers/gpu/drm/i915/display/g4x_dp.h
+++ b/drivers/gpu/drm/i915/display/g4x_dp.h
@@ -19,8 +19,6 @@ struct intel_encoder;
#ifdef I915
const struct dpll *vlv_get_dpll(struct drm_i915_private *i915);
-void g4x_dp_set_clock(struct intel_encoder *encoder,
- struct intel_crtc_state *pipe_config);
bool g4x_dp_port_enabled(struct drm_i915_private *dev_priv,
i915_reg_t dp_reg, enum port port,
enum pipe *pipe);
@@ -31,10 +29,6 @@ static inline const struct dpll *vlv_get_dpll(struct drm_i915_private *i915)
{
return NULL;
}
-static inline void g4x_dp_set_clock(struct intel_encoder *encoder,
- struct intel_crtc_state *pipe_config)
-{
-}
static inline bool g4x_dp_port_enabled(struct drm_i915_private *dev_priv,
i915_reg_t dp_reg, int port,
enum pipe *pipe)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index adc51567ec17..f8100c4f4d20 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -3172,9 +3172,6 @@ intel_dp_compute_config(struct intel_encoder *encoder,
if (pipe_config->splitter.enable)
pipe_config->dp_m_n.data_m *= pipe_config->splitter.link_count;
- if (!HAS_DDI(dev_priv))
- g4x_dp_set_clock(encoder, pipe_config);
-
intel_vrr_compute_config(pipe_config, conn_state);
intel_dp_compute_as_sdp(intel_dp, pipe_config);
intel_psr_compute_config(intel_dp, pipe_config, conn_state);
--
2.39.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] drm/i915/dp: move g4x_dp_set_clock() call to g4x_dp_compute_config()
2024-12-11 12:54 ` [PATCH 2/2] drm/i915/dp: move g4x_dp_set_clock() call to g4x_dp_compute_config() Jani Nikula
@ 2024-12-11 13:42 ` Ville Syrjälä
2024-12-11 17:17 ` Jani Nikula
0 siblings, 1 reply; 6+ messages in thread
From: Ville Syrjälä @ 2024-12-11 13:42 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, Dec 11, 2024 at 02:54:31PM +0200, Jani Nikula wrote:
> It does not look like anything in intel_dp_compute_config() after the
> g4x_dp_set_clock() call depends on the changes it makes, namely setting
> dpll and clock_set in crtc_state.
Hmm, yeah I was a bit worried about DRRS and such, but as long
as don't mangle the clock itself/etc. then this looks fine.
Series is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Move the call one level higher to
> g4x_dp_compute_config() to reduce the clutter in
> intel_dp_compute_config().
>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/g4x_dp.c | 13 ++++++++++---
> drivers/gpu/drm/i915/display/g4x_dp.h | 6 ------
> drivers/gpu/drm/i915/display/intel_dp.c | 3 ---
> 3 files changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/g4x_dp.c b/drivers/gpu/drm/i915/display/g4x_dp.c
> index 9ac894a7411f..e06405a3b82d 100644
> --- a/drivers/gpu/drm/i915/display/g4x_dp.c
> +++ b/drivers/gpu/drm/i915/display/g4x_dp.c
> @@ -55,8 +55,8 @@ const struct dpll *vlv_get_dpll(struct drm_i915_private *i915)
> return IS_CHERRYVIEW(i915) ? &chv_dpll[0] : &vlv_dpll[0];
> }
>
> -void g4x_dp_set_clock(struct intel_encoder *encoder,
> - struct intel_crtc_state *pipe_config)
> +static void g4x_dp_set_clock(struct intel_encoder *encoder,
> + struct intel_crtc_state *pipe_config)
> {
> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> const struct dpll *divisor = NULL;
> @@ -1228,11 +1228,18 @@ static int g4x_dp_compute_config(struct intel_encoder *encoder,
> struct drm_connector_state *conn_state)
> {
> struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> + int ret;
>
> if (HAS_PCH_SPLIT(i915) && encoder->port != PORT_A)
> crtc_state->has_pch_encoder = true;
>
> - return intel_dp_compute_config(encoder, crtc_state, conn_state);
> + ret = intel_dp_compute_config(encoder, crtc_state, conn_state);
> + if (ret)
> + return ret;
> +
> + g4x_dp_set_clock(encoder, crtc_state);
> +
> + return 0;
> }
>
> static void g4x_dp_suspend_complete(struct intel_encoder *encoder)
> diff --git a/drivers/gpu/drm/i915/display/g4x_dp.h b/drivers/gpu/drm/i915/display/g4x_dp.h
> index c75e64ae79b7..839a251dc069 100644
> --- a/drivers/gpu/drm/i915/display/g4x_dp.h
> +++ b/drivers/gpu/drm/i915/display/g4x_dp.h
> @@ -19,8 +19,6 @@ struct intel_encoder;
>
> #ifdef I915
> const struct dpll *vlv_get_dpll(struct drm_i915_private *i915);
> -void g4x_dp_set_clock(struct intel_encoder *encoder,
> - struct intel_crtc_state *pipe_config);
> bool g4x_dp_port_enabled(struct drm_i915_private *dev_priv,
> i915_reg_t dp_reg, enum port port,
> enum pipe *pipe);
> @@ -31,10 +29,6 @@ static inline const struct dpll *vlv_get_dpll(struct drm_i915_private *i915)
> {
> return NULL;
> }
> -static inline void g4x_dp_set_clock(struct intel_encoder *encoder,
> - struct intel_crtc_state *pipe_config)
> -{
> -}
> static inline bool g4x_dp_port_enabled(struct drm_i915_private *dev_priv,
> i915_reg_t dp_reg, int port,
> enum pipe *pipe)
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index adc51567ec17..f8100c4f4d20 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -3172,9 +3172,6 @@ intel_dp_compute_config(struct intel_encoder *encoder,
> if (pipe_config->splitter.enable)
> pipe_config->dp_m_n.data_m *= pipe_config->splitter.link_count;
>
> - if (!HAS_DDI(dev_priv))
> - g4x_dp_set_clock(encoder, pipe_config);
> -
> intel_vrr_compute_config(pipe_config, conn_state);
> intel_dp_compute_as_sdp(intel_dp, pipe_config);
> intel_psr_compute_config(intel_dp, pipe_config, conn_state);
> --
> 2.39.5
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ i915.CI.BAT: success for series starting with [1/2] drm/i915/dp: add g4x_dp_compute_config()
2024-12-11 12:54 [PATCH 1/2] drm/i915/dp: add g4x_dp_compute_config() Jani Nikula
2024-12-11 12:54 ` [PATCH 2/2] drm/i915/dp: move g4x_dp_set_clock() call to g4x_dp_compute_config() Jani Nikula
@ 2024-12-11 13:55 ` Patchwork
2024-12-11 15:45 ` ✗ i915.CI.Full: failure " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2024-12-11 13:55 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915/dp: add g4x_dp_compute_config()
URL : https://patchwork.freedesktop.org/series/142411/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15819 -> Patchwork_142411v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/index.html
Participating hosts (46 -> 45)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_142411v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload:
- fi-cfl-8109u: [PASS][1] -> [DMESG-WARN][2] ([i915#11621] / [i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/fi-cfl-8109u/igt@i915_module_load@reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/fi-cfl-8109u/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@module-reload:
- bat-adls-6: [PASS][3] -> [FAIL][4] ([i915#12903])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/bat-adls-6/igt@i915_pm_rpm@module-reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/bat-adls-6/igt@i915_pm_rpm@module-reload.html
- bat-apl-1: [PASS][5] -> [FAIL][6] ([i915#12903])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/bat-apl-1/igt@i915_pm_rpm@module-reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/bat-apl-1/igt@i915_pm_rpm@module-reload.html
- bat-rpls-4: [PASS][7] -> [FAIL][8] ([i915#12903])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/bat-rpls-4/igt@i915_pm_rpm@module-reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/bat-rpls-4/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live:
- bat-mtlp-8: [PASS][9] -> [ABORT][10] ([i915#12061]) +1 other test abort
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/bat-mtlp-8/igt@i915_selftest@live.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/bat-mtlp-8/igt@i915_selftest@live.html
* igt@i915_selftest@live@workarounds:
- bat-arlh-3: [PASS][11] -> [ABORT][12] ([i915#12061]) +1 other test abort
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/bat-arlh-3/igt@i915_selftest@live@workarounds.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/bat-arlh-3/igt@i915_selftest@live@workarounds.html
- bat-adlp-9: [PASS][13] -> [INCOMPLETE][14] ([i915#9413]) +1 other test incomplete
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/bat-adlp-9/igt@i915_selftest@live@workarounds.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/bat-adlp-9/igt@i915_selftest@live@workarounds.html
* igt@kms_addfb_basic@too-high:
- fi-cfl-8109u: [PASS][15] -> [DMESG-WARN][16] ([i915#11621]) +51 other tests dmesg-warn
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/fi-cfl-8109u/igt@kms_addfb_basic@too-high.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/fi-cfl-8109u/igt@kms_addfb_basic@too-high.html
* igt@kms_flip@basic-flip-vs-wf_vblank:
- bat-apl-1: [PASS][17] -> [DMESG-WARN][18] ([i915#11621] / [i915#1982])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/bat-apl-1/igt@kms_flip@basic-flip-vs-wf_vblank.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/bat-apl-1/igt@kms_flip@basic-flip-vs-wf_vblank.html
* igt@kms_flip@basic-flip-vs-wf_vblank@c-dp1:
- bat-apl-1: [PASS][19] -> [DMESG-WARN][20] ([i915#11621])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/bat-apl-1/igt@kms_flip@basic-flip-vs-wf_vblank@c-dp1.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/bat-apl-1/igt@kms_flip@basic-flip-vs-wf_vblank@c-dp1.html
#### Possible fixes ####
* igt@core_auth@basic-auth:
- fi-cfl-8109u: [DMESG-WARN][21] ([i915#11621]) -> [PASS][22] +1 other test pass
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/fi-cfl-8109u/igt@core_auth@basic-auth.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/fi-cfl-8109u/igt@core_auth@basic-auth.html
* igt@i915_pm_rpm@module-reload:
- bat-dg1-7: [FAIL][23] ([i915#12903]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/bat-dg1-7/igt@i915_pm_rpm@module-reload.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/bat-dg1-7/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@workarounds:
- bat-mtlp-6: [ABORT][25] ([i915#12061]) -> [PASS][26] +1 other test pass
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
- fi-kbl-7567u: [DMESG-WARN][27] ([i915#12920]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/fi-kbl-7567u/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/fi-kbl-7567u/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: [SKIP][29] ([i915#9197]) -> [PASS][30] +1 other test pass
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
[i915#11621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11621
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#12903]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12903
[i915#12920]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12920
[i915#1982]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1982
[i915#9197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197
[i915#9413]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9413
Build changes
-------------
* Linux: CI_DRM_15819 -> Patchwork_142411v1
CI-20190529: 20190529
CI_DRM_15819: 03abf2f5f12e0f13a3a28bf70ccf2d88ec2a707b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8147: df65b61f81a5cc919c10ff9c5ed516b45364135c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_142411v1: 03abf2f5f12e0f13a3a28bf70ccf2d88ec2a707b @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/index.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ i915.CI.Full: failure for series starting with [1/2] drm/i915/dp: add g4x_dp_compute_config()
2024-12-11 12:54 [PATCH 1/2] drm/i915/dp: add g4x_dp_compute_config() Jani Nikula
2024-12-11 12:54 ` [PATCH 2/2] drm/i915/dp: move g4x_dp_set_clock() call to g4x_dp_compute_config() Jani Nikula
2024-12-11 13:55 ` ✓ i915.CI.BAT: success for series starting with [1/2] drm/i915/dp: add g4x_dp_compute_config() Patchwork
@ 2024-12-11 15:45 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2024-12-11 15:45 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 28448 bytes --]
== Series Details ==
Series: series starting with [1/2] drm/i915/dp: add g4x_dp_compute_config()
URL : https://patchwork.freedesktop.org/series/142411/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15819_full -> Patchwork_142411v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_142411v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_142411v1_full, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_142411v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_async_flips@crc-atomic:
- shard-tglu: NOTRUN -> [INCOMPLETE][1] +1 other test incomplete
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-3/igt@kms_async_flips@crc-atomic.html
* igt@kms_async_flips@crc-atomic@pipe-a-hdmi-a-1:
- shard-snb: [PASS][2] -> [INCOMPLETE][3] +1 other test incomplete
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/shard-snb1/igt@kms_async_flips@crc-atomic@pipe-a-hdmi-a-1.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-snb5/igt@kms_async_flips@crc-atomic@pipe-a-hdmi-a-1.html
* igt@kms_async_flips@crc-atomic@pipe-d-hdmi-a-3:
- shard-dg2: NOTRUN -> [CRASH][4] +3 other tests crash
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-5/igt@kms_async_flips@crc-atomic@pipe-d-hdmi-a-3.html
Known issues
------------
Here are the changes found in Patchwork_142411v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_fdinfo@most-busy-idle-check-all@bcs0:
- shard-dg1: NOTRUN -> [SKIP][5] ([i915#8414]) +5 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg1-12/igt@drm_fdinfo@most-busy-idle-check-all@bcs0.html
* igt@gem_ctx_persistence@engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][6] ([i915#1099]) +1 other test skip
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-snb7/igt@gem_ctx_persistence@engines-mixed-process.html
* igt@gem_eio@unwedge-stress:
- shard-snb: NOTRUN -> [FAIL][7] ([i915#8898])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-snb7/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@persistence:
- shard-tglu: NOTRUN -> [ABORT][8] ([i915#13218]) +1 other test abort
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-3/igt@gem_exec_balancer@persistence.html
* igt@gem_exec_fence@concurrent:
- shard-dg2: NOTRUN -> [SKIP][9] ([i915#4812])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@gem_exec_fence@concurrent.html
* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-tglu: NOTRUN -> [SKIP][10] ([i915#4613])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-3/igt@gem_lmem_swapping@parallel-random-verify-ccs.html
* igt@gem_pxp@create-protected-buffer:
- shard-rkl: NOTRUN -> [TIMEOUT][11] ([i915#12964])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-rkl-4/igt@gem_pxp@create-protected-buffer.html
- shard-dg2: NOTRUN -> [SKIP][12] ([i915#4270])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@gem_pxp@create-protected-buffer.html
* igt@gem_render_copy@yf-tiled-to-vebox-linear:
- shard-dg2: NOTRUN -> [SKIP][13] ([i915#5190] / [i915#8428])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@gem_render_copy@yf-tiled-to-vebox-linear.html
* igt@gem_tiled_swapping@non-threaded:
- shard-snb: NOTRUN -> [ABORT][14] ([i915#13263])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-snb7/igt@gem_tiled_swapping@non-threaded.html
* igt@gem_vm_create@invalid-create:
- shard-snb: NOTRUN -> [SKIP][15] +180 other tests skip
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-snb7/igt@gem_vm_create@invalid-create.html
* igt@gen9_exec_parse@allowed-all:
- shard-tglu: NOTRUN -> [SKIP][16] ([i915#2527] / [i915#2856])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-4/igt@gen9_exec_parse@allowed-all.html
* igt@i915_suspend@fence-restore-untiled:
- shard-dg2: NOTRUN -> [SKIP][17] ([i915#4077])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-2-y-rc-ccs-cc:
- shard-rkl: NOTRUN -> [SKIP][18] ([i915#8709]) +3 other tests skip
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-rkl-3/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-2-y-rc-ccs-cc.html
* igt@kms_async_flips@invalid-async-flip:
- shard-dg2: NOTRUN -> [SKIP][19] ([i915#6228])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@kms_async_flips@invalid-async-flip.html
* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-snb: NOTRUN -> [SKIP][20] ([i915#1769])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-snb1/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180:
- shard-tglu: NOTRUN -> [SKIP][21] ([i915#5286])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-3/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-0:
- shard-tglu: NOTRUN -> [SKIP][22] +6 other tests skip
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-3/igt@kms_big_fb@yf-tiled-32bpp-rotate-0.html
* igt@kms_big_fb@yf-tiled-addfb:
- shard-tglu-1: NOTRUN -> [SKIP][23] +1 other test skip
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-1/igt@kms_big_fb@yf-tiled-addfb.html
- shard-dg1: NOTRUN -> [SKIP][24]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg1-17/igt@kms_big_fb@yf-tiled-addfb.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-dg2: NOTRUN -> [SKIP][25] ([i915#4538] / [i915#5190])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html
- shard-rkl: NOTRUN -> [SKIP][26] +1 other test skip
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-rkl-4/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html
* igt@kms_ccs@bad-pixel-format-y-tiled-ccs@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][27] ([i915#10307] / [i915#10434] / [i915#6095]) +1 other test skip
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-8/igt@kms_ccs@bad-pixel-format-y-tiled-ccs@pipe-d-hdmi-a-1.html
* igt@kms_ccs@bad-rotation-90-4-tiled-bmg-ccs:
- shard-tglu: NOTRUN -> [SKIP][28] ([i915#12313]) +1 other test skip
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-4/igt@kms_ccs@bad-rotation-90-4-tiled-bmg-ccs.html
* igt@kms_ccs@crc-primary-suspend-y-tiled-ccs:
- shard-dg2: NOTRUN -> [SKIP][29] ([i915#6095]) +4 other tests skip
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@kms_ccs@crc-primary-suspend-y-tiled-ccs.html
* igt@kms_ccs@crc-primary-suspend-y-tiled-ccs@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][30] ([i915#6095]) +7 other tests skip
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-rkl-4/igt@kms_ccs@crc-primary-suspend-y-tiled-ccs@pipe-a-hdmi-a-1.html
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-rc-ccs@pipe-a-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][31] ([i915#10307] / [i915#6095]) +22 other tests skip
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-8/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-rc-ccs@pipe-a-hdmi-a-1.html
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-rc-ccs@pipe-c-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][32] ([i915#6095]) +23 other tests skip
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg1-12/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-rc-ccs@pipe-c-hdmi-a-3.html
* igt@kms_cdclk@mode-transition@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][33] ([i915#11616] / [i915#7213]) +3 other tests skip
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-8/igt@kms_cdclk@mode-transition@pipe-d-hdmi-a-1.html
* igt@kms_chamelium_frames@dp-frame-dump:
- shard-dg2: NOTRUN -> [SKIP][34] ([i915#7828])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@kms_chamelium_frames@dp-frame-dump.html
- shard-tglu-1: NOTRUN -> [SKIP][35] ([i915#7828])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-1/igt@kms_chamelium_frames@dp-frame-dump.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- shard-tglu: NOTRUN -> [SKIP][36] ([i915#7828])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-3/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_content_protection@legacy@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][37] ([i915#7173])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-10/igt@kms_content_protection@legacy@pipe-a-dp-4.html
* igt@kms_cursor_crc@cursor-offscreen-512x512:
- shard-tglu: NOTRUN -> [SKIP][38] ([i915#13049])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-4/igt@kms_cursor_crc@cursor-offscreen-512x512.html
* igt@kms_cursor_legacy@short-flip-after-cursor-toggle:
- shard-glk: [PASS][39] -> [FAIL][40] ([i915#2346])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/shard-glk2/igt@kms_cursor_legacy@short-flip-after-cursor-toggle.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-glk8/igt@kms_cursor_legacy@short-flip-after-cursor-toggle.html
* igt@kms_dsc@dsc-basic:
- shard-tglu: NOTRUN -> [SKIP][41] ([i915#3555] / [i915#3840])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-4/igt@kms_dsc@dsc-basic.html
* igt@kms_dsc@dsc-fractional-bpp-with-bpc:
- shard-dg2: NOTRUN -> [SKIP][42] ([i915#3840])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@kms_dsc@dsc-fractional-bpp-with-bpc.html
- shard-rkl: NOTRUN -> [SKIP][43] ([i915#3840])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-rkl-4/igt@kms_dsc@dsc-fractional-bpp-with-bpc.html
* igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-hdmi-a1:
- shard-rkl: NOTRUN -> [DMESG-WARN][44] ([i915#12964]) +5 other tests dmesg-warn
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-rkl-4/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-hdmi-a1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-hdmi-a2:
- shard-rkl: [PASS][45] -> [ABORT][46] ([i915#13218]) +1 other test abort
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/shard-rkl-1/igt@kms_flip@flip-vs-suspend-interruptible@a-hdmi-a2.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-rkl-5/igt@kms_flip@flip-vs-suspend-interruptible@a-hdmi-a2.html
* igt@kms_force_connector_basic@prune-stale-modes:
- shard-dg2: NOTRUN -> [SKIP][47] ([i915#5274])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-tglu: NOTRUN -> [ABORT][48] ([i915#10159] / [i915#13218])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-4/igt@kms_frontbuffer_tracking@fbc-suspend.html
- shard-glk: NOTRUN -> [INCOMPLETE][49] ([i915#10056])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-glk4/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbc-tiling-4:
- shard-tglu: NOTRUN -> [SKIP][50] ([i915#5439])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-4/igt@kms_frontbuffer_tracking@fbc-tiling-4.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-plflip-blt:
- shard-rkl: NOTRUN -> [SKIP][51] ([i915#1825]) +1 other test skip
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-rkl-4/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-plflip-blt.html
- shard-dg2: NOTRUN -> [SKIP][52] ([i915#5354])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-pwrite:
- shard-rkl: NOTRUN -> [SKIP][53] ([i915#3023]) +3 other tests skip
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-rkl-4/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-dg1: NOTRUN -> [SKIP][54] ([i915#3458])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg1-17/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-mmap-wc:
- shard-dg2: NOTRUN -> [SKIP][55] ([i915#8708]) +2 other tests skip
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
- shard-dg2: NOTRUN -> [SKIP][56] ([i915#3458]) +2 other tests skip
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
* igt@kms_hdr@static-swap:
- shard-dg2: NOTRUN -> [SKIP][57] ([i915#3555] / [i915#8228])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@kms_hdr@static-swap.html
- shard-rkl: NOTRUN -> [SKIP][58] ([i915#3555] / [i915#8228])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-rkl-4/igt@kms_hdr@static-swap.html
* igt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes:
- shard-dg2: NOTRUN -> [SKIP][59]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@kms_pipe_b_c_ivb@enable-pipe-c-while-b-has-3-lanes.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- shard-tglu-1: NOTRUN -> [ABORT][60] ([i915#10159] / [i915#13218])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-1/igt@kms_pipe_crc_basic@suspend-read-crc.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-hdmi-a-1:
- shard-tglu-1: NOTRUN -> [ABORT][61] ([i915#13218]) +1 other test abort
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-1/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-hdmi-a-1.html
* igt@kms_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-dg1: NOTRUN -> [SKIP][62] ([i915#9519])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg1-17/igt@kms_pm_rpm@modeset-lpsp-stress-no-wait.html
* igt@kms_pm_rpm@modeset-non-lpsp-stress:
- shard-dg2: [PASS][63] -> [SKIP][64] ([i915#9519])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/shard-dg2-10/igt@kms_pm_rpm@modeset-non-lpsp-stress.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-8/igt@kms_pm_rpm@modeset-non-lpsp-stress.html
* igt@kms_psr2_sf@pr-overlay-plane-update-continuous-sf:
- shard-snb: NOTRUN -> [SKIP][65] ([i915#11520]) +2 other tests skip
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-snb7/igt@kms_psr2_sf@pr-overlay-plane-update-continuous-sf.html
* igt@kms_psr2_sf@psr2-plane-move-sf-dmg-area:
- shard-dg2: NOTRUN -> [SKIP][66] ([i915#11520])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@kms_psr2_sf@psr2-plane-move-sf-dmg-area.html
- shard-rkl: NOTRUN -> [SKIP][67] ([i915#11520])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-rkl-4/igt@kms_psr2_sf@psr2-plane-move-sf-dmg-area.html
* igt@kms_psr@fbc-psr2-suspend:
- shard-rkl: NOTRUN -> [SKIP][68] ([i915#1072] / [i915#9732]) +1 other test skip
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-rkl-4/igt@kms_psr@fbc-psr2-suspend.html
* igt@kms_psr@psr2-cursor-render:
- shard-dg2: NOTRUN -> [SKIP][69] ([i915#1072] / [i915#9732]) +1 other test skip
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@kms_psr@psr2-cursor-render.html
* igt@kms_psr@psr2-sprite-mmap-cpu:
- shard-tglu: NOTRUN -> [SKIP][70] ([i915#9732]) +1 other test skip
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-4/igt@kms_psr@psr2-sprite-mmap-cpu.html
- shard-glk: NOTRUN -> [SKIP][71] +3 other tests skip
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-glk4/igt@kms_psr@psr2-sprite-mmap-cpu.html
* igt@kms_vrr@seamless-rr-switch-drrs:
- shard-tglu: NOTRUN -> [SKIP][72] ([i915#9906])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-tglu-4/igt@kms_vrr@seamless-rr-switch-drrs.html
* igt@perf_pmu@render-node-busy:
- shard-dg1: NOTRUN -> [ABORT][73] ([i915#13218]) +2 other tests abort
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg1-12/igt@perf_pmu@render-node-busy.html
* igt@perf_pmu@render-node-busy-idle:
- shard-snb: NOTRUN -> [ABORT][74] ([i915#13218]) +3 other tests abort
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-snb7/igt@perf_pmu@render-node-busy-idle.html
* igt@perf_pmu@semaphore-wait:
- shard-rkl: NOTRUN -> [ABORT][75] ([i915#13218]) +1 other test abort
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-rkl-4/igt@perf_pmu@semaphore-wait.html
* igt@perf_pmu@semaphore-wait@rcs0:
- shard-dg2: NOTRUN -> [ABORT][76] ([i915#13218]) +2 other tests abort
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-7/igt@perf_pmu@semaphore-wait@rcs0.html
#### Possible fixes ####
* igt@gen9_exec_parse@allowed-all:
- shard-glk: [ABORT][77] ([i915#5566]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/shard-glk3/igt@gen9_exec_parse@allowed-all.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-glk4/igt@gen9_exec_parse@allowed-all.html
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-snb: [FAIL][79] ([i915#2346]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/shard-snb1/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-snb5/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-pgflip-blt:
- shard-snb: [SKIP][81] -> [PASS][82] +4 other tests pass
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/shard-snb1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-pgflip-blt.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-snb5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-pgflip-blt.html
* igt@kms_hdr@static-toggle:
- shard-dg2: [SKIP][83] ([i915#3555] / [i915#8228]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/shard-dg2-7/igt@kms_hdr@static-toggle.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-10/igt@kms_hdr@static-toggle.html
#### Warnings ####
* igt@kms_content_protection@legacy:
- shard-dg2: [SKIP][85] ([i915#7118] / [i915#9424]) -> [TIMEOUT][86] ([i915#7173])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/shard-dg2-1/igt@kms_content_protection@legacy.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-10/igt@kms_content_protection@legacy.html
* igt@kms_content_protection@lic-type-0:
- shard-dg2: [TIMEOUT][87] ([i915#7173]) -> [SKIP][88] ([i915#9424])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/shard-dg2-10/igt@kms_content_protection@lic-type-0.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-8/igt@kms_content_protection@lic-type-0.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-glk: [INCOMPLETE][89] ([i915#12745] / [i915#4839]) -> [INCOMPLETE][90] ([i915#12745] / [i915#1982] / [i915#4839])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/shard-glk9/igt@kms_flip@flip-vs-suspend-interruptible.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-glk1/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-hdmi-a1:
- shard-glk: [INCOMPLETE][91] ([i915#12745]) -> [INCOMPLETE][92] ([i915#12745] / [i915#1982])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/shard-glk9/igt@kms_flip@flip-vs-suspend-interruptible@a-hdmi-a1.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-glk1/igt@kms_flip@flip-vs-suspend-interruptible@a-hdmi-a1.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-cpu:
- shard-dg2: [SKIP][93] ([i915#10433] / [i915#3458]) -> [SKIP][94] ([i915#3458])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15819/shard-dg2-4/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-cpu.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-cpu.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#10056]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10056
[i915#10159]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10159
[i915#10307]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10307
[i915#10433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10433
[i915#10434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10434
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1099
[i915#11520]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11520
[i915#11616]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11616
[i915#12247]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12247
[i915#12313]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12313
[i915#12745]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12745
[i915#12964]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12964
[i915#13049]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13049
[i915#13218]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13218
[i915#13263]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13263
[i915#1769]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1825
[i915#1982]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1982
[i915#2346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2527
[i915#2856]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
[i915#3458]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3458
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4212
[i915#4235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4235
[i915#4270]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4270
[i915#4538]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4812
[i915#4839]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4839
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5274
[i915#5286]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5286
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#5439]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5439
[i915#5566]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5566
[i915#6095]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6095
[i915#6228]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6228
[i915#7118]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7118
[i915#7173]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7173
[i915#7213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7213
[i915#7828]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7828
[i915#8228]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8228
[i915#8414]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8414
[i915#8428]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8428
[i915#8708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8708
[i915#8709]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8709
[i915#8898]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8898
[i915#9423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9423
[i915#9424]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9424
[i915#9519]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9519
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9906]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9906
[i915#9934]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9934
Build changes
-------------
* Linux: CI_DRM_15819 -> Patchwork_142411v1
CI-20190529: 20190529
CI_DRM_15819: 03abf2f5f12e0f13a3a28bf70ccf2d88ec2a707b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8147: df65b61f81a5cc919c10ff9c5ed516b45364135c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_142411v1: 03abf2f5f12e0f13a3a28bf70ccf2d88ec2a707b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142411v1/index.html
[-- Attachment #2: Type: text/html, Size: 33615 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] drm/i915/dp: move g4x_dp_set_clock() call to g4x_dp_compute_config()
2024-12-11 13:42 ` Ville Syrjälä
@ 2024-12-11 17:17 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2024-12-11 17:17 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Wed, 11 Dec 2024, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Dec 11, 2024 at 02:54:31PM +0200, Jani Nikula wrote:
>> It does not look like anything in intel_dp_compute_config() after the
>> g4x_dp_set_clock() call depends on the changes it makes, namely setting
>> dpll and clock_set in crtc_state.
>
> Hmm, yeah I was a bit worried about DRRS and such, but as long
> as don't mangle the clock itself/etc. then this looks fine.
>
> Series is
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks, pushed to din.
BR,
Jani.
>
>> Move the call one level higher to
>> g4x_dp_compute_config() to reduce the clutter in
>> intel_dp_compute_config().
>>
>> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/g4x_dp.c | 13 ++++++++++---
>> drivers/gpu/drm/i915/display/g4x_dp.h | 6 ------
>> drivers/gpu/drm/i915/display/intel_dp.c | 3 ---
>> 3 files changed, 10 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/g4x_dp.c b/drivers/gpu/drm/i915/display/g4x_dp.c
>> index 9ac894a7411f..e06405a3b82d 100644
>> --- a/drivers/gpu/drm/i915/display/g4x_dp.c
>> +++ b/drivers/gpu/drm/i915/display/g4x_dp.c
>> @@ -55,8 +55,8 @@ const struct dpll *vlv_get_dpll(struct drm_i915_private *i915)
>> return IS_CHERRYVIEW(i915) ? &chv_dpll[0] : &vlv_dpll[0];
>> }
>>
>> -void g4x_dp_set_clock(struct intel_encoder *encoder,
>> - struct intel_crtc_state *pipe_config)
>> +static void g4x_dp_set_clock(struct intel_encoder *encoder,
>> + struct intel_crtc_state *pipe_config)
>> {
>> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
>> const struct dpll *divisor = NULL;
>> @@ -1228,11 +1228,18 @@ static int g4x_dp_compute_config(struct intel_encoder *encoder,
>> struct drm_connector_state *conn_state)
>> {
>> struct drm_i915_private *i915 = to_i915(encoder->base.dev);
>> + int ret;
>>
>> if (HAS_PCH_SPLIT(i915) && encoder->port != PORT_A)
>> crtc_state->has_pch_encoder = true;
>>
>> - return intel_dp_compute_config(encoder, crtc_state, conn_state);
>> + ret = intel_dp_compute_config(encoder, crtc_state, conn_state);
>> + if (ret)
>> + return ret;
>> +
>> + g4x_dp_set_clock(encoder, crtc_state);
>> +
>> + return 0;
>> }
>>
>> static void g4x_dp_suspend_complete(struct intel_encoder *encoder)
>> diff --git a/drivers/gpu/drm/i915/display/g4x_dp.h b/drivers/gpu/drm/i915/display/g4x_dp.h
>> index c75e64ae79b7..839a251dc069 100644
>> --- a/drivers/gpu/drm/i915/display/g4x_dp.h
>> +++ b/drivers/gpu/drm/i915/display/g4x_dp.h
>> @@ -19,8 +19,6 @@ struct intel_encoder;
>>
>> #ifdef I915
>> const struct dpll *vlv_get_dpll(struct drm_i915_private *i915);
>> -void g4x_dp_set_clock(struct intel_encoder *encoder,
>> - struct intel_crtc_state *pipe_config);
>> bool g4x_dp_port_enabled(struct drm_i915_private *dev_priv,
>> i915_reg_t dp_reg, enum port port,
>> enum pipe *pipe);
>> @@ -31,10 +29,6 @@ static inline const struct dpll *vlv_get_dpll(struct drm_i915_private *i915)
>> {
>> return NULL;
>> }
>> -static inline void g4x_dp_set_clock(struct intel_encoder *encoder,
>> - struct intel_crtc_state *pipe_config)
>> -{
>> -}
>> static inline bool g4x_dp_port_enabled(struct drm_i915_private *dev_priv,
>> i915_reg_t dp_reg, int port,
>> enum pipe *pipe)
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>> index adc51567ec17..f8100c4f4d20 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> @@ -3172,9 +3172,6 @@ intel_dp_compute_config(struct intel_encoder *encoder,
>> if (pipe_config->splitter.enable)
>> pipe_config->dp_m_n.data_m *= pipe_config->splitter.link_count;
>>
>> - if (!HAS_DDI(dev_priv))
>> - g4x_dp_set_clock(encoder, pipe_config);
>> -
>> intel_vrr_compute_config(pipe_config, conn_state);
>> intel_dp_compute_as_sdp(intel_dp, pipe_config);
>> intel_psr_compute_config(intel_dp, pipe_config, conn_state);
>> --
>> 2.39.5
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-12-11 17:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-11 12:54 [PATCH 1/2] drm/i915/dp: add g4x_dp_compute_config() Jani Nikula
2024-12-11 12:54 ` [PATCH 2/2] drm/i915/dp: move g4x_dp_set_clock() call to g4x_dp_compute_config() Jani Nikula
2024-12-11 13:42 ` Ville Syrjälä
2024-12-11 17:17 ` Jani Nikula
2024-12-11 13:55 ` ✓ i915.CI.BAT: success for series starting with [1/2] drm/i915/dp: add g4x_dp_compute_config() Patchwork
2024-12-11 15:45 ` ✗ i915.CI.Full: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.