* [tip:irq/core 39/46] drivers/irqchip/irq-loongarch-avec.c:82:17: error: implicit declaration of function 'loongson_send_ipi_single'
@ 2024-06-23 21:06 kernel test robot
2024-06-24 13:45 ` Thomas Gleixner
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2024-06-23 21:06 UTC (permalink / raw)
To: Tianyang Zhang
Cc: oe-kbuild-all, linux-kernel, x86, Thomas Gleixner, Jianmin Lv,
Liupu Wang
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core
head: c9d269469d2b9a06559cdc84d12dd3fb4d552581
commit: 760d7e719499d64beea62bfcf53938fb233bb6e7 [39/46] Loongarch: Support loongarch avec
config: loongarch-allnoconfig (https://download.01.org/0day-ci/archive/20240624/202406240451.ygBFNyJ3-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240624/202406240451.ygBFNyJ3-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406240451.ygBFNyJ3-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/irqchip/irq-loongarch-avec.c: In function 'loongarch_avec_sync':
>> drivers/irqchip/irq-loongarch-avec.c:82:17: error: implicit declaration of function 'loongson_send_ipi_single' [-Werror=implicit-function-declaration]
82 | loongson_send_ipi_single(adata->prev_cpu, SMP_CLEAR_VECT);
| ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/irqchip/irq-loongarch-avec.c:82:59: error: 'SMP_CLEAR_VECT' undeclared (first use in this function)
82 | loongson_send_ipi_single(adata->prev_cpu, SMP_CLEAR_VECT);
| ^~~~~~~~~~~~~~
drivers/irqchip/irq-loongarch-avec.c:82:59: note: each undeclared identifier is reported only once for each function it appears in
drivers/irqchip/irq-loongarch-avec.c: In function 'complete_irq_moving':
drivers/irqchip/irq-loongarch-avec.c:173:55: error: 'SMP_CLEAR_VECT' undeclared (first use in this function)
173 | loongson_send_ipi_single(cpu, SMP_CLEAR_VECT);
| ^~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/loongson_send_ipi_single +82 drivers/irqchip/irq-loongarch-avec.c
73
74 static void loongarch_avec_sync(struct loongarch_avec_data *adata)
75 {
76 struct pending_list *plist;
77
78 if (cpu_online(adata->prev_cpu)) {
79 plist = per_cpu_ptr(&pending_list, adata->prev_cpu);
80 list_add_tail(&adata->entry, &plist->head);
81 adata->moving = true;
> 82 loongson_send_ipi_single(adata->prev_cpu, SMP_CLEAR_VECT);
83 }
84 adata->prev_cpu = adata->cpu;
85 adata->prev_vec = adata->vec;
86 }
87
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [tip:irq/core 39/46] drivers/irqchip/irq-loongarch-avec.c:82:17: error: implicit declaration of function 'loongson_send_ipi_single'
2024-06-23 21:06 [tip:irq/core 39/46] drivers/irqchip/irq-loongarch-avec.c:82:17: error: implicit declaration of function 'loongson_send_ipi_single' kernel test robot
@ 2024-06-24 13:45 ` Thomas Gleixner
2024-06-25 5:00 ` Tianyang Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Gleixner @ 2024-06-24 13:45 UTC (permalink / raw)
To: kernel test robot, Tianyang Zhang
Cc: oe-kbuild-all, linux-kernel, x86, Jianmin Lv, Liupu Wang
On Mon, Jun 24 2024 at 05:06, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core
> head: c9d269469d2b9a06559cdc84d12dd3fb4d552581
> commit: 760d7e719499d64beea62bfcf53938fb233bb6e7 [39/46] Loongarch: Support loongarch avec
> config: loongarch-allnoconfig (https://download.01.org/0day-ci/archive/20240624/202406240451.ygBFNyJ3-lkp@intel.com/config)
> compiler: loongarch64-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240624/202406240451.ygBFNyJ3-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202406240451.ygBFNyJ3-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> drivers/irqchip/irq-loongarch-avec.c: In function 'loongarch_avec_sync':
>>> drivers/irqchip/irq-loongarch-avec.c:82:17: error: implicit declaration of function 'loongson_send_ipi_single' [-Werror=implicit-function-declaration]
> 82 | loongson_send_ipi_single(adata->prev_cpu, SMP_CLEAR_VECT);
> | ^~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/irqchip/irq-loongarch-avec.c:82:59: error: 'SMP_CLEAR_VECT' undeclared (first use in this function)
> 82 | loongson_send_ipi_single(adata->prev_cpu, SMP_CLEAR_VECT);
> | ^~~~~~~~~~~~~~
> drivers/irqchip/irq-loongarch-avec.c:82:59: note: each undeclared identifier is reported only once for each function it appears in
> drivers/irqchip/irq-loongarch-avec.c: In function 'complete_irq_moving':
> drivers/irqchip/irq-loongarch-avec.c:173:55: error: 'SMP_CLEAR_VECT' undeclared (first use in this function)
> 173 | loongson_send_ipi_single(cpu, SMP_CLEAR_VECT);
> | ^~~~~~~~~~~~~~
So this code was never built with CONFIG_SMP=n.
Can the loongson folks please send me a delta patch ASAP, otherwise I'm
going to revert it.
Thanks,
tglx
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [tip:irq/core 39/46] drivers/irqchip/irq-loongarch-avec.c:82:17: error: implicit declaration of function 'loongson_send_ipi_single'
2024-06-24 13:45 ` Thomas Gleixner
@ 2024-06-25 5:00 ` Tianyang Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Tianyang Zhang @ 2024-06-25 5:00 UTC (permalink / raw)
To: Thomas Gleixner, kernel test robot
Cc: oe-kbuild-all, linux-kernel, x86, Jianmin Lv, Liupu Wang
Hi, Thomas
在 2024/6/24 下午9:45, Thomas Gleixner 写道:
> On Mon, Jun 24 2024 at 05:06, kernel test robot wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core
>> head: c9d269469d2b9a06559cdc84d12dd3fb4d552581
>> commit: 760d7e719499d64beea62bfcf53938fb233bb6e7 [39/46] Loongarch: Support loongarch avec
>> config: loongarch-allnoconfig (https://download.01.org/0day-ci/archive/20240624/202406240451.ygBFNyJ3-lkp@intel.com/config)
>> compiler: loongarch64-linux-gcc (GCC) 13.2.0
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240624/202406240451.ygBFNyJ3-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202406240451.ygBFNyJ3-lkp@intel.com/
>>
>> All errors (new ones prefixed by >>):
>>
>> drivers/irqchip/irq-loongarch-avec.c: In function 'loongarch_avec_sync':
>>>> drivers/irqchip/irq-loongarch-avec.c:82:17: error: implicit declaration of function 'loongson_send_ipi_single' [-Werror=implicit-function-declaration]
>> 82 | loongson_send_ipi_single(adata->prev_cpu, SMP_CLEAR_VECT);
>> | ^~~~~~~~~~~~~~~~~~~~~~~~
>>>> drivers/irqchip/irq-loongarch-avec.c:82:59: error: 'SMP_CLEAR_VECT' undeclared (first use in this function)
>> 82 | loongson_send_ipi_single(adata->prev_cpu, SMP_CLEAR_VECT);
>> | ^~~~~~~~~~~~~~
>> drivers/irqchip/irq-loongarch-avec.c:82:59: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/irqchip/irq-loongarch-avec.c: In function 'complete_irq_moving':
>> drivers/irqchip/irq-loongarch-avec.c:173:55: error: 'SMP_CLEAR_VECT' undeclared (first use in this function)
>> 173 | loongson_send_ipi_single(cpu, SMP_CLEAR_VECT);
>> | ^~~~~~~~~~~~~~
> So this code was never built with CONFIG_SMP=n.
>
> Can the loongson folks please send me a delta patch ASAP, otherwise I'm
> going to revert it.
>
> Thanks,
>
> tglx
We have also noticed this issue and found that the patch has other
issues that may cause it to fail to start on a certain model of machine.
If possible, please reverse this patch and we will resend a V2 version
patch as soon as possible based on this patch
Thanks you
Tianyang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-25 5:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-23 21:06 [tip:irq/core 39/46] drivers/irqchip/irq-loongarch-avec.c:82:17: error: implicit declaration of function 'loongson_send_ipi_single' kernel test robot
2024-06-24 13:45 ` Thomas Gleixner
2024-06-25 5:00 ` Tianyang Zhang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.