All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: broonie@kernel.org, andriy.shevchenko@linux.intel.com,
	lgirdwood@gmail.com, pierre-louis.bossart@linux.intel.com,
	13916275206@139.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com,
	bard.liao@intel.com, yung-chuan.liao@linux.intel.com,
	kevin-lu@ti.com, cameron.berkenpas@gmail.com, baojun.xu@ti.com,
	soyer@irl.hu, Baojun.Xu@fpt.com
Subject: Re: [RESEND PATCH v5 1/3] ASoC: tas2781: Fix wrong loading calibrated data sequence
Date: Fri, 17 May 2024 11:36:44 +0200	[thread overview]
Message-ID: <87seygzsnn.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240517092039.688-1-shenghao-ding@ti.com>

On Fri, 17 May 2024 11:20:36 +0200,
Shenghao Ding wrote:
> 
> Remove declaration of unused API which load calibrated data in wrong
> sequence, changed the copyright year and correct file name in license
> header.
> 
> Fixes: ef3bcde75d06 ("ASoc: tas2781: Add tas2781 driver")
> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>

First off, this breaks the build.  You are removing the function that
is still called.  You will remove the caller in a later patch, but
it's still there at this point.  That's what Andy suggested for the
whole time.

Try to apply only this patch and build module.  You'll get a compile
error.  This must be avoided.

Second, it makes little sense to split the patches in that way.
A copyright year change can be folded into the same patch.  If any, a
patch to correct the ifdef as a separate patch, as it's completely
irrelevant with the fix itself.


thanks,

Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: <broonie@kernel.org>, <andriy.shevchenko@linux.intel.com>,
	<lgirdwood@gmail.com>, <perex@perex.cz>,
	<pierre-louis.bossart@linux.intel.com>, <13916275206@139.com>,
	<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
	<liam.r.girdwood@intel.com>, <bard.liao@intel.com>,
	<yung-chuan.liao@linux.intel.com>, <kevin-lu@ti.com>,
	<cameron.berkenpas@gmail.com>, <baojun.xu@ti.com>, <soyer@irl.hu>,
	<Baojun.Xu@fpt.com>
Subject: Re: [RESEND PATCH v5 1/3] ASoC: tas2781: Fix wrong loading calibrated data sequence
Date: Fri, 17 May 2024 11:36:44 +0200	[thread overview]
Message-ID: <87seygzsnn.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240517092039.688-1-shenghao-ding@ti.com>

On Fri, 17 May 2024 11:20:36 +0200,
Shenghao Ding wrote:
> 
> Remove declaration of unused API which load calibrated data in wrong
> sequence, changed the copyright year and correct file name in license
> header.
> 
> Fixes: ef3bcde75d06 ("ASoc: tas2781: Add tas2781 driver")
> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>

First off, this breaks the build.  You are removing the function that
is still called.  You will remove the caller in a later patch, but
it's still there at this point.  That's what Andy suggested for the
whole time.

Try to apply only this patch and build module.  You'll get a compile
error.  This must be avoided.

Second, it makes little sense to split the patches in that way.
A copyright year change can be folded into the same patch.  If any, a
patch to correct the ifdef as a separate patch, as it's completely
irrelevant with the fix itself.


thanks,

Takashi

  parent reply	other threads:[~2024-05-20 12:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-17  9:20 [RESEND PATCH v5 1/3] ASoC: tas2781: Fix wrong loading calibrated data sequence Shenghao Ding
2024-05-17  9:20 ` [RESEND PATCH v5 2/3] " Shenghao Ding
2024-05-17  9:20 ` [RESEND PATCH v5 3/3] " Shenghao Ding
2024-05-17  9:36 ` Takashi Iwai [this message]
2024-05-17  9:36   ` [RESEND PATCH v5 1/3] " Takashi Iwai
2024-05-17 13:50 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87seygzsnn.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=13916275206@139.com \
    --cc=Baojun.Xu@fpt.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=baojun.xu@ti.com \
    --cc=bard.liao@intel.com \
    --cc=broonie@kernel.org \
    --cc=cameron.berkenpas@gmail.com \
    --cc=kevin-lu@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=liam.r.girdwood@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=shenghao-ding@ti.com \
    --cc=soyer@irl.hu \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.