[PATCH dovetail] x86: irq_pipeline: Add missing definition for !CONFIG_IRQ_PIPELINE

[PATCH dovetail] x86: irq_pipeline: Add missing definition for !CONFIG_IRQ_PIPELINE

[Fabian Scheler]

Fixup b917e98008314b3c7596099f48ea98f541451083 introducing
DEFINE_IDTENTRY_SYSVEC_PIPELINED_NORETURN only if CONFIG_IRQ_PIPELINE is
defined.

Reported-by: Roman Hodek <roman.hodek@siemens.com>
Signed-off-by: Roman Hodek <roman.hodek@siemens.com>
---
 arch/x86/include/asm/idtentry.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h
index 9b936d3e76a2..307623b4e10e 100644
--- a/arch/x86/include/asm/idtentry.h
+++ b/arch/x86/include/asm/idtentry.h
@@ -230,6 +230,7 @@ __visible __noreturn void __##func(struct pt_regs *regs)
 
 #define DEFINE_IDTENTRY_IRQ_PIPELINED(func)			DEFINE_IDTENTRY_IRQ(func)
 #define DEFINE_IDTENTRY_SYSVEC_PIPELINED(vector, func)		DEFINE_IDTENTRY_SYSVEC(func)
+#define DEFINE_IDTENTRY_SYSVEC_PIPELINED_NORETURN(vector, func)	DEFINE_IDTENTRY_SYSVEC(func)
 #define DEFINE_IDTENTRY_SYSVEC_SIMPLE_PIPELINED(vector, func)	DEFINE_IDTENTRY_SYSVEC_SIMPLE(func)
 
 /**
-- 
2.44.0

Re: [PATCH dovetail] x86: irq_pipeline: Add missing definition for !CONFIG_IRQ_PIPELINE

[Florian Bezdeka]

[To: Adding Philippe, the dovetail maintainer]

To Fabian, Roman:
Is that a drive-by fix or do you really have the IRQ pipelining
disabled. If disabled: We should discuss this internally!

To Philippe: Hope you can fetch the patch from the Xenomai list.
Thanks!

Best regards,
Florian

On Tue, 2024-04-23 at 12:41 +0200, Fabian Scheler wrote:
> Fixup b917e98008314b3c7596099f48ea98f541451083 introducing
> DEFINE_IDTENTRY_SYSVEC_PIPELINED_NORETURN only if CONFIG_IRQ_PIPELINE is
> defined.
> 
> Reported-by: Roman Hodek <roman.hodek@siemens.com>
> Signed-off-by: Roman Hodek <roman.hodek@siemens.com>
> ---
>  arch/x86/include/asm/idtentry.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h
> index 9b936d3e76a2..307623b4e10e 100644
> --- a/arch/x86/include/asm/idtentry.h
> +++ b/arch/x86/include/asm/idtentry.h
> @@ -230,6 +230,7 @@ __visible __noreturn void __##func(struct pt_regs *regs)
>  
>  #define DEFINE_IDTENTRY_IRQ_PIPELINED(func)			DEFINE_IDTENTRY_IRQ(func)
>  #define DEFINE_IDTENTRY_SYSVEC_PIPELINED(vector, func)		DEFINE_IDTENTRY_SYSVEC(func)
> +#define DEFINE_IDTENTRY_SYSVEC_PIPELINED_NORETURN(vector, func)	DEFINE_IDTENTRY_SYSVEC(func)
>  #define DEFINE_IDTENTRY_SYSVEC_SIMPLE_PIPELINED(vector, func)	DEFINE_IDTENTRY_SYSVEC_SIMPLE(func)
>  
>  /**
> -- 
> 2.44.0

Re: [PATCH dovetail] x86: irq_pipeline: Add missing definition for !CONFIG_IRQ_PIPELINE

[Philippe Gerum]

Florian Bezdeka <florian.bezdeka@siemens.com> writes:

> [To: Adding Philippe, the dovetail maintainer]
>
> To Fabian, Roman:
> Is that a drive-by fix or do you really have the IRQ pipelining
> disabled. If disabled: We should discuss this internally!
>
> To Philippe: Hope you can fetch the patch from the Xenomai list.
> Thanks!
>
> Best regards,
> Florian
>
> On Tue, 2024-04-23 at 12:41 +0200, Fabian Scheler wrote:
>> Fixup b917e98008314b3c7596099f48ea98f541451083 introducing
>> DEFINE_IDTENTRY_SYSVEC_PIPELINED_NORETURN only if CONFIG_IRQ_PIPELINE is
>> defined.
>> 
>> Reported-by: Roman Hodek <roman.hodek@siemens.com>
>> Signed-off-by: Roman Hodek <roman.hodek@siemens.com>
>> ---
>>  arch/x86/include/asm/idtentry.h | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h
>> index 9b936d3e76a2..307623b4e10e 100644
>> --- a/arch/x86/include/asm/idtentry.h
>> +++ b/arch/x86/include/asm/idtentry.h
>> @@ -230,6 +230,7 @@ __visible __noreturn void __##func(struct pt_regs *regs)
>>  
>>  #define DEFINE_IDTENTRY_IRQ_PIPELINED(func)			DEFINE_IDTENTRY_IRQ(func)
>>  #define DEFINE_IDTENTRY_SYSVEC_PIPELINED(vector, func)		DEFINE_IDTENTRY_SYSVEC(func)
>> +#define DEFINE_IDTENTRY_SYSVEC_PIPELINED_NORETURN(vector, func)	DEFINE_IDTENTRY_SYSVEC(func)
>>  #define DEFINE_IDTENTRY_SYSVEC_SIMPLE_PIPELINED(vector, func)	DEFINE_IDTENTRY_SYSVEC_SIMPLE(func)
>>  
>>  /**
>> -- 
>> 2.44.0

Merged, thanks.

-- 
Philippe.

AW: [PATCH dovetail] x86: irq_pipeline: Add missing definition for !CONFIG_IRQ_PIPELINE

[Hodek, Roman]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

Hi Florian!

> Is that a drive-by fix or do you really have the IRQ pipelining
> disabled. If disabled: We should discuss this internally!

I build the kernel in several config variants from the same source, and only 
one of them has CONFIG_IRQ_PIPELINE enabled.

Roman


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 14867 bytes --]

Re: [PATCH dovetail] x86: irq_pipeline: Add missing definition for !CONFIG_IRQ_PIPELINE

[Florian Bezdeka]

On Tue, 2024-04-23 at 14:59 +0200, Philippe Gerum wrote:
> Merged, thanks.

Don't know if that is important for you Philippe, but the patch was
missing a proper "From: " tag in the body.

Fabian is now the author, but the signed-off-by tag is from Roman (the
initial author).

Fabian, when re-sending patches (maybe because the original author has
no proper mail setup) make sure to add your signed-off-by and a "From:
" line as first line of the body.

git format-patch --from should do it.

Best regards,
Florian

> 
> -- 
> Philippe.

Re: [PATCH dovetail] x86: irq_pipeline: Add missing definition for !CONFIG_IRQ_PIPELINE

[Philippe Gerum]

Florian Bezdeka <florian.bezdeka@siemens.com> writes:

> On Tue, 2024-04-23 at 14:59 +0200, Philippe Gerum wrote:
>> Merged, thanks.
>
> Don't know if that is important for you Philippe, but the patch was
> missing a proper "From: " tag in the body.
>
> Fabian is now the author, but the signed-off-by tag is from Roman (the
> initial author).
>
> Fabian, when re-sending patches (maybe because the original author has
> no proper mail setup) make sure to add your signed-off-by and a "From:
> " line as first line of the body.
>
> git format-patch --from should do it.
>
> Best regards,
> Florian
>

Let's say that the signed-off-by tag is what matters the most to me
along with a source channel I can trust (in this case siemens.com), but
having a fully consistent information would be better, indeed.

-- 
Philippe.

(no subject)

[Fabian Scheler]

As suggested by Florian I revised the patch so that the correct author is stated in the commit.

Ciao
Fabian

[PATCH v2 dovetail] x86: irq_pipeline: Add missing definition for !CONFIG_IRQ_PIPELINE

[Fabian Scheler]

From: Roman Hodek <roman.hodek@siemens.com>

Fixup b917e98008314b3c7596099f48ea98f541451083 introducing
DEFINE_IDTENTRY_SYSVEC_PIPELINED_NORETURN only if CONFIG_IRQ_PIPELINE is
defined.

Reported-by: Roman Hodek <roman.hodek@siemens.com>
Signed-off-by: Roman Hodek <roman.hodek@siemens.com>
---
 arch/x86/include/asm/idtentry.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h
index 9b936d3e76a2..307623b4e10e 100644
--- a/arch/x86/include/asm/idtentry.h
+++ b/arch/x86/include/asm/idtentry.h
@@ -230,6 +230,7 @@ __visible __noreturn void __##func(struct pt_regs *regs)
 
 #define DEFINE_IDTENTRY_IRQ_PIPELINED(func)			DEFINE_IDTENTRY_IRQ(func)
 #define DEFINE_IDTENTRY_SYSVEC_PIPELINED(vector, func)		DEFINE_IDTENTRY_SYSVEC(func)
+#define DEFINE_IDTENTRY_SYSVEC_PIPELINED_NORETURN(vector, func)	DEFINE_IDTENTRY_SYSVEC(func)
 #define DEFINE_IDTENTRY_SYSVEC_SIMPLE_PIPELINED(vector, func)	DEFINE_IDTENTRY_SYSVEC_SIMPLE(func)
 
 /**
-- 
2.44.0

Re:

[Scheler, Fabian]

Am 24.04.2024 um 10:58 schrieb Fabian Scheler:
> 
> As suggested by Florian I revised the patch so that the correct author is stated in the commit.
> 
> Ciao
> Fabian

OK, something went wrong here - this simply is additional information 
for the revised patch.

Ciao
Fabian

-- 
With best regards,
Dr. Fabian Scheler

Siemens AG
T CED EDC-DE
Hertha-Sponer-Weg 3
91058 Erlangen, Germany
Phone: +49 (1522) 1702973
Mobile: +49 (1522) 1702973
mailto:fabian.scheler@siemens.com
www.siemens.com

Siemens Aktiengesellschaft: Chairman of the Supervisory Board: Jim 
Hagemann Snabe; Managing Board: Roland Busch, Chairman, President and 
Chief Executive Officer; Cedrik Neike, Matthias Rebellius, Ralf P. 
Thomas, Judith Wiese; Registered offices: Berlin and Munich, Germany; 
Commercial registries: Berlin-Charlottenburg, HRB 12300, Munich, HRB 
6684; WEEE-Reg.-No. DE 23691322