[Buildroot] [PATCH 1/1] package/libdrm: disable tests

[Buildroot] [PATCH 1/1] package/libdrm: disable tests

[Fabrice Fontaine]

Disable tests to avoid the following build failure with amdgpu and gcc 5
if cunit is built before libdrm:

In file included from ../tests/amdgpu/shader_test_util.c:10:0:
../tests/amdgpu/shader_code.h:113:2: error: initializer element is not constant
  ps_##_ps##_shader_patchinfo_code_size_gfx##_n, \
  ^

tests can be disabled since
https://gitlab.freedesktop.org/mesa/drm/-/commit/46d1e99a5d291b22d86ac52710b079491beedff8

Fixes:
 - http://autobuild.buildroot.org/results/612aad1fa642993da36bbec6c16c9020ac283e34

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libdrm/libdrm.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/libdrm/libdrm.mk b/package/libdrm/libdrm.mk
index 61d1c24377..a04331c2da 100644
--- a/package/libdrm/libdrm.mk
+++ b/package/libdrm/libdrm.mk
@@ -17,7 +17,8 @@ LIBDRM_DEPENDENCIES = \
 
 LIBDRM_CONF_OPTS = \
 	-Dcairo-tests=disabled \
-	-Dman-pages=disabled
+	-Dman-pages=disabled \
+	-Dtests=false
 
 ifeq ($(BR2_PACKAGE_LIBATOMIC_OPS),y)
 LIBDRM_DEPENDENCIES += libatomic_ops
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libdrm: disable tests

[Arnout Vandecappelle via buildroot]

On 22/03/2024 18:49, Fabrice Fontaine wrote:
> Disable tests to avoid the following build failure with amdgpu and gcc 5
> if cunit is built before libdrm:
> 
> In file included from ../tests/amdgpu/shader_test_util.c:10:0:
> ../tests/amdgpu/shader_code.h:113:2: error: initializer element is not constant
>    ps_##_ps##_shader_patchinfo_code_size_gfx##_n, \
>    ^
> 
> tests can be disabled since
> https://gitlab.freedesktop.org/mesa/drm/-/commit/46d1e99a5d291b22d86ac52710b079491beedff8
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/612aad1fa642993da36bbec6c16c9020ac283e34
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/libdrm/libdrm.mk | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libdrm/libdrm.mk b/package/libdrm/libdrm.mk
> index 61d1c24377..a04331c2da 100644
> --- a/package/libdrm/libdrm.mk
> +++ b/package/libdrm/libdrm.mk
> @@ -17,7 +17,8 @@ LIBDRM_DEPENDENCIES = \
>   
>   LIBDRM_CONF_OPTS = \
>   	-Dcairo-tests=disabled \
> -	-Dman-pages=disabled
> +	-Dman-pages=disabled \
> +	-Dtests=false
>   
>   ifeq ($(BR2_PACKAGE_LIBATOMIC_OPS),y)
>   LIBDRM_DEPENDENCIES += libatomic_ops
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libdrm: disable tests

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Disable tests to avoid the following build failure with amdgpu and gcc 5
 > if cunit is built before libdrm:

 > In file included from ../tests/amdgpu/shader_test_util.c:10:0:
 > ../tests/amdgpu/shader_code.h:113:2: error: initializer element is not constant
 >   ps_##_ps##_shader_patchinfo_code_size_gfx##_n, \
 >   ^

 > tests can be disabled since
 > https://gitlab.freedesktop.org/mesa/drm/-/commit/46d1e99a5d291b22d86ac52710b079491beedff8

 > Fixes:
 >  - http://autobuild.buildroot.org/results/612aad1fa642993da36bbec6c16c9020ac283e34

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2024.02.x, 2023.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libdrm: disable tests

[Peter Korsgaard]

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
 >> Disable tests to avoid the following build failure with amdgpu and gcc 5
 >> if cunit is built before libdrm:

 >> In file included from ../tests/amdgpu/shader_test_util.c:10:0:
 >> ../tests/amdgpu/shader_code.h:113:2: error: initializer element is not constant
 >> ps_##_ps##_shader_patchinfo_code_size_gfx##_n, \
 >> ^

 >> tests can be disabled since
 >> https://gitlab.freedesktop.org/mesa/drm/-/commit/46d1e99a5d291b22d86ac52710b079491beedff8

 >> Fixes:
 >> - http://autobuild.buildroot.org/results/612aad1fa642993da36bbec6c16c9020ac283e34

 >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

 > Committed to 2024.02.x, 2023.02.x and 2023.11.x, thanks.

Hmm, I think I was too fast here. The libdrm tests also include the
handy utilities like modetest and modeprint, so it is not great to
unconditionally disable them.

Maybe we should add a suboption for it? It is too late for 2024.02.1,
but I will revert the change for 2023.02.x and 2023.11.x so I can get
those released (and EOL'ed).

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libdrm: disable tests

[Bernd Kuhls]

Am Tue, 26 Mar 2024 16:01:40 +0100 schrieb Peter Korsgaard:

> Maybe we should add a suboption for it?

Hi Peter,

such an option already exists:
$ grep TESTS package/libdrm/Config.in 
config BR2_PACKAGE_LIBDRM_INSTALL_TESTS

To fix the problem with missing utils I sent this patch:
https://patchwork.ozlabs.org/project/buildroot/patch/
20240324174523.1770994-1-bernd@kuhls.net/

Regards, Bernd

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot