All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Adam Duskett <adam.duskett@amarulasolutions.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3 09/10] package/flutter-gallery: fix build options
Date: Sat, 03 Feb 2024 13:09:40 +0100	[thread overview]
Message-ID: <87sf29sq9n.fsf@48ers.dk> (raw)
In-Reply-To: <ZaxBhznBIS8hkxDE@landeda> (Yann E. MORIN's message of "Sat, 20 Jan 2024 22:56:23 +0100")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > ADam, All,
 > On 2024-01-17 15:50 -0700, Adam Duskett spake thusly:
 >> As the flutter-gallery package is a reference package for users wishing to use
 >> Flutter for their UX with Buildroot, this package must have the correct build
 >> options. Indeed, this package currently starts and runs, but only because of
 >> the 0001-remove-GetStorage.patch. Through testing, flutter-gallery fails to
 >> run during the following scenario:
 >> - The xdg-user-dirs package is ported and present.
 >> - flutter-gallery depends on xdg-user-dirs.
 >> - The 0001-remove-GetStorage.patch file is removed.
 >> 
 >> After extensive testing and comparing the current build arguments against what
 >> the meta-flutter repository for Yocto passes to all of the applications that
 >> inherit flutter-app, it is clear that handling the dart_plugin_registrant.dart
 >> file is missing from the dart arguments in the flutter-gallery build step.
 > [--SNIP--]

 > Great commit log! This is exactly the kind of commit log that gives
 > confidence in the patch, as it demonstrates that the topic has been
 > researched, and the solution is explained, and the drawbacks identified
 > and justified.

 > I did not understand all the details of it, but the commit log really
 > helped me just apply the commit wihtout too much thought.

 > Thank you! 👍

Committed to 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-02-03 18:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-17 22:50 [Buildroot] [PATCH v3 00/10] more flutter package improvements Adam Duskett
2024-01-17 22:50 ` [Buildroot] [PATCH v3 01/10] package/ivi-homescreen: add standard_method_codec.h to keyboard manager plugin Adam Duskett
2024-01-17 22:50 ` [Buildroot] [PATCH v3 02/10] package/depot-tools: bump version to 8d14454ba4a35fd9d2483842b08815a2357ec86f Adam Duskett
2024-01-20 21:45   ` Yann E. MORIN
2024-02-03 11:27     ` Peter Korsgaard
2024-01-17 22:50 ` [Buildroot] [PATCH v3 03/10] package/flutter-engine/Config.in: Drop nptl dependency Adam Duskett
2024-01-17 22:50 ` [Buildroot] [PATCH v3 04/10] package/flutter-sdk-bin: bump version to 3.16.8 Adam Duskett
2024-01-17 22:50 ` [Buildroot] [PATCH v3 05/10] package/flutter-engine: " Adam Duskett
2024-01-17 22:50 ` [Buildroot] [PATCH v3 06/10] package/flutter-pi: bump version to 75e72fef8e8ce65ec72a002c00d9c6db4d1479d3 Adam Duskett
2024-01-17 22:50 ` [Buildroot] [PATCH v3 07/10] package/flutter-pi/Config.in: propagate flutter-engine dependencies Adam Duskett
2024-01-20 22:56   ` Yann E. MORIN
2024-01-17 22:50 ` [Buildroot] [PATCH v3 08/10] package/flutter-gallery: add a configure step Adam Duskett
2024-01-20 21:46   ` Yann E. MORIN
2024-02-03 12:09     ` Peter Korsgaard
2024-01-17 22:50 ` [Buildroot] [PATCH v3 09/10] package/flutter-gallery: fix build options Adam Duskett
2024-01-20 21:56   ` Yann E. MORIN
2024-02-03 12:09     ` Peter Korsgaard [this message]
2024-01-17 22:50 ` [Buildroot] [PATCH v3 10/10] package/flutter-gallery: clean up install_target_cmds Adam Duskett
2024-01-20 21:59   ` Yann E. MORIN
2024-02-03 12:09     ` Peter Korsgaard
2024-01-20 21:43 ` [Buildroot] [PATCH v3 00/10] more flutter package improvements Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf29sq9n.fsf@48ers.dk \
    --to=peter@korsgaard.com \
    --cc=adam.duskett@amarulasolutions.com \
    --cc=buildroot@buildroot.org \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.