All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Adam Duskett <adam.duskett@amarulasolutions.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3 08/10] package/flutter-gallery: add a configure step
Date: Sat, 03 Feb 2024 13:09:23 +0100	[thread overview]
Message-ID: <87wmrlsqa4.fsf@48ers.dk> (raw)
In-Reply-To: <Zaw_PDsLArK-KQj-@landeda> (Yann E. MORIN's message of "Sat, 20 Jan 2024 22:46:36 +0100")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Adam, All,
 > On 2024-01-17 15:50 -0700, Adam Duskett spake thusly:
 >> To make the next patch easier to understand, add a configure step to the
 >> flutter-gallery.mk file. The `$(HOST_FLUTTER_SDK_BIN_FLUTTER) build bundle`
 >> command is placed in the configure step because it generates several files
 >> needed for the flutter_gen_snapshot tool to generate the target .so file.
 >> 
 >> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
 >> ---
 >> package/flutter-gallery/flutter-gallery.mk | 11 ++++++++---
 >> 1 file changed, 8 insertions(+), 3 deletions(-)
 >> 
 >> diff --git a/package/flutter-gallery/flutter-gallery.mk b/package/flutter-gallery/flutter-gallery.mk
 >> index 57a476b1ab..50ddd9ffba 100644
 >> --- a/package/flutter-gallery/flutter-gallery.mk
 >> +++ b/package/flutter-gallery/flutter-gallery.mk
 >> @@ -14,12 +14,17 @@ FLUTTER_GALLERY_DEPENDENCIES = \
 >> 
 >> FLUTTER_GALLERY_INSTALL_DIR = $(TARGET_DIR)/usr/share/flutter/gallery/$(FLUTTER_ENGINE_RUNTIME_MODE)
 >> 
 >> -define FLUTTER_GALLERY_BUILD_CMDS
 >> +define FLUTTER_GALLERY_CONFIGURE_CMDS
 >> cd $(@D) && \
 >> FLUTTER_RUNTIME_MODES=$(FLUTTER_ENGINE_RUNTIME_MODE) \
 >> $(HOST_FLUTTER_SDK_BIN_FLUTTER) clean && \
 >> -		$(HOST_FLUTTER_SDK_BIN_FLUTTER) packages get && \
 >> +		$(HOST_FLUTTER_SDK_BIN_FLUTTER) pub get && \

 > As disucssed on IRC< that belonged to a spearate patch, so I split this
 > patch int two, and applied to master, thanks.

Committed to 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-02-03 18:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-17 22:50 [Buildroot] [PATCH v3 00/10] more flutter package improvements Adam Duskett
2024-01-17 22:50 ` [Buildroot] [PATCH v3 01/10] package/ivi-homescreen: add standard_method_codec.h to keyboard manager plugin Adam Duskett
2024-01-17 22:50 ` [Buildroot] [PATCH v3 02/10] package/depot-tools: bump version to 8d14454ba4a35fd9d2483842b08815a2357ec86f Adam Duskett
2024-01-20 21:45   ` Yann E. MORIN
2024-02-03 11:27     ` Peter Korsgaard
2024-01-17 22:50 ` [Buildroot] [PATCH v3 03/10] package/flutter-engine/Config.in: Drop nptl dependency Adam Duskett
2024-01-17 22:50 ` [Buildroot] [PATCH v3 04/10] package/flutter-sdk-bin: bump version to 3.16.8 Adam Duskett
2024-01-17 22:50 ` [Buildroot] [PATCH v3 05/10] package/flutter-engine: " Adam Duskett
2024-01-17 22:50 ` [Buildroot] [PATCH v3 06/10] package/flutter-pi: bump version to 75e72fef8e8ce65ec72a002c00d9c6db4d1479d3 Adam Duskett
2024-01-17 22:50 ` [Buildroot] [PATCH v3 07/10] package/flutter-pi/Config.in: propagate flutter-engine dependencies Adam Duskett
2024-01-20 22:56   ` Yann E. MORIN
2024-01-17 22:50 ` [Buildroot] [PATCH v3 08/10] package/flutter-gallery: add a configure step Adam Duskett
2024-01-20 21:46   ` Yann E. MORIN
2024-02-03 12:09     ` Peter Korsgaard [this message]
2024-01-17 22:50 ` [Buildroot] [PATCH v3 09/10] package/flutter-gallery: fix build options Adam Duskett
2024-01-20 21:56   ` Yann E. MORIN
2024-02-03 12:09     ` Peter Korsgaard
2024-01-17 22:50 ` [Buildroot] [PATCH v3 10/10] package/flutter-gallery: clean up install_target_cmds Adam Duskett
2024-01-20 21:59   ` Yann E. MORIN
2024-02-03 12:09     ` Peter Korsgaard
2024-01-20 21:43 ` [Buildroot] [PATCH v3 00/10] more flutter package improvements Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmrlsqa4.fsf@48ers.dk \
    --to=peter@korsgaard.com \
    --cc=adam.duskett@amarulasolutions.com \
    --cc=buildroot@buildroot.org \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.