From: Michael Ellerman <mpe@ellerman.id.au>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
"Daniel Walker (danielwa)" <danielwa@cisco.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
david@redhat.com
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"David Beazley \(dbeazley\)" <dbeazley@cisco.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"xe-linux-external\(mailer list\)" <xe-linux-external@cisco.com>
Subject: Re: mm/debug_vm_pgtable.c:860 warning triggered
Date: Mon, 06 Nov 2023 17:06:46 +1100 [thread overview]
Message-ID: <87sf5jqutl.fsf@mail.lhotse> (raw)
In-Reply-To: <dc5a1072-0c2b-4f49-8a5f-de3dcfb8c06e@arm.com>
Anshuman Khandual <anshuman.khandual@arm.com> writes:
> Hello Daniel,
>
> This test just ensures that PFN is preserved during pte <--> swap pte transformations
> , and the warning here seems to have been caused by powerpc platform specific helpers
> and/or its pte_t representation. Adding powerpc folks and platform mailing list here.
Doesn't the test need a similar treatment to:
2321ba3e3733 ("mm/debug_vm_pgtable: more pte_swp_exclusive() sanity checks")
Which said:
Especially, the pfn_pte() is dodgy when the swap PTE layout differs
heavily from ordinary PTEs. Let's properly construct a swap PTE from swap
type+offset.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
"Daniel Walker (danielwa)" <danielwa@cisco.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
david@redhat.com
Cc: "David Beazley (dbeazley)" <dbeazley@cisco.com>,
"xe-linux-external(mailer list)" <xe-linux-external@cisco.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: mm/debug_vm_pgtable.c:860 warning triggered
Date: Mon, 06 Nov 2023 17:06:46 +1100 [thread overview]
Message-ID: <87sf5jqutl.fsf@mail.lhotse> (raw)
In-Reply-To: <dc5a1072-0c2b-4f49-8a5f-de3dcfb8c06e@arm.com>
Anshuman Khandual <anshuman.khandual@arm.com> writes:
> Hello Daniel,
>
> This test just ensures that PFN is preserved during pte <--> swap pte transformations
> , and the warning here seems to have been caused by powerpc platform specific helpers
> and/or its pte_t representation. Adding powerpc folks and platform mailing list here.
Doesn't the test need a similar treatment to:
2321ba3e3733 ("mm/debug_vm_pgtable: more pte_swp_exclusive() sanity checks")
Which said:
Especially, the pfn_pte() is dodgy when the swap PTE layout differs
heavily from ordinary PTEs. Let's properly construct a swap PTE from swap
type+offset.
cheers
next prev parent reply other threads:[~2023-11-06 6:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 23:12 mm/debug_vm_pgtable.c:860 warning triggered Daniel Walker (danielwa)
2023-11-06 3:09 ` Anshuman Khandual
2023-11-06 3:09 ` Anshuman Khandual
2023-11-06 3:22 ` Daniel Walker (danielwa)
2023-11-06 3:22 ` Daniel Walker (danielwa)
2023-11-06 6:06 ` Michael Ellerman [this message]
2023-11-06 6:06 ` Michael Ellerman
2023-11-06 9:06 ` David Hildenbrand
2023-11-06 9:06 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sf5jqutl.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=aneesh.kumar@linux.ibm.com \
--cc=anshuman.khandual@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=danielwa@cisco.com \
--cc=david@redhat.com \
--cc=dbeazley@cisco.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.