From: Jani Nikula <jani.nikula@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove unused for_each_uabi_class_engine
Date: Wed, 01 Nov 2023 12:06:42 +0200 [thread overview]
Message-ID: <87sf5p4wjx.fsf@intel.com> (raw)
In-Reply-To: <20231101100124.303739-1-tvrtko.ursulin@linux.intel.com>
On Wed, 01 Nov 2023, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Unused macro after 99919be74aa3 ("drm/i915/gem: Zap the i915_gem_object_blt code")
> removed some code.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
\o/
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Could I persuade you to move for_each_engine(),
for_each_engine_masked(), rb_to_uabi_engine(), and
for_each_uabi_engine() to a more suitable header?
> ---
> drivers/gpu/drm/i915/i915_drv.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index bfcbe93bd9fe..744c8c4a50fa 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -418,11 +418,6 @@ static inline struct intel_gt *to_gt(const struct drm_i915_private *i915)
> (engine__); \
> (engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))
>
> -#define for_each_uabi_class_engine(engine__, class__, i915__) \
> - for ((engine__) = intel_engine_lookup_user((i915__), (class__), 0); \
> - (engine__) && (engine__)->uabi_class == (class__); \
> - (engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))
> -
> #define INTEL_INFO(i915) ((i915)->__info)
> #define RUNTIME_INFO(i915) (&(i915)->__runtime)
> #define DRIVER_CAPS(i915) (&(i915)->caps)
--
Jani Nikula, Intel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [PATCH] drm/i915: Remove unused for_each_uabi_class_engine
Date: Wed, 01 Nov 2023 12:06:42 +0200 [thread overview]
Message-ID: <87sf5p4wjx.fsf@intel.com> (raw)
In-Reply-To: <20231101100124.303739-1-tvrtko.ursulin@linux.intel.com>
On Wed, 01 Nov 2023, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Unused macro after 99919be74aa3 ("drm/i915/gem: Zap the i915_gem_object_blt code")
> removed some code.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
\o/
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Could I persuade you to move for_each_engine(),
for_each_engine_masked(), rb_to_uabi_engine(), and
for_each_uabi_engine() to a more suitable header?
> ---
> drivers/gpu/drm/i915/i915_drv.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index bfcbe93bd9fe..744c8c4a50fa 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -418,11 +418,6 @@ static inline struct intel_gt *to_gt(const struct drm_i915_private *i915)
> (engine__); \
> (engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))
>
> -#define for_each_uabi_class_engine(engine__, class__, i915__) \
> - for ((engine__) = intel_engine_lookup_user((i915__), (class__), 0); \
> - (engine__) && (engine__)->uabi_class == (class__); \
> - (engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))
> -
> #define INTEL_INFO(i915) ((i915)->__info)
> #define RUNTIME_INFO(i915) (&(i915)->__runtime)
> #define DRIVER_CAPS(i915) (&(i915)->caps)
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-11-01 10:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 10:01 [Intel-gfx] [PATCH] drm/i915: Remove unused for_each_uabi_class_engine Tvrtko Ursulin
2023-11-01 10:01 ` Tvrtko Ursulin
2023-11-01 10:06 ` Jani Nikula [this message]
2023-11-01 10:06 ` Jani Nikula
2023-11-01 14:23 ` [Intel-gfx] " Tvrtko Ursulin
2023-11-01 14:23 ` Tvrtko Ursulin
2023-11-02 9:24 ` [Intel-gfx] " Jani Nikula
2023-11-02 9:24 ` Jani Nikula
2023-11-02 9:39 ` [Intel-gfx] " Tvrtko Ursulin
2023-11-02 9:39 ` Tvrtko Ursulin
2023-11-01 10:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-11-01 10:53 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-11-01 11:06 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-11-01 15:54 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Remove unused for_each_uabi_class_engine (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sf5p4wjx.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.