All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Ganesh Babu Jothiram <quic_gjothira@quicinc.com>
Cc: <ath11k@lists.infradead.org>,  <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath11k: Configure the FTM responder role using firmware capability flag
Date: Fri, 24 Mar 2023 17:03:56 +0200	[thread overview]
Message-ID: <87sfduchsz.fsf@kernel.org> (raw)
In-Reply-To: <20230317072034.8217-1-quic_gjothira@quicinc.com> (Ganesh Babu Jothiram's message of "Fri, 17 Mar 2023 12:50:34 +0530")

Ganesh Babu Jothiram <quic_gjothira@quicinc.com> writes:

> Fine Time Measurement(FTM) is offloaded feature to firmware.
> Hence, the configuration of FTM responder role is done using
> firmware capability flag instead of hw param.
>
> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Ganesh Babu Jothiram <quic_gjothira@quicinc.com>

[...]

> --- a/drivers/net/wireless/ath/ath11k/mac.c
> +++ b/drivers/net/wireless/ath/ath11k/mac.c
> @@ -3538,7 +3538,7 @@ static void ath11k_mac_op_bss_info_changed(struct ieee80211_hw *hw,
>  
>  	if (changed & BSS_CHANGED_FTM_RESPONDER &&
>  	    arvif->ftm_responder != info->ftm_responder &&
> -	    ar->ab->hw_params.ftm_responder &&
> +	    (test_bit(WMI_TLV_SERVICE_RTT, ar->ab->wmi_ab.svc_map)) &&

Unnecessary parenthesis, I fixed that in the pending branch.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Ganesh Babu Jothiram <quic_gjothira@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath11k: Configure the FTM responder role using firmware capability flag
Date: Fri, 24 Mar 2023 17:03:56 +0200	[thread overview]
Message-ID: <87sfduchsz.fsf@kernel.org> (raw)
In-Reply-To: <20230317072034.8217-1-quic_gjothira@quicinc.com> (Ganesh Babu Jothiram's message of "Fri, 17 Mar 2023 12:50:34 +0530")

Ganesh Babu Jothiram <quic_gjothira@quicinc.com> writes:

> Fine Time Measurement(FTM) is offloaded feature to firmware.
> Hence, the configuration of FTM responder role is done using
> firmware capability flag instead of hw param.
>
> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Ganesh Babu Jothiram <quic_gjothira@quicinc.com>

[...]

> --- a/drivers/net/wireless/ath/ath11k/mac.c
> +++ b/drivers/net/wireless/ath/ath11k/mac.c
> @@ -3538,7 +3538,7 @@ static void ath11k_mac_op_bss_info_changed(struct ieee80211_hw *hw,
>  
>  	if (changed & BSS_CHANGED_FTM_RESPONDER &&
>  	    arvif->ftm_responder != info->ftm_responder &&
> -	    ar->ab->hw_params.ftm_responder &&
> +	    (test_bit(WMI_TLV_SERVICE_RTT, ar->ab->wmi_ab.svc_map)) &&

Unnecessary parenthesis, I fixed that in the pending branch.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2023-03-24 15:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17  7:20 [PATCH] wifi: ath11k: Configure the FTM responder role using firmware capability flag Ganesh Babu Jothiram
2023-03-17  7:20 ` Ganesh Babu Jothiram
2023-03-24 15:03 ` Kalle Valo [this message]
2023-03-24 15:03   ` Kalle Valo
2023-04-12  9:58 ` Kalle Valo
2023-04-12  9:58   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfduchsz.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_gjothira@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.