From: Markus Armbruster <armbru@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com, marcel.apfelbaum@gmail.com
Subject: Re: [PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI
Date: Mon, 28 Nov 2022 14:38:42 +0100 [thread overview]
Message-ID: <87sfi3p5b1.fsf@pond.sub.org> (raw)
In-Reply-To: <Y4Sol9q0NI52iTmE@work-vm> (David Alan Gilbert's message of "Mon, 28 Nov 2022 12:24:55 +0000")
"Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:
> * Markus Armbruster (armbru@redhat.com) wrote:
>> We compile pci-hmp-cmds.c always, but pci-qmp-cmds.c only when
>> CONFIG_PCI. hw/pci/pci-stub.c keeps the linker happy when
>> !CONFIG_PCI. Build pci-hmp-cmds.c that way, too.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Had you considered wrapping the hmp-commands-info.hx entry
> with a #if defined instead?
No. Would you prefer that?
Code containing #ifdef CONFIG_PCI is target-dependent. Looks like the
affected monitor code already is, so no new headaches.
Aside: splitting off its target-independent parts could be nice. Not
today.
[...]
next prev parent reply other threads:[~2022-11-28 13:39 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 8:01 [PATCH 00/12] pci: Move and clean up monitor command code Markus Armbruster
2022-11-28 8:01 ` [PATCH 01/12] pci: Clean up a few things checkpatch.pl would flag later on Markus Armbruster
2022-11-28 8:27 ` Philippe Mathieu-Daudé
2022-11-28 8:01 ` [PATCH 02/12] pci: Move QMP commands to new hw/pci/pci-qmp-cmds.c Markus Armbruster
2022-11-28 8:01 ` [PATCH 03/12] pci: Move HMP commands from monitor/ to new hw/pci/pci-hmp-cmds.c Markus Armbruster
2022-11-28 8:27 ` Philippe Mathieu-Daudé
2022-11-28 12:09 ` Dr. David Alan Gilbert
2022-11-28 8:01 ` [PATCH 04/12] pci: Make query-pci stub consistent with the real one Markus Armbruster
2022-11-29 12:03 ` Dr. David Alan Gilbert
2022-11-28 8:01 ` [PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI Markus Armbruster
2022-11-28 8:26 ` Philippe Mathieu-Daudé
2022-11-28 10:21 ` Markus Armbruster
2022-11-28 10:26 ` Michael S. Tsirkin
2022-11-28 12:24 ` Dr. David Alan Gilbert
2022-11-28 13:38 ` Markus Armbruster [this message]
2022-11-28 14:27 ` Dr. David Alan Gilbert
2022-11-28 8:01 ` [PATCH 06/12] pci: Deduplicate get_class_desc() Markus Armbruster
2022-11-28 8:01 ` [PATCH 07/12] pci: Move pcibus_dev_print() to pci-hmp-cmds.c Markus Armbruster
2022-11-28 8:24 ` Philippe Mathieu-Daudé
2022-11-28 8:01 ` [PATCH 08/12] pci: Fix silent truncation of pcie_aer_inject_error argument Markus Armbruster
2022-11-29 12:14 ` Dr. David Alan Gilbert
2022-11-30 18:40 ` Markus Armbruster
2022-11-28 8:01 ` [PATCH 09/12] pci: Move HMP command from hw/pci/pcie_aer.c to pci-hmp-cmds.c Markus Armbruster
2022-11-28 8:21 ` Philippe Mathieu-Daudé
2022-11-28 11:50 ` Markus Armbruster
2022-11-28 8:02 ` [PATCH 10/12] pci: Inline do_pcie_aer_inject_error() into its only caller Markus Armbruster
2022-11-29 19:59 ` Dr. David Alan Gilbert
2022-11-28 8:02 ` [PATCH 11/12] pci: Rename hmp_pcie_aer_inject_error()'s local variable @err Markus Armbruster
2022-11-28 8:21 ` Philippe Mathieu-Daudé
2022-11-28 8:02 ` [PATCH 12/12] pci: Improve do_pcie_aer_inject_error()'s error messages Markus Armbruster
2022-11-29 19:42 ` Dr. David Alan Gilbert
2022-11-28 9:25 ` [PATCH 00/12] pci: Move and clean up monitor command code Michael S. Tsirkin
2022-11-28 11:52 ` Markus Armbruster
2022-11-28 10:27 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfi3p5b1.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.