Re: [PATCH v2 09/28] qapi char: Elide redundant has_FOO in generated C

[Markus Armbruster <armbru@redhat.com>]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> On 18/10/22 08:28, Markus Armbruster wrote:
>> The has_FOO for pointer-valued FOO are redundant, except for arrays.
>> They are also a nuisance to work with.  Recent commit "qapi: Start to
>> elide redundant has_FOO in generated C" provided the means to elide
>> them step by step.  This is the step for qapi/char.json.
>> Said commit explains the transformation in more detail.  The invariant
>> violations mentioned there do not occur here.
>> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>> ---
>>   chardev/char-file.c    |  4 ++--
>>   chardev/char-socket.c  | 10 ++++------
>>   chardev/char-udp.c     |  1 -
>>   chardev/char.c         |  6 +-----
>>   tests/unit/test-char.c |  1 -
>>   scripts/qapi/schema.py |  1 -
>>   6 files changed, 7 insertions(+), 16 deletions(-)
>
> Eventually s/char/chardev/ in subject.

ACK

> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thanks!