All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Quentin Schulz <foss+buildroot@0leil.net>
Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>,
	yann.morin.1998@free.fr, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] Makefile: error out printvars target when VARS is empty or unset
Date: Wed, 14 Sep 2022 11:29:37 +0200	[thread overview]
Message-ID: <87sfkuqp6m.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220802123559.2514433-1-foss+buildroot@0leil.net> (Quentin Schulz's message of "Tue, 2 Aug 2022 14:35:59 +0200")

>>>>> "Quentin" == Quentin Schulz <foss+buildroot@0leil.net> writes:

 > From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
 > printvars returns nothing when VARS is not passed or empty. This is done
 > on purpose, see commit fd5bd12379dc ("Makefile: printvars: don't print
 > anything when VARS is not set").

 > An error message making explicit what is required from the user in order
 > to use printvars is however better than silently doing nothing.

 > This adds a check for a non-empty VARS variable.

 > Cc: Quentin Schulz <foss+buildroot@0leil.net>
 > Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-09-14  9:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02 12:35 [Buildroot] [PATCH] Makefile: error out printvars target when VARS is empty or unset Quentin Schulz
2022-08-03 17:07 ` Yann E. MORIN
2022-09-14  9:29 ` Peter Korsgaard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-09-12  9:55 [Buildroot] [PATCH 0/5] add support for libedit and linenoise CLI implementations for nftables Quentin Schulz
2022-09-12  9:55 ` [Buildroot] [PATCH] Makefile: error out printvars target when VARS is empty or unset Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfkuqp6m.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=foss+buildroot@0leil.net \
    --cc=quentin.schulz@theobroma-systems.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.