All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: alsa-devel@alsa-project.org, Zheyu Ma <zheyuma97@gmail.com>,
	kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ALSA: control: Re-order bounds checking in get_ctl_id_hash()
Date: Fri, 26 Aug 2022 17:17:47 +0200	[thread overview]
Message-ID: <87sfljjap0.wl-tiwai@suse.de> (raw)
In-Reply-To: <YwjgNh/gkG1hH7po@kili>

On Fri, 26 Aug 2022 17:01:10 +0200,
Dan Carpenter wrote:
> 
> These two checks are in the reverse order so it might read one element
> beyond the end of the array.  First check if the "i" is within bounds
> before using it.
> 
> Fixes: 6ab55ec0a938 ("ALSA: control: Fix an out-of-bounds bug in get_ctl_id_hash()")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied.


Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Zheyu Ma <zheyuma97@gmail.com>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ALSA: control: Re-order bounds checking in get_ctl_id_hash()
Date: Fri, 26 Aug 2022 17:17:47 +0200	[thread overview]
Message-ID: <87sfljjap0.wl-tiwai@suse.de> (raw)
In-Reply-To: <YwjgNh/gkG1hH7po@kili>

On Fri, 26 Aug 2022 17:01:10 +0200,
Dan Carpenter wrote:
> 
> These two checks are in the reverse order so it might read one element
> beyond the end of the array.  First check if the "i" is within bounds
> before using it.
> 
> Fixes: 6ab55ec0a938 ("ALSA: control: Fix an out-of-bounds bug in get_ctl_id_hash()")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied.


Takashi

  reply	other threads:[~2022-08-26 15:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-26 15:01 [PATCH] ALSA: control: Re-order bounds checking in get_ctl_id_hash() Dan Carpenter
2022-08-26 15:01 ` Dan Carpenter
2022-08-26 15:17 ` Takashi Iwai [this message]
2022-08-26 15:17   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfljjap0.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=zheyuma97@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.