All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/dp/mst: Read the extended DPCD capabilities during system resume
@ 2022-06-14  9:45 ` Imre Deak
  0 siblings, 0 replies; 21+ messages in thread
From: Imre Deak @ 2022-06-14  9:45 UTC (permalink / raw)
  To: dri-devel; +Cc: intel-gfx

The WD22TB4 Thunderbolt dock at least will revert its DP_MAX_LINK_RATE
from HBR3 to HBR2 after system suspend/resume if the DP_DP13_DPCD_REV
registers are not read subsequently also as required.

Fix this by reading DP_DP13_DPCD_REV registers as well, matching what is
done during connector detection. While at it also fix up the same call
in drm_dp_mst_dump_topology().

Cc: Lyude Paul <lyude@redhat.com>
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5292
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/display/drm_dp_mst_topology.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
index 67b3b9697da7f..18f2b6075b780 100644
--- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
@@ -3860,9 +3860,7 @@ int drm_dp_mst_topology_mgr_resume(struct drm_dp_mst_topology_mgr *mgr,
 	if (!mgr->mst_primary)
 		goto out_fail;
 
-	ret = drm_dp_dpcd_read(mgr->aux, DP_DPCD_REV, mgr->dpcd,
-			       DP_RECEIVER_CAP_SIZE);
-	if (ret != DP_RECEIVER_CAP_SIZE) {
+	if (drm_dp_read_dpcd_caps(mgr->aux, mgr->dpcd) < 0) {
 		drm_dbg_kms(mgr->dev, "dpcd read failed - undocked during suspend?\n");
 		goto out_fail;
 	}
@@ -4911,8 +4909,7 @@ void drm_dp_mst_dump_topology(struct seq_file *m,
 		u8 buf[DP_PAYLOAD_TABLE_SIZE];
 		int ret;
 
-		ret = drm_dp_dpcd_read(mgr->aux, DP_DPCD_REV, buf, DP_RECEIVER_CAP_SIZE);
-		if (ret) {
+		if (drm_dp_read_dpcd_caps(mgr->aux, buf) < 0) {
 			seq_printf(m, "dpcd read failed\n");
 			goto out;
 		}
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2022-06-16 20:40 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-14  9:45 [Intel-gfx] [PATCH] drm/dp/mst: Read the extended DPCD capabilities during system resume Imre Deak
2022-06-14  9:45 ` Imre Deak
2022-06-14 12:32 ` [Intel-gfx] " Jani Nikula
2022-06-14 12:32   ` Jani Nikula
2022-06-14 12:34   ` [Intel-gfx] " Jani Nikula
2022-06-14 12:34     ` Jani Nikula
2022-06-14 12:58   ` [Intel-gfx] " Imre Deak
2022-06-14 12:58     ` Imre Deak
2022-06-14 14:03     ` [Intel-gfx] " Jani Nikula
2022-06-14 14:03       ` Jani Nikula
2022-06-14 14:06 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-06-15  4:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-06-16 18:57   ` Imre Deak
2022-06-16 18:57     ` Imre Deak
2022-06-16 19:01     ` [Intel-gfx] " Imre Deak
2022-06-16 19:01       ` Imre Deak
2022-06-16 20:33     ` [Intel-gfx] " Vudum, Lakshminarayana
2022-06-16 20:33       ` Vudum, Lakshminarayana
2022-06-15 20:26 ` [Intel-gfx] [PATCH] " Lyude Paul
2022-06-15 20:26   ` Lyude Paul
2022-06-16 20:40 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.