All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Laurent Vivier <lvivier@redhat.com>, linux-kernel@vger.kernel.org
Cc: linux-block@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
	linux-pci@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
	linuxppc-dev@lists.ozlabs.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Greg Kurz <groug@kaod.org>, Christoph Hellwig <hch@lst.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Laurent Vivier <lvivier@redhat.com>
Subject: Re: [PATCH v2 1/2] genirq: add an irq_create_mapping_affinity() function
Date: Wed, 25 Nov 2020 14:20:21 +0100	[thread overview]
Message-ID: <87sg8xk1yi.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20201125111657.1141295-2-lvivier@redhat.com>

Laurent,

On Wed, Nov 25 2020 at 12:16, Laurent Vivier wrote:

The proper subsystem prefix is: 'genirq/irqdomain:' and the first letter
after the colon wants to be uppercase.

> This function adds an affinity parameter to irq_create_mapping().
> This parameter is needed to pass it to irq_domain_alloc_descs().

A changelog has to explain the WHY. 'The parameter is needed' is not
really useful information.

Thanks,

        tglx


WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Laurent Vivier <lvivier@redhat.com>, linux-kernel@vger.kernel.org
Cc: Laurent Vivier <lvivier@redhat.com>,
	Marc Zyngier <maz@kernel.org>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	linux-pci@vger.kernel.org, Greg Kurz <groug@kaod.org>,
	linux-block@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 1/2] genirq: add an irq_create_mapping_affinity() function
Date: Wed, 25 Nov 2020 14:20:21 +0100	[thread overview]
Message-ID: <87sg8xk1yi.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20201125111657.1141295-2-lvivier@redhat.com>

Laurent,

On Wed, Nov 25 2020 at 12:16, Laurent Vivier wrote:

The proper subsystem prefix is: 'genirq/irqdomain:' and the first letter
after the colon wants to be uppercase.

> This function adds an affinity parameter to irq_create_mapping().
> This parameter is needed to pass it to irq_domain_alloc_descs().

A changelog has to explain the WHY. 'The parameter is needed' is not
really useful information.

Thanks,

        tglx


  parent reply	other threads:[~2020-11-25 13:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 11:16 [PATCH v2 0/2] powerpc/pseries: fix MSI/X IRQ affinity on pseries Laurent Vivier
2020-11-25 11:16 ` Laurent Vivier
2020-11-25 11:16 ` [PATCH v2 1/2] genirq: add an irq_create_mapping_affinity() function Laurent Vivier
2020-11-25 11:16   ` Laurent Vivier
2020-11-25 12:45   ` Greg Kurz
2020-11-25 12:45     ` Greg Kurz
2020-11-25 13:20   ` Thomas Gleixner [this message]
2020-11-25 13:20     ` Thomas Gleixner
2020-11-25 14:09     ` Laurent Vivier
2020-11-25 14:09       ` Laurent Vivier
2020-11-25 14:54       ` Marc Zyngier
2020-11-25 14:54         ` Marc Zyngier
2020-11-25 15:00         ` Laurent Vivier
2020-11-25 15:00           ` Laurent Vivier
2020-11-25 11:16 ` [PATCH v2 2/2] powerpc/pseries: pass MSI affinity to irq_create_mapping() Laurent Vivier
2020-11-25 11:16   ` Laurent Vivier
2020-11-25 12:51   ` Greg Kurz
2020-11-25 12:51     ` Greg Kurz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg8xk1yi.fsf@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=benh@kernel.crashing.org \
    --cc=groug@kaod.org \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lvivier@redhat.com \
    --cc=maz@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=mst@redhat.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.