All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam
@ 2020-04-13 21:44 ` Lyude Paul
  0 siblings, 0 replies; 11+ messages in thread
From: Lyude Paul @ 2020-04-13 21:44 UTC (permalink / raw)
  To: intel-gfx
  Cc: Juha-Pekka Heikkila, David Airlie, linux-kernel, Chris Wilson,
	dri-devel, Rodrigo Vivi, Lee Shawn C

Looks like I accidentally made it so you couldn't force DPCD backlight
support on, whoops. Fix that.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Fixes: 17f5d57915be ("drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel")
Cc: Adam Jackson <ajax@redhat.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index 4b916468540f..0722540d64ad 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -358,6 +358,7 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
 	 */
 	if (i915->vbt.backlight.type !=
 	    INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE &&
+	    i915_modparams.enable_dpcd_backlight != 1 &&
 	    !drm_dp_has_quirk(&intel_dp->desc, intel_dp->edid_quirks,
 			      DP_QUIRK_FORCE_DPCD_BACKLIGHT)) {
 		drm_info(&i915->drm,
-- 
2.25.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2020-04-20 10:28 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-13 21:44 [PATCH] drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam Lyude Paul
2020-04-13 21:44 ` Lyude Paul
2020-04-13 21:44 ` [Intel-gfx] " Lyude Paul
2020-04-14 22:27 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2020-04-14 22:34 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-04-16 17:15 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam (rev2) Patchwork
2020-04-16 17:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-17 16:42 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-04-20 10:28 ` [PATCH] drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam Jani Nikula
2020-04-20 10:28   ` Jani Nikula
2020-04-20 10:28   ` [Intel-gfx] " Jani Nikula

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.