* [PATCH] drm/i915/gt: Try an extra flush on the Haswell blitter @ 2019-11-11 12:09 ` Chris Wilson 0 siblings, 0 replies; 10+ messages in thread From: Chris Wilson @ 2019-11-11 12:09 UTC (permalink / raw) To: intel-gfx On gen7, including Haswell, the MI_FLUSH_DW command is not synchronous with the command streamer nor is there an option to make it so. To hide this we add a large delay on the CS so that the breadcrumb should always be visible before the interrupt. However, that does not seem to be enough to ensure the memory is actually coherent with the read of the breadcrumb. The breadcrumb update is a post-sync op... Throw in a preliminary MI_FLUSH_DW before the breadcrumb update in the hope that helps. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112147 Testcase: igt/i915_selftest/live_blt Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/gt/intel_ring_submission.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c index a47d5a7c32c9..fc29df712810 100644 --- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c +++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c @@ -454,6 +454,10 @@ static u32 *gen7_xcs_emit_breadcrumb(struct i915_request *rq, u32 *cs) GEM_BUG_ON(i915_request_active_timeline(rq)->hwsp_ggtt != rq->engine->status_page.vma); GEM_BUG_ON(offset_in_page(i915_request_active_timeline(rq)->hwsp_offset) != I915_GEM_HWS_SEQNO_ADDR); + *cs++ = MI_FLUSH_DW; + *cs++ = 0; + *cs++ = 0; + *cs++ = MI_FLUSH_DW | MI_FLUSH_DW_OP_STOREDW | MI_FLUSH_DW_STORE_INDEX; *cs++ = I915_GEM_HWS_SEQNO_ADDR | MI_FLUSH_DW_USE_GTT; *cs++ = rq->fence.seqno; @@ -469,7 +473,6 @@ static u32 *gen7_xcs_emit_breadcrumb(struct i915_request *rq, u32 *cs) *cs++ = 0; *cs++ = MI_USER_INTERRUPT; - *cs++ = MI_NOOP; rq->tail = intel_ring_offset(rq, cs); assert_ring_tail_valid(rq->ring, rq->tail); -- 2.24.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/gt: Try an extra flush on the Haswell blitter @ 2019-11-11 12:09 ` Chris Wilson 0 siblings, 0 replies; 10+ messages in thread From: Chris Wilson @ 2019-11-11 12:09 UTC (permalink / raw) To: intel-gfx On gen7, including Haswell, the MI_FLUSH_DW command is not synchronous with the command streamer nor is there an option to make it so. To hide this we add a large delay on the CS so that the breadcrumb should always be visible before the interrupt. However, that does not seem to be enough to ensure the memory is actually coherent with the read of the breadcrumb. The breadcrumb update is a post-sync op... Throw in a preliminary MI_FLUSH_DW before the breadcrumb update in the hope that helps. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112147 Testcase: igt/i915_selftest/live_blt Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/gt/intel_ring_submission.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c index a47d5a7c32c9..fc29df712810 100644 --- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c +++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c @@ -454,6 +454,10 @@ static u32 *gen7_xcs_emit_breadcrumb(struct i915_request *rq, u32 *cs) GEM_BUG_ON(i915_request_active_timeline(rq)->hwsp_ggtt != rq->engine->status_page.vma); GEM_BUG_ON(offset_in_page(i915_request_active_timeline(rq)->hwsp_offset) != I915_GEM_HWS_SEQNO_ADDR); + *cs++ = MI_FLUSH_DW; + *cs++ = 0; + *cs++ = 0; + *cs++ = MI_FLUSH_DW | MI_FLUSH_DW_OP_STOREDW | MI_FLUSH_DW_STORE_INDEX; *cs++ = I915_GEM_HWS_SEQNO_ADDR | MI_FLUSH_DW_USE_GTT; *cs++ = rq->fence.seqno; @@ -469,7 +473,6 @@ static u32 *gen7_xcs_emit_breadcrumb(struct i915_request *rq, u32 *cs) *cs++ = 0; *cs++ = MI_USER_INTERRUPT; - *cs++ = MI_NOOP; rq->tail = intel_ring_offset(rq, cs); assert_ring_tail_valid(rq->ring, rq->tail); -- 2.24.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 10+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/gt: Try an extra flush on the Haswell blitter @ 2019-11-11 18:45 ` Patchwork 0 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2019-11-11 18:45 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/gt: Try an extra flush on the Haswell blitter URL : https://patchwork.freedesktop.org/series/69293/ State : success == Summary == CI Bug Log - changes from CI_DRM_7310 -> Patchwork_15216 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/index.html Known issues ------------ Here are the changes found in Patchwork_15216 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live_hangcheck: - fi-icl-u4: [PASS][1] -> [DMESG-FAIL][2] ([fdo#111144] / [fdo#111678]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/fi-icl-u4/igt@i915_selftest@live_hangcheck.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/fi-icl-u4/igt@i915_selftest@live_hangcheck.html #### Possible fixes #### * igt@kms_setmode@basic-clone-single-crtc: - fi-skl-6770hq: [WARN][3] -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html [fdo#111144]: https://bugs.freedesktop.org/show_bug.cgi?id=111144 [fdo#111678]: https://bugs.freedesktop.org/show_bug.cgi?id=111678 Participating hosts (51 -> 45) ------------------------------ Additional (1): fi-bwr-2160 Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7310 -> Patchwork_15216 CI-20190529: 20190529 CI_DRM_7310: f3edc24676599b6c4e6ab713030ae630e864e732 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5271: 05f0400c50af843df301efb5475e9f5e2d16a098 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_15216: 2dfa98c490b5847e45e681f6c59745b331b915e2 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 2dfa98c490b5 drm/i915/gt: Try an extra flush on the Haswell blitter == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Try an extra flush on the Haswell blitter @ 2019-11-11 18:45 ` Patchwork 0 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2019-11-11 18:45 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/gt: Try an extra flush on the Haswell blitter URL : https://patchwork.freedesktop.org/series/69293/ State : success == Summary == CI Bug Log - changes from CI_DRM_7310 -> Patchwork_15216 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/index.html Known issues ------------ Here are the changes found in Patchwork_15216 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live_hangcheck: - fi-icl-u4: [PASS][1] -> [DMESG-FAIL][2] ([fdo#111144] / [fdo#111678]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/fi-icl-u4/igt@i915_selftest@live_hangcheck.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/fi-icl-u4/igt@i915_selftest@live_hangcheck.html #### Possible fixes #### * igt@kms_setmode@basic-clone-single-crtc: - fi-skl-6770hq: [WARN][3] -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/fi-skl-6770hq/igt@kms_setmode@basic-clone-single-crtc.html [fdo#111144]: https://bugs.freedesktop.org/show_bug.cgi?id=111144 [fdo#111678]: https://bugs.freedesktop.org/show_bug.cgi?id=111678 Participating hosts (51 -> 45) ------------------------------ Additional (1): fi-bwr-2160 Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7310 -> Patchwork_15216 CI-20190529: 20190529 CI_DRM_7310: f3edc24676599b6c4e6ab713030ae630e864e732 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5271: 05f0400c50af843df301efb5475e9f5e2d16a098 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_15216: 2dfa98c490b5847e45e681f6c59745b331b915e2 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 2dfa98c490b5 drm/i915/gt: Try an extra flush on the Haswell blitter == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/gt: Try an extra flush on the Haswell blitter @ 2019-11-12 6:33 ` Patchwork 0 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2019-11-12 6:33 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/gt: Try an extra flush on the Haswell blitter URL : https://patchwork.freedesktop.org/series/69293/ State : success == Summary == CI Bug Log - changes from CI_DRM_7310_full -> Patchwork_15216_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_15216_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@bcs0-s3: - shard-iclb: [PASS][1] -> [DMESG-WARN][2] ([fdo#111764]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb5/igt@gem_ctx_isolation@bcs0-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb5/igt@gem_ctx_isolation@bcs0-s3.html * igt@gem_ctx_persistence@vcs1-mixed: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb1/igt@gem_ctx_persistence@vcs1-mixed.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb3/igt@gem_ctx_persistence@vcs1-mixed.html * igt@gem_ctx_switch@vcs1-heavy: - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112080]) +16 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb1/igt@gem_ctx_switch@vcs1-heavy.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb8/igt@gem_ctx_switch@vcs1-heavy.html * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#110854]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb1/igt@gem_exec_balancer@smoke.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb3/igt@gem_exec_balancer@smoke.html * igt@gem_exec_schedule@deep-bsd: - shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb6/igt@gem_exec_schedule@deep-bsd.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb4/igt@gem_exec_schedule@deep-bsd.html * igt@gem_mmap_gtt@hang: - shard-snb: [PASS][11] -> [INCOMPLETE][12] ([fdo#105411]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-snb5/igt@gem_mmap_gtt@hang.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-snb1/igt@gem_mmap_gtt@hang.html * igt@gem_userptr_blits@map-fixed-invalidate-busy: - shard-snb: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy.html - shard-hsw: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-hsw7/igt@gem_userptr_blits@map-fixed-invalidate-busy.html * igt@i915_selftest@live_hangcheck: - shard-hsw: [PASS][17] -> [DMESG-FAIL][18] ([fdo#111991]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-hsw1/igt@i915_selftest@live_hangcheck.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-hsw6/igt@i915_selftest@live_hangcheck.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +8 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_flip@modeset-vs-vblank-race: - shard-hsw: [PASS][21] -> [DMESG-WARN][22] ([fdo#102614]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-hsw1/igt@kms_flip@modeset-vs-vblank-race.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-hsw5/igt@kms_flip@modeset-vs-vblank-race.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt: - shard-tglb: [PASS][23] -> [FAIL][24] ([fdo#103167]) +5 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite: - shard-iclb: [PASS][25] -> [FAIL][26] ([fdo#103167]) +5 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@psr-suspend: - shard-tglb: [PASS][27] -> [INCOMPLETE][28] ([fdo#111832] / [fdo#111850]) +2 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb2/igt@kms_frontbuffer_tracking@psr-suspend.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb4/igt@kms_frontbuffer_tracking@psr-suspend.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [PASS][29] -> [FAIL][30] ([fdo#108145] / [fdo#110403]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_psr2_su@page_flip: - shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109642] / [fdo#111068]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb2/igt@kms_psr2_su@page_flip.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb7/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb4/igt@kms_psr@psr2_primary_page_flip.html * igt@kms_setmode@basic: - shard-skl: [PASS][35] -> [FAIL][36] ([fdo#99912]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-skl1/igt@kms_setmode@basic.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-skl4/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-apl: [PASS][37] -> [DMESG-WARN][38] ([fdo#108566]) +2 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-apl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-apl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@prime_busy@hang-bsd2: - shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109276]) +23 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb2/igt@prime_busy@hang-bsd2.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb5/igt@prime_busy@hang-bsd2.html #### Possible fixes #### * igt@gem_busy@busy-vcs1: - shard-iclb: [SKIP][41] ([fdo#112080]) -> [PASS][42] +10 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb5/igt@gem_busy@busy-vcs1.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb2/igt@gem_busy@busy-vcs1.html * igt@gem_ctx_isolation@bcs0-s3: - shard-tglb: [INCOMPLETE][43] ([fdo#111832]) -> [PASS][44] +2 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb8/igt@gem_ctx_isolation@bcs0-s3.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb9/igt@gem_ctx_isolation@bcs0-s3.html * igt@gem_ctx_isolation@vcs1-dirty-create: - shard-iclb: [SKIP][45] ([fdo#109276] / [fdo#112080]) -> [PASS][46] +1 similar issue [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb3/igt@gem_ctx_isolation@vcs1-dirty-create.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb1/igt@gem_ctx_isolation@vcs1-dirty-create.html * igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd1: - shard-tglb: [INCOMPLETE][47] ([fdo#111677]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd1.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb5/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd1.html * igt@gem_exec_schedule@promotion-bsd1: - shard-iclb: [SKIP][49] ([fdo#109276]) -> [PASS][50] +21 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb8/igt@gem_exec_schedule@promotion-bsd1.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb4/igt@gem_exec_schedule@promotion-bsd1.html * igt@gem_exec_schedule@reorder-wide-bsd: - shard-iclb: [SKIP][51] ([fdo#112146]) -> [PASS][52] +3 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb1/igt@gem_exec_schedule@reorder-wide-bsd.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb5/igt@gem_exec_schedule@reorder-wide-bsd.html * igt@gem_softpin@noreloc-s3: - shard-apl: [DMESG-WARN][53] ([fdo#108566]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-apl6/igt@gem_softpin@noreloc-s3.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-apl2/igt@gem_softpin@noreloc-s3.html * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup: - shard-snb: [DMESG-WARN][55] ([fdo#111870]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html * igt@gem_userptr_blits@sync-unmap-after-close: - shard-hsw: [DMESG-WARN][57] ([fdo#111870]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-hsw4/igt@gem_userptr_blits@sync-unmap-after-close.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-hsw1/igt@gem_userptr_blits@sync-unmap-after-close.html * igt@i915_pm_rpm@system-suspend: - shard-skl: [INCOMPLETE][59] ([fdo#104108] / [fdo#107807]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-skl7/igt@i915_pm_rpm@system-suspend.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-skl1/igt@i915_pm_rpm@system-suspend.html * igt@kms_atomic_interruptible@legacy-dpms: - shard-hsw: [INCOMPLETE][61] ([fdo#103540]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-hsw7/igt@kms_atomic_interruptible@legacy-dpms.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-hsw6/igt@kms_atomic_interruptible@legacy-dpms.html * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding: - shard-snb: [SKIP][63] ([fdo#109271]) -> [PASS][64] +2 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-snb2/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-snb2/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html * igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled: - shard-iclb: [FAIL][65] ([fdo#103184] / [fdo#103232]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb7/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb6/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [FAIL][67] ([fdo#105363]) -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-snb: [DMESG-WARN][69] ([fdo#102365]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-snb1/igt@kms_flip@flip-vs-suspend-interruptible.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-snb1/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt: - shard-tglb: [FAIL][71] ([fdo#103167]) -> [PASS][72] +3 similar issues [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt: - shard-iclb: [FAIL][73] ([fdo#103167]) -> [PASS][74] +4 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-tglb: [INCOMPLETE][75] ([fdo#111832] / [fdo#111850] / [fdo#111884]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-suspend.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [FAIL][77] ([fdo#108145]) -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html * igt@kms_psr@psr2_cursor_blt: - shard-iclb: [SKIP][79] ([fdo#109441]) -> [PASS][80] +2 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb4/igt@kms_psr@psr2_cursor_blt.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html * igt@kms_psr@suspend: - shard-tglb: [INCOMPLETE][81] ([fdo#111832] / [fdo#111850]) -> [PASS][82] +4 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb5/igt@kms_psr@suspend.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb5/igt@kms_psr@suspend.html * igt@kms_setmode@basic: - shard-apl: [FAIL][83] ([fdo#99912]) -> [PASS][84] [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-apl7/igt@kms_setmode@basic.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-apl4/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-kbl: [DMESG-WARN][85] ([fdo#108566]) -> [PASS][86] +3 similar issues [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend: - shard-tglb: [INCOMPLETE][87] ([fdo#111850]) -> [PASS][88] +2 similar issues [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb1/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb4/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html #### Warnings #### * igt@gem_ctx_isolation@vcs2-nonpriv: - shard-tglb: [SKIP][89] ([fdo#111912] / [fdo#112080]) -> [SKIP][90] ([fdo#112080]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb3/igt@gem_ctx_isolation@vcs2-nonpriv.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb9/igt@gem_ctx_isolation@vcs2-nonpriv.html * igt@gem_ctx_isolation@vcs2-nonpriv-switch: - shard-tglb: [SKIP][91] ([fdo#112080]) -> [SKIP][92] ([fdo#111912] / [fdo#112080]) +1 similar issue [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb9/igt@gem_ctx_isolation@vcs2-nonpriv-switch.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb6/igt@gem_ctx_isolation@vcs2-nonpriv-switch.html * igt@gem_exec_schedule@deep-bsd1: - shard-tglb: [FAIL][93] ([fdo#111646]) -> [INCOMPLETE][94] ([fdo#111671]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb4/igt@gem_exec_schedule@deep-bsd1.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb1/igt@gem_exec_schedule@deep-bsd1.html [fdo#102365]: https://bugs.freedesktop.org/show_bug.cgi?id=102365 [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411 [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646 [fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671 [fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677 [fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764 [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832 [fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850 [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870 [fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884 [fdo#111912]: https://bugs.freedesktop.org/show_bug.cgi?id=111912 [fdo#111991]: https://bugs.freedesktop.org/show_bug.cgi?id=111991 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (11 -> 11) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7310 -> Patchwork_15216 CI-2019052 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Try an extra flush on the Haswell blitter @ 2019-11-12 6:33 ` Patchwork 0 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2019-11-12 6:33 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/gt: Try an extra flush on the Haswell blitter URL : https://patchwork.freedesktop.org/series/69293/ State : success == Summary == CI Bug Log - changes from CI_DRM_7310_full -> Patchwork_15216_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_15216_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@bcs0-s3: - shard-iclb: [PASS][1] -> [DMESG-WARN][2] ([fdo#111764]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb5/igt@gem_ctx_isolation@bcs0-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb5/igt@gem_ctx_isolation@bcs0-s3.html * igt@gem_ctx_persistence@vcs1-mixed: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb1/igt@gem_ctx_persistence@vcs1-mixed.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb3/igt@gem_ctx_persistence@vcs1-mixed.html * igt@gem_ctx_switch@vcs1-heavy: - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112080]) +16 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb1/igt@gem_ctx_switch@vcs1-heavy.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb8/igt@gem_ctx_switch@vcs1-heavy.html * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#110854]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb1/igt@gem_exec_balancer@smoke.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb3/igt@gem_exec_balancer@smoke.html * igt@gem_exec_schedule@deep-bsd: - shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb6/igt@gem_exec_schedule@deep-bsd.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb4/igt@gem_exec_schedule@deep-bsd.html * igt@gem_mmap_gtt@hang: - shard-snb: [PASS][11] -> [INCOMPLETE][12] ([fdo#105411]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-snb5/igt@gem_mmap_gtt@hang.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-snb1/igt@gem_mmap_gtt@hang.html * igt@gem_userptr_blits@map-fixed-invalidate-busy: - shard-snb: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy.html - shard-hsw: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-hsw7/igt@gem_userptr_blits@map-fixed-invalidate-busy.html * igt@i915_selftest@live_hangcheck: - shard-hsw: [PASS][17] -> [DMESG-FAIL][18] ([fdo#111991]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-hsw1/igt@i915_selftest@live_hangcheck.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-hsw6/igt@i915_selftest@live_hangcheck.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +8 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_flip@modeset-vs-vblank-race: - shard-hsw: [PASS][21] -> [DMESG-WARN][22] ([fdo#102614]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-hsw1/igt@kms_flip@modeset-vs-vblank-race.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-hsw5/igt@kms_flip@modeset-vs-vblank-race.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt: - shard-tglb: [PASS][23] -> [FAIL][24] ([fdo#103167]) +5 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite: - shard-iclb: [PASS][25] -> [FAIL][26] ([fdo#103167]) +5 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@psr-suspend: - shard-tglb: [PASS][27] -> [INCOMPLETE][28] ([fdo#111832] / [fdo#111850]) +2 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb2/igt@kms_frontbuffer_tracking@psr-suspend.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb4/igt@kms_frontbuffer_tracking@psr-suspend.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [PASS][29] -> [FAIL][30] ([fdo#108145] / [fdo#110403]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_psr2_su@page_flip: - shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109642] / [fdo#111068]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb2/igt@kms_psr2_su@page_flip.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb7/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb4/igt@kms_psr@psr2_primary_page_flip.html * igt@kms_setmode@basic: - shard-skl: [PASS][35] -> [FAIL][36] ([fdo#99912]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-skl1/igt@kms_setmode@basic.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-skl4/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-apl: [PASS][37] -> [DMESG-WARN][38] ([fdo#108566]) +2 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-apl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-apl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@prime_busy@hang-bsd2: - shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109276]) +23 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb2/igt@prime_busy@hang-bsd2.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb5/igt@prime_busy@hang-bsd2.html #### Possible fixes #### * igt@gem_busy@busy-vcs1: - shard-iclb: [SKIP][41] ([fdo#112080]) -> [PASS][42] +10 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb5/igt@gem_busy@busy-vcs1.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb2/igt@gem_busy@busy-vcs1.html * igt@gem_ctx_isolation@bcs0-s3: - shard-tglb: [INCOMPLETE][43] ([fdo#111832]) -> [PASS][44] +2 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb8/igt@gem_ctx_isolation@bcs0-s3.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb9/igt@gem_ctx_isolation@bcs0-s3.html * igt@gem_ctx_isolation@vcs1-dirty-create: - shard-iclb: [SKIP][45] ([fdo#109276] / [fdo#112080]) -> [PASS][46] +1 similar issue [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb3/igt@gem_ctx_isolation@vcs1-dirty-create.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb1/igt@gem_ctx_isolation@vcs1-dirty-create.html * igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd1: - shard-tglb: [INCOMPLETE][47] ([fdo#111677]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd1.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb5/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd1.html * igt@gem_exec_schedule@promotion-bsd1: - shard-iclb: [SKIP][49] ([fdo#109276]) -> [PASS][50] +21 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb8/igt@gem_exec_schedule@promotion-bsd1.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb4/igt@gem_exec_schedule@promotion-bsd1.html * igt@gem_exec_schedule@reorder-wide-bsd: - shard-iclb: [SKIP][51] ([fdo#112146]) -> [PASS][52] +3 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb1/igt@gem_exec_schedule@reorder-wide-bsd.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb5/igt@gem_exec_schedule@reorder-wide-bsd.html * igt@gem_softpin@noreloc-s3: - shard-apl: [DMESG-WARN][53] ([fdo#108566]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-apl6/igt@gem_softpin@noreloc-s3.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-apl2/igt@gem_softpin@noreloc-s3.html * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup: - shard-snb: [DMESG-WARN][55] ([fdo#111870]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html * igt@gem_userptr_blits@sync-unmap-after-close: - shard-hsw: [DMESG-WARN][57] ([fdo#111870]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-hsw4/igt@gem_userptr_blits@sync-unmap-after-close.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-hsw1/igt@gem_userptr_blits@sync-unmap-after-close.html * igt@i915_pm_rpm@system-suspend: - shard-skl: [INCOMPLETE][59] ([fdo#104108] / [fdo#107807]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-skl7/igt@i915_pm_rpm@system-suspend.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-skl1/igt@i915_pm_rpm@system-suspend.html * igt@kms_atomic_interruptible@legacy-dpms: - shard-hsw: [INCOMPLETE][61] ([fdo#103540]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-hsw7/igt@kms_atomic_interruptible@legacy-dpms.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-hsw6/igt@kms_atomic_interruptible@legacy-dpms.html * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding: - shard-snb: [SKIP][63] ([fdo#109271]) -> [PASS][64] +2 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-snb2/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-snb2/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html * igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled: - shard-iclb: [FAIL][65] ([fdo#103184] / [fdo#103232]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb7/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb6/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [FAIL][67] ([fdo#105363]) -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-snb: [DMESG-WARN][69] ([fdo#102365]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-snb1/igt@kms_flip@flip-vs-suspend-interruptible.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-snb1/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt: - shard-tglb: [FAIL][71] ([fdo#103167]) -> [PASS][72] +3 similar issues [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt: - shard-iclb: [FAIL][73] ([fdo#103167]) -> [PASS][74] +4 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-tglb: [INCOMPLETE][75] ([fdo#111832] / [fdo#111850] / [fdo#111884]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-suspend.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [FAIL][77] ([fdo#108145]) -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html * igt@kms_psr@psr2_cursor_blt: - shard-iclb: [SKIP][79] ([fdo#109441]) -> [PASS][80] +2 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-iclb4/igt@kms_psr@psr2_cursor_blt.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html * igt@kms_psr@suspend: - shard-tglb: [INCOMPLETE][81] ([fdo#111832] / [fdo#111850]) -> [PASS][82] +4 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb5/igt@kms_psr@suspend.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb5/igt@kms_psr@suspend.html * igt@kms_setmode@basic: - shard-apl: [FAIL][83] ([fdo#99912]) -> [PASS][84] [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-apl7/igt@kms_setmode@basic.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-apl4/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-kbl: [DMESG-WARN][85] ([fdo#108566]) -> [PASS][86] +3 similar issues [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend: - shard-tglb: [INCOMPLETE][87] ([fdo#111850]) -> [PASS][88] +2 similar issues [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb1/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb4/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html #### Warnings #### * igt@gem_ctx_isolation@vcs2-nonpriv: - shard-tglb: [SKIP][89] ([fdo#111912] / [fdo#112080]) -> [SKIP][90] ([fdo#112080]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb3/igt@gem_ctx_isolation@vcs2-nonpriv.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb9/igt@gem_ctx_isolation@vcs2-nonpriv.html * igt@gem_ctx_isolation@vcs2-nonpriv-switch: - shard-tglb: [SKIP][91] ([fdo#112080]) -> [SKIP][92] ([fdo#111912] / [fdo#112080]) +1 similar issue [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb9/igt@gem_ctx_isolation@vcs2-nonpriv-switch.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb6/igt@gem_ctx_isolation@vcs2-nonpriv-switch.html * igt@gem_exec_schedule@deep-bsd1: - shard-tglb: [FAIL][93] ([fdo#111646]) -> [INCOMPLETE][94] ([fdo#111671]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7310/shard-tglb4/igt@gem_exec_schedule@deep-bsd1.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/shard-tglb1/igt@gem_exec_schedule@deep-bsd1.html [fdo#102365]: https://bugs.freedesktop.org/show_bug.cgi?id=102365 [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411 [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646 [fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671 [fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677 [fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764 [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832 [fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850 [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870 [fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884 [fdo#111912]: https://bugs.freedesktop.org/show_bug.cgi?id=111912 [fdo#111991]: https://bugs.freedesktop.org/show_bug.cgi?id=111991 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (11 -> 11) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7310 -> Patchwork_15216 CI-2019052 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15216/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915/gt: Try an extra flush on the Haswell blitter @ 2019-11-12 13:58 ` Mika Kuoppala 0 siblings, 0 replies; 10+ messages in thread From: Mika Kuoppala @ 2019-11-12 13:58 UTC (permalink / raw) To: Chris Wilson, intel-gfx Chris Wilson <chris@chris-wilson.co.uk> writes: > On gen7, including Haswell, the MI_FLUSH_DW command is not synchronous > with the command streamer nor is there an option to make it so. To hide > this we add a large delay on the CS so that the breadcrumb should always > be visible before the interrupt. However, that does not seem to be > enough to ensure the memory is actually coherent with the read of the > breadcrumb. The breadcrumb update is a post-sync op... Throw in a > preliminary MI_FLUSH_DW before the breadcrumb update in the hope that > helps. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112147 If we are not sure, References > Testcase: igt/i915_selftest/live_blt > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > drivers/gpu/drm/i915/gt/intel_ring_submission.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > index a47d5a7c32c9..fc29df712810 100644 > --- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c > +++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > @@ -454,6 +454,10 @@ static u32 *gen7_xcs_emit_breadcrumb(struct i915_request *rq, u32 *cs) > GEM_BUG_ON(i915_request_active_timeline(rq)->hwsp_ggtt != rq->engine->status_page.vma); > GEM_BUG_ON(offset_in_page(i915_request_active_timeline(rq)->hwsp_offset) != I915_GEM_HWS_SEQNO_ADDR); > > + *cs++ = MI_FLUSH_DW; > + *cs++ = 0; > + *cs++ = 0; I see this as wmb wrt seqno write. Massive hammer would be to include timestamp write in here with tlb flush? But one can always hope. > + > *cs++ = MI_FLUSH_DW | MI_FLUSH_DW_OP_STOREDW | MI_FLUSH_DW_STORE_INDEX; > *cs++ = I915_GEM_HWS_SEQNO_ADDR | MI_FLUSH_DW_USE_GTT; > *cs++ = rq->fence.seqno; > @@ -469,7 +473,6 @@ static u32 *gen7_xcs_emit_breadcrumb(struct i915_request *rq, u32 *cs) > *cs++ = 0; > > *cs++ = MI_USER_INTERRUPT; > - *cs++ = MI_NOOP; Evens, Acked-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> > > rq->tail = intel_ring_offset(rq, cs); > assert_ring_tail_valid(rq->ring, rq->tail); > -- > 2.24.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Try an extra flush on the Haswell blitter @ 2019-11-12 13:58 ` Mika Kuoppala 0 siblings, 0 replies; 10+ messages in thread From: Mika Kuoppala @ 2019-11-12 13:58 UTC (permalink / raw) To: Chris Wilson, intel-gfx Chris Wilson <chris@chris-wilson.co.uk> writes: > On gen7, including Haswell, the MI_FLUSH_DW command is not synchronous > with the command streamer nor is there an option to make it so. To hide > this we add a large delay on the CS so that the breadcrumb should always > be visible before the interrupt. However, that does not seem to be > enough to ensure the memory is actually coherent with the read of the > breadcrumb. The breadcrumb update is a post-sync op... Throw in a > preliminary MI_FLUSH_DW before the breadcrumb update in the hope that > helps. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112147 If we are not sure, References > Testcase: igt/i915_selftest/live_blt > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > drivers/gpu/drm/i915/gt/intel_ring_submission.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > index a47d5a7c32c9..fc29df712810 100644 > --- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c > +++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > @@ -454,6 +454,10 @@ static u32 *gen7_xcs_emit_breadcrumb(struct i915_request *rq, u32 *cs) > GEM_BUG_ON(i915_request_active_timeline(rq)->hwsp_ggtt != rq->engine->status_page.vma); > GEM_BUG_ON(offset_in_page(i915_request_active_timeline(rq)->hwsp_offset) != I915_GEM_HWS_SEQNO_ADDR); > > + *cs++ = MI_FLUSH_DW; > + *cs++ = 0; > + *cs++ = 0; I see this as wmb wrt seqno write. Massive hammer would be to include timestamp write in here with tlb flush? But one can always hope. > + > *cs++ = MI_FLUSH_DW | MI_FLUSH_DW_OP_STOREDW | MI_FLUSH_DW_STORE_INDEX; > *cs++ = I915_GEM_HWS_SEQNO_ADDR | MI_FLUSH_DW_USE_GTT; > *cs++ = rq->fence.seqno; > @@ -469,7 +473,6 @@ static u32 *gen7_xcs_emit_breadcrumb(struct i915_request *rq, u32 *cs) > *cs++ = 0; > > *cs++ = MI_USER_INTERRUPT; > - *cs++ = MI_NOOP; Evens, Acked-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> > > rq->tail = intel_ring_offset(rq, cs); > assert_ring_tail_valid(rq->ring, rq->tail); > -- > 2.24.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915/gt: Try an extra flush on the Haswell blitter @ 2019-11-12 14:06 ` Chris Wilson 0 siblings, 0 replies; 10+ messages in thread From: Chris Wilson @ 2019-11-12 14:06 UTC (permalink / raw) To: Mika Kuoppala, intel-gfx Quoting Mika Kuoppala (2019-11-12 13:58:36) > Chris Wilson <chris@chris-wilson.co.uk> writes: > > > On gen7, including Haswell, the MI_FLUSH_DW command is not synchronous > > with the command streamer nor is there an option to make it so. To hide > > this we add a large delay on the CS so that the breadcrumb should always > > be visible before the interrupt. However, that does not seem to be > > enough to ensure the memory is actually coherent with the read of the > > breadcrumb. The breadcrumb update is a post-sync op... Throw in a > > preliminary MI_FLUSH_DW before the breadcrumb update in the hope that > > helps. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112147 > > If we are not sure, References Either way, I'm closing the bug :) > > Testcase: igt/i915_selftest/live_blt > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > --- > > drivers/gpu/drm/i915/gt/intel_ring_submission.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > > index a47d5a7c32c9..fc29df712810 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c > > +++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > > @@ -454,6 +454,10 @@ static u32 *gen7_xcs_emit_breadcrumb(struct i915_request *rq, u32 *cs) > > GEM_BUG_ON(i915_request_active_timeline(rq)->hwsp_ggtt != rq->engine->status_page.vma); > > GEM_BUG_ON(offset_in_page(i915_request_active_timeline(rq)->hwsp_offset) != I915_GEM_HWS_SEQNO_ADDR); > > > > + *cs++ = MI_FLUSH_DW; > > + *cs++ = 0; > > + *cs++ = 0; > > I see this as wmb wrt seqno write. > > Massive hammer would be to include timestamp write in here with tlb > flush? I'm pretty sure it's meant to be a post-sync write op. However, the evidence I think points towards this flush being ordered incorrect with the breadcrumb write, so anything goes. > But one can always hope. Yeah, small changes until we can declare victory then go back to sleep. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Try an extra flush on the Haswell blitter @ 2019-11-12 14:06 ` Chris Wilson 0 siblings, 0 replies; 10+ messages in thread From: Chris Wilson @ 2019-11-12 14:06 UTC (permalink / raw) To: Mika Kuoppala, intel-gfx Quoting Mika Kuoppala (2019-11-12 13:58:36) > Chris Wilson <chris@chris-wilson.co.uk> writes: > > > On gen7, including Haswell, the MI_FLUSH_DW command is not synchronous > > with the command streamer nor is there an option to make it so. To hide > > this we add a large delay on the CS so that the breadcrumb should always > > be visible before the interrupt. However, that does not seem to be > > enough to ensure the memory is actually coherent with the read of the > > breadcrumb. The breadcrumb update is a post-sync op... Throw in a > > preliminary MI_FLUSH_DW before the breadcrumb update in the hope that > > helps. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112147 > > If we are not sure, References Either way, I'm closing the bug :) > > Testcase: igt/i915_selftest/live_blt > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > --- > > drivers/gpu/drm/i915/gt/intel_ring_submission.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > > index a47d5a7c32c9..fc29df712810 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c > > +++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > > @@ -454,6 +454,10 @@ static u32 *gen7_xcs_emit_breadcrumb(struct i915_request *rq, u32 *cs) > > GEM_BUG_ON(i915_request_active_timeline(rq)->hwsp_ggtt != rq->engine->status_page.vma); > > GEM_BUG_ON(offset_in_page(i915_request_active_timeline(rq)->hwsp_offset) != I915_GEM_HWS_SEQNO_ADDR); > > > > + *cs++ = MI_FLUSH_DW; > > + *cs++ = 0; > > + *cs++ = 0; > > I see this as wmb wrt seqno write. > > Massive hammer would be to include timestamp write in here with tlb > flush? I'm pretty sure it's meant to be a post-sync write op. However, the evidence I think points towards this flush being ordered incorrect with the breadcrumb write, so anything goes. > But one can always hope. Yeah, small changes until we can declare victory then go back to sleep. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-11-12 14:06 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-11-11 12:09 [PATCH] drm/i915/gt: Try an extra flush on the Haswell blitter Chris Wilson 2019-11-11 12:09 ` [Intel-gfx] " Chris Wilson 2019-11-11 18:45 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-11-11 18:45 ` [Intel-gfx] " Patchwork 2019-11-12 6:33 ` ✓ Fi.CI.IGT: " Patchwork 2019-11-12 6:33 ` [Intel-gfx] " Patchwork 2019-11-12 13:58 ` [PATCH] " Mika Kuoppala 2019-11-12 13:58 ` [Intel-gfx] " Mika Kuoppala 2019-11-12 14:06 ` Chris Wilson 2019-11-12 14:06 ` [Intel-gfx] " Chris Wilson
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.