Re: Add smb3 mount helper

Re: Add smb3 mount helper

[Aurélien Aptel]

Steve French <smfrench@gmail.com> writes:
>     We want to encourage use of more secure SMB3, and don't want
>     people using cifs and this new helper makes it less confusing:
>          "mount -t smb3"
>     rather than
>          "mount -t cifs"
>     Users can still mount the old way, but if they use smb3 mount
>     helper (mount.smb3 or "mount -t smb3") it will be less confusing
>     and less likely to use older insecure dialects.

I don't think duplicating the source is a good idea. Could we just make
a symlink or hardlink at installation? Alternatively move the common
code to a separate file.


Cheers,
-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)

Re: Add smb3 mount helper

[Pavel Shilovsky]

пт, 5 апр. 2019 г. в 02:39, Aurélien Aptel <aaptel@suse.com>:
>
> Steve French <smfrench@gmail.com> writes:
> >     We want to encourage use of more secure SMB3, and don't want
> >     people using cifs and this new helper makes it less confusing:
> >          "mount -t smb3"
> >     rather than
> >          "mount -t cifs"
> >     Users can still mount the old way, but if they use smb3 mount
> >     helper (mount.smb3 or "mount -t smb3") it will be less confusing
> >     and less likely to use older insecure dialects.
>
> I don't think duplicating the source is a good idea. Could we just make
> a symlink or hardlink at installation? Alternatively move the common
> code to a separate file.
>
>

Agree. I suggest to move the common code to a separate file.

--
Best regards,
Pavel Shilovsky

Re: Add smb3 mount helper

[Steve French]

Yes - we could move common code to a common C file - would be fairly
easy to reduce most of the duplicated code (and can do the diff
between the two mount.cifs.c vs mount.smb3.c)  - goal is also to
behave differently for the two (we don't want to show/display/use
obsolete options in the mount.smb3.c flavor of the mount helper)

On Fri, Apr 5, 2019 at 4:39 AM Aurélien Aptel <aaptel@suse.com> wrote:
>
> Steve French <smfrench@gmail.com> writes:
> >     We want to encourage use of more secure SMB3, and don't want
> >     people using cifs and this new helper makes it less confusing:
> >          "mount -t smb3"
> >     rather than
> >          "mount -t cifs"
> >     Users can still mount the old way, but if they use smb3 mount
> >     helper (mount.smb3 or "mount -t smb3") it will be less confusing
> >     and less likely to use older insecure dialects.
>
> I don't think duplicating the source is a good idea. Could we just make
> a symlink or hardlink at installation? Alternatively move the common
> code to a separate file.
>
>
> Cheers,
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)



-- 
Thanks,

Steve