From: Felipe Balbi <balbi@kernel.org>
To: Stefan Wahren <stefan.wahren@i2se.com>,
John Youn <johnyoun@synopsys.com>
Cc: Gevorg Sahakyan <gevorg.sahakyan@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Minas Harutyunyan <minas.harutyunyan@synopsys.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: usb: dwc2: Print error if unable to set DMA coherent mask
Date: Fri, 09 Mar 2018 11:10:08 +0200 [thread overview]
Message-ID: <87sh99aa33.fsf@linux.intel.com> (raw)
Stefan Wahren <stefan.wahren@i2se.com> writes:
>> Stefan Wahren <stefan.wahren@i2se.com> hat am 12. Februar 2018 um 21:20 geschrieben:
>>
>>
>> We better print an error in case probing of dwc2 fails on
>> setting the DMA coherent mask.
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>> ---
>> drivers/usb/dwc2/platform.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
>> index 4703478..4ddbdbd 100644
>> --- a/drivers/usb/dwc2/platform.c
>> +++ b/drivers/usb/dwc2/platform.c
>> @@ -382,8 +382,10 @@ static int dwc2_driver_probe(struct platform_device *dev)
>> if (!dev->dev.dma_mask)
>> dev->dev.dma_mask = &dev->dev.coherent_dma_mask;
>> retval = dma_set_coherent_mask(&dev->dev, DMA_BIT_MASK(32));
>> - if (retval)
>> + if (retval) {
>> + dev_err(&dev->dev, "can't set coherent DMA mask: %d\n", retval);
>> return retval;
>> + }
>>
>> res = platform_get_resource(dev, IORESOURCE_MEM, 0);
>> hsotg->regs = devm_ioremap_resource(&dev->dev, res);
>> --
>> 2.7.4
>>
>
> ping ...
https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=57b1d49d4b9c6cde9fbe95c1a211b6bbea61c6fc
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Stefan Wahren <stefan.wahren@i2se.com>,
John Youn <johnyoun@synopsys.com>
Cc: Gevorg Sahakyan <gevorg.sahakyan@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Minas Harutyunyan <minas.harutyunyan@synopsys.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc2: Print error if unable to set DMA coherent mask
Date: Fri, 09 Mar 2018 11:10:08 +0200 [thread overview]
Message-ID: <87sh99aa33.fsf@linux.intel.com> (raw)
In-Reply-To: <1893294987.392820.1520530314966@email.1und1.de>
[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]
Stefan Wahren <stefan.wahren@i2se.com> writes:
>> Stefan Wahren <stefan.wahren@i2se.com> hat am 12. Februar 2018 um 21:20 geschrieben:
>>
>>
>> We better print an error in case probing of dwc2 fails on
>> setting the DMA coherent mask.
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>> ---
>> drivers/usb/dwc2/platform.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
>> index 4703478..4ddbdbd 100644
>> --- a/drivers/usb/dwc2/platform.c
>> +++ b/drivers/usb/dwc2/platform.c
>> @@ -382,8 +382,10 @@ static int dwc2_driver_probe(struct platform_device *dev)
>> if (!dev->dev.dma_mask)
>> dev->dev.dma_mask = &dev->dev.coherent_dma_mask;
>> retval = dma_set_coherent_mask(&dev->dev, DMA_BIT_MASK(32));
>> - if (retval)
>> + if (retval) {
>> + dev_err(&dev->dev, "can't set coherent DMA mask: %d\n", retval);
>> return retval;
>> + }
>>
>> res = platform_get_resource(dev, IORESOURCE_MEM, 0);
>> hsotg->regs = devm_ioremap_resource(&dev->dev, res);
>> --
>> 2.7.4
>>
>
> ping ...
https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=57b1d49d4b9c6cde9fbe95c1a211b6bbea61c6fc
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next reply other threads:[~2018-03-09 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 9:10 Felipe Balbi [this message]
2018-03-09 9:10 ` [PATCH] usb: dwc2: Print error if unable to set DMA coherent mask Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2018-03-08 17:31 Stefan Wahren
2018-03-08 17:31 ` [PATCH] " Stefan Wahren
2018-02-12 20:20 Stefan Wahren
2018-02-12 20:20 ` [PATCH] " Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh99aa33.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=gevorg.sahakyan@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=johnyoun@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=minas.harutyunyan@synopsys.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.