Re: [PATCH 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 26 Jan 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Preproduction sdv are not supported beyond the release of production
> hardware, and continued use is ill-advised. Mark the kernel as tainted
> to reinforce the error.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index c2c210b0f47f..ce22ab426d86 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -787,9 +787,11 @@ static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
>  	sdv |= IS_HSW_EARLY_SDV(dev_priv);
>  	sdv |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
>  
> -	if (sdv)
> +	if (sdv) {
>  		DRM_ERROR("This is a pre-production stepping. "
>  			  "It may not be fully functional.\n");
> +		add_taint(TAINT_MACHINE_CHECK, LOCKDEP_STILL_OK);

This is rather harsh, but I suppose it should be. Popularity contest in
the kernel suggests it's not used lightly (actually not much at all).

Acked-by: Jani Nikula <jani.nikula@intel.com>



> +	}
>  }
>  
>  /**

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx