Re: [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 26 Jan 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> As we add new generations, we should keep detecting new system
> development platforms that were temporarily enabled (via
> "i915.alpha_support") and now superseded by production systems. To make
> it easier to add more platforms, split the if into a series of logical
> operations.

Please be careful not to conflate preproduction/early hardware with
alpha support in the driver. They are two distinct things. The former is
purely about hardware. The latter is purely about software.

(Okay, there's the dependency that we're probably unable to say we have
a production quality driver until we have production quality hardware to
test it on.)

BR,
Jani.


>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 008fc1e62a69..c2c210b0f47f 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -782,8 +782,12 @@ static void i915_workqueues_cleanup(struct drm_i915_private *dev_priv)
>   */
>  static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
>  {
> -	if (IS_HSW_EARLY_SDV(dev_priv) ||
> -	    IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
> +	bool sdv = false;
> +
> +	sdv |= IS_HSW_EARLY_SDV(dev_priv);
> +	sdv |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
> +
> +	if (sdv)
>  		DRM_ERROR("This is a pre-production stepping. "
>  			  "It may not be fully functional.\n");
>  }

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx