All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Kalle Valo <kvalo@codeaurora.org>,
	Wireless <linux-wireless@vger.kernel.org>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Xinming Hu <huxm@marvell.com>,
	Amitkumar Karwar <akarwar@marvell.com>
Subject: Re: linux-next: build warning after merge of the wireless-drivers-next tree
Date: Fri, 13 Jan 2017 15:47:41 +0200	[thread overview]
Message-ID: <87shonjcle.fsf@codeaurora.org> (raw)
In-Reply-To: <20170113111250.2023a160@canb.auug.org.au> (Stephen Rothwell's message of "Fri, 13 Jan 2017 11:12:50 +1100")

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi all,
>
> After merging the wireless-drivers-next tree, today's linux-next build
> (x86_64 allmodconfig) produced this warning:
>
> drivers/net/wireless/marvell/mwifiex/pcie.c: In function 'mwifiex_pcie_remove':
> drivers/net/wireless/marvell/mwifiex/pcie.c:303:5: warning: 'fw_status' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   if (fw_status == FIRMWARE_READY_PCIE && !adapter->mfg_mode) {
>      ^
>
> Introduced by commit
>
>   045f0c1b5e26 ("mwifiex: get rid of global user_rmmod flag")
>
> This is not a false positive since "reg" could be NULL just above
> (otherwise it would be tested for).

Thanks, I noticed this myself yesterday (after I had applied the patch)
and I have asked Marvell to send a fix.

-- 
Kalle Valo

  reply	other threads:[~2017-01-13 13:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13  0:12 linux-next: build warning after merge of the wireless-drivers-next tree Stephen Rothwell
2017-01-13 13:47 ` Kalle Valo [this message]
2017-01-17 11:49   ` Kalle Valo
  -- strict thread matches above, loose matches on Subject: below --
2021-06-24  2:16 Stephen Rothwell
2021-06-24  5:49 ` Kalle Valo
2019-01-30 23:46 Stephen Rothwell
2019-01-30 23:51 ` Luca Coelho
     [not found]   ` <9455f1b9e746f2c28d1573ccdce3836ece42cd8a.camel-XPOmlcxoEMv1KXRcyAk9cg@public.gmane.org>
2019-01-31 13:46     ` Kalle Valo
2019-01-31 13:46       ` Kalle Valo
2019-01-31 20:52       ` Stephen Rothwell
2016-11-28  0:58 Stephen Rothwell
2016-11-28  7:25 ` Kalle Valo
2016-11-28  8:16   ` Barry Day
2016-11-28 11:44     ` Kalle Valo
2016-11-28 12:26       ` Jes Sorensen
2016-07-20  2:25 Stephen Rothwell
2016-07-20  2:25 ` Stephen Rothwell
2016-07-20  6:18 ` Reizer, Eyal
     [not found]   ` <8665E2433BC68541A24DFFCA87B70F5B3616184A-1tpBd5JUCm6IQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2016-07-20 18:41     ` Kalle Valo
2016-07-20 18:41       ` Kalle Valo
2016-07-08  1:32 Stephen Rothwell
2016-07-08  1:32 ` Stephen Rothwell
2016-07-08  1:35 ` Stephen Rothwell
2016-07-08  1:35   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shonjcle.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=akarwar@marvell.com \
    --cc=huxm@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.