From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: "Reizer, Eyal" <eyalr-l0cyMroinI0@public.gmane.org>
Cc: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>,
"linux-wireless@vger.kernel.org"
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-next@vger.kernel.org"
<linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel@vger.kernel.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: linux-next: build warning after merge of the wireless-drivers-next tree
Date: Wed, 20 Jul 2016 21:41:49 +0300 [thread overview]
Message-ID: <87oa5sqhhu.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <8665E2433BC68541A24DFFCA87B70F5B3616184A-1tpBd5JUCm6IQmiDNMet8wC/G2K4zDHf@public.gmane.org> (Eyal Reizer's message of "Wed, 20 Jul 2016 06:18:00 +0000")
"Reizer, Eyal" <eyalr-l0cyMroinI0@public.gmane.org> writes:
>> After merging the wireless-drivers-next tree, today's linux-next build
>> (x86_64 allmodconfig) produced this warning:
>>
>> drivers/net/wireless/ti/wlcore/spi.c: In function 'wlcore_probe_of':
>> drivers/net/wireless/ti/wlcore/spi.c:457:6: warning: unused variable 'ret' [-
>> Wunused-variable]
>> int ret;
>> ^
>>
>> Introduced by commit
>>
>> 01efe65aba65 ("wlcore: spi: add wl18xx support")
>
> Of course you are right. It is indeed redundant now. Don't know how I
>have missed it. Don't remember seeing a warning from the tool chain I
>have used. Anyway ,will submit an amended patch soon.
I didn't notice it either as I didn't have CONFIG_WLCORE_SPI enabled.
But what's odd is that kbuild didn't report anything, it's usually quite
good to catch warnings like this.
Anyway, I have pushed the fix to wireless-drivers-next:
cb6a11518850 wlcore: spi: fix build warning caused by redundant variable
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: "Reizer\, Eyal" <eyalr@ti.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"linux-next\@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the wireless-drivers-next tree
Date: Wed, 20 Jul 2016 21:41:49 +0300 [thread overview]
Message-ID: <87oa5sqhhu.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <8665E2433BC68541A24DFFCA87B70F5B3616184A@DFRE01.ent.ti.com> (Eyal Reizer's message of "Wed, 20 Jul 2016 06:18:00 +0000")
"Reizer, Eyal" <eyalr@ti.com> writes:
>> After merging the wireless-drivers-next tree, today's linux-next build
>> (x86_64 allmodconfig) produced this warning:
>>
>> drivers/net/wireless/ti/wlcore/spi.c: In function 'wlcore_probe_of':
>> drivers/net/wireless/ti/wlcore/spi.c:457:6: warning: unused variable 'ret' [-
>> Wunused-variable]
>> int ret;
>> ^
>>
>> Introduced by commit
>>
>> 01efe65aba65 ("wlcore: spi: add wl18xx support")
>
> Of course you are right. It is indeed redundant now. Don't know how I
>have missed it. Don't remember seeing a warning from the tool chain I
>have used. Anyway ,will submit an amended patch soon.
I didn't notice it either as I didn't have CONFIG_WLCORE_SPI enabled.
But what's odd is that kbuild didn't report anything, it's usually quite
good to catch warnings like this.
Anyway, I have pushed the fix to wireless-drivers-next:
cb6a11518850 wlcore: spi: fix build warning caused by redundant variable
--
Kalle Valo
next prev parent reply other threads:[~2016-07-20 18:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 2:25 linux-next: build warning after merge of the wireless-drivers-next tree Stephen Rothwell
2016-07-20 2:25 ` Stephen Rothwell
2016-07-20 6:18 ` Reizer, Eyal
[not found] ` <8665E2433BC68541A24DFFCA87B70F5B3616184A-1tpBd5JUCm6IQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2016-07-20 18:41 ` Kalle Valo [this message]
2016-07-20 18:41 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2021-06-24 2:16 Stephen Rothwell
2021-06-24 5:49 ` Kalle Valo
2019-01-30 23:46 Stephen Rothwell
2019-01-30 23:51 ` Luca Coelho
[not found] ` <9455f1b9e746f2c28d1573ccdce3836ece42cd8a.camel-XPOmlcxoEMv1KXRcyAk9cg@public.gmane.org>
2019-01-31 13:46 ` Kalle Valo
2019-01-31 13:46 ` Kalle Valo
2019-01-31 20:52 ` Stephen Rothwell
2017-01-13 0:12 Stephen Rothwell
2017-01-13 13:47 ` Kalle Valo
2017-01-17 11:49 ` Kalle Valo
2016-11-28 0:58 Stephen Rothwell
2016-11-28 7:25 ` Kalle Valo
2016-11-28 8:16 ` Barry Day
2016-11-28 11:44 ` Kalle Valo
2016-11-28 12:26 ` Jes Sorensen
2016-07-08 1:32 Stephen Rothwell
2016-07-08 1:32 ` Stephen Rothwell
2016-07-08 1:35 ` Stephen Rothwell
2016-07-08 1:35 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa5sqhhu.fsf@kamboji.qca.qualcomm.com \
--to=kvalo-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
--cc=eyalr-l0cyMroinI0@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.