* [PATCH] drm/edid: constify edid quirk list
@ 2016-12-28 11:06 Jani Nikula
2016-12-28 13:07 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Jani Nikula @ 2016-12-28 11:06 UTC (permalink / raw)
To: dri-devel; +Cc: jani.nikula
No reason not to be const.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/drm_edid.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 67d6a73731d8..4ff04aa84dd0 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -91,7 +91,7 @@ struct detailed_mode_closure {
#define LEVEL_GTF2 2
#define LEVEL_CVT 3
-static struct edid_quirk {
+static const struct edid_quirk {
char vendor[4];
int product_id;
u32 quirks;
@@ -1478,7 +1478,7 @@ EXPORT_SYMBOL(drm_edid_duplicate);
*
* Returns true if @vendor is in @edid, false otherwise
*/
-static bool edid_vendor(struct edid *edid, char *vendor)
+static bool edid_vendor(struct edid *edid, const char *vendor)
{
char edid_vendor[3];
@@ -1498,7 +1498,7 @@ static bool edid_vendor(struct edid *edid, char *vendor)
*/
static u32 edid_get_quirks(struct edid *edid)
{
- struct edid_quirk *quirk;
+ const struct edid_quirk *quirk;
int i;
for (i = 0; i < ARRAY_SIZE(edid_quirk_list); i++) {
--
2.1.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/edid: constify edid quirk list
2016-12-28 11:06 [PATCH] drm/edid: constify edid quirk list Jani Nikula
@ 2016-12-28 13:07 ` Daniel Vetter
2017-01-02 13:24 ` Jani Nikula
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2016-12-28 13:07 UTC (permalink / raw)
To: Jani Nikula; +Cc: dri-devel
On Wed, Dec 28, 2016 at 01:06:26PM +0200, Jani Nikula wrote:
> No reason not to be const.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/drm_edid.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 67d6a73731d8..4ff04aa84dd0 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -91,7 +91,7 @@ struct detailed_mode_closure {
> #define LEVEL_GTF2 2
> #define LEVEL_CVT 3
>
> -static struct edid_quirk {
> +static const struct edid_quirk {
> char vendor[4];
> int product_id;
> u32 quirks;
> @@ -1478,7 +1478,7 @@ EXPORT_SYMBOL(drm_edid_duplicate);
> *
> * Returns true if @vendor is in @edid, false otherwise
> */
> -static bool edid_vendor(struct edid *edid, char *vendor)
> +static bool edid_vendor(struct edid *edid, const char *vendor)
> {
> char edid_vendor[3];
>
> @@ -1498,7 +1498,7 @@ static bool edid_vendor(struct edid *edid, char *vendor)
> */
> static u32 edid_get_quirks(struct edid *edid)
> {
> - struct edid_quirk *quirk;
> + const struct edid_quirk *quirk;
> int i;
>
> for (i = 0; i < ARRAY_SIZE(edid_quirk_list); i++) {
> --
> 2.1.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/edid: constify edid quirk list
2016-12-28 13:07 ` Daniel Vetter
@ 2017-01-02 13:24 ` Jani Nikula
0 siblings, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2017-01-02 13:24 UTC (permalink / raw)
To: Daniel Vetter; +Cc: dri-devel
On Wed, 28 Dec 2016, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Dec 28, 2016 at 01:06:26PM +0200, Jani Nikula wrote:
>> No reason not to be const.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Pushed, thanks for the review.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/drm_edid.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
>> index 67d6a73731d8..4ff04aa84dd0 100644
>> --- a/drivers/gpu/drm/drm_edid.c
>> +++ b/drivers/gpu/drm/drm_edid.c
>> @@ -91,7 +91,7 @@ struct detailed_mode_closure {
>> #define LEVEL_GTF2 2
>> #define LEVEL_CVT 3
>>
>> -static struct edid_quirk {
>> +static const struct edid_quirk {
>> char vendor[4];
>> int product_id;
>> u32 quirks;
>> @@ -1478,7 +1478,7 @@ EXPORT_SYMBOL(drm_edid_duplicate);
>> *
>> * Returns true if @vendor is in @edid, false otherwise
>> */
>> -static bool edid_vendor(struct edid *edid, char *vendor)
>> +static bool edid_vendor(struct edid *edid, const char *vendor)
>> {
>> char edid_vendor[3];
>>
>> @@ -1498,7 +1498,7 @@ static bool edid_vendor(struct edid *edid, char *vendor)
>> */
>> static u32 edid_get_quirks(struct edid *edid)
>> {
>> - struct edid_quirk *quirk;
>> + const struct edid_quirk *quirk;
>> int i;
>>
>> for (i = 0; i < ARRAY_SIZE(edid_quirk_list); i++) {
>> --
>> 2.1.4
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-02 13:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-28 11:06 [PATCH] drm/edid: constify edid quirk list Jani Nikula
2016-12-28 13:07 ` Daniel Vetter
2017-01-02 13:24 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.