All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: Configure beacons for AP vif if this has not happened yet
Date: Fri, 13 Mar 2015 16:14:46 +0200	[thread overview]
Message-ID: <87sid9q90p.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1426253587-11397-1-git-send-email-benjamin@sipsolutions.net> (Benjamin Berg's message of "Fri, 13 Mar 2015 14:33:07 +0100")

Benjamin Berg <benjamin@sipsolutions.net> writes:

> Right now there is a bug where beaconing might not be enabled correctly
> if the user has configuring multiple VIFs.
> The issue surfaces if the userspace first creates the AP devices and
> only then configures the first VIF (ath9k_bss_info_changed is called).
> In this case the current ath9k_allow_beacon_config implementation will
> not allow configuration as multiple AP VIFs are already present and
> beaconing is never configured in the driver.
>
> This issue was probably introduced back in 2012 by commit ef4ad6336
> "ath9k: Cleanup beacon logic". The fix in this patch simply checks
> whether beaconing has been configured yet (or configuration is scheduled)
> and allows the configuration in that case. This works around the issue
> here, but I have no idea whether it is a sane solution.
>
> Signed-off-by: Benjamin Berg <benjamin@sipsolutions.net>

Sorry, I guess I missed this the last time but ath9k patches need to be
CCed to linux-wireless for wider review.

-- 
Kalle Valo

  reply	other threads:[~2015-03-13 14:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13 13:33 [ath9k-devel] [PATCH] ath9k: Configure beacons for AP vif if this has not happened yet Benjamin Berg
2015-03-13 14:14 ` Kalle Valo [this message]
2015-03-13 14:27 ` Felix Fietkau
2015-03-13 15:37   ` Benjamin Berg
2015-03-13 15:51   ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sid9q90p.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.